43e7a00db0
## Description This PR fixes issue of file picker not showing up in firefox, The issue occurred because the function being triggered on script load `gapiLoaded`, was defined in a script that would load after `gapi`. Even though `gapi` is being loaded asynchronously, in case of firefox when using with windows OS, it would load before the script which had onload function defined. This PR fixes the issue by defining onload function in a script that loads before `gapi` > Add a TL;DR when description is extra long (helps content team) Fixes #21033 > if no issue exists, please create an issue and ask the maintainers about this first Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”> |
||
|---|---|---|
| .. | ||
| libraries | ||
| static/img | ||
| tinymce | ||
| 404-image.png | ||
| 404.css | ||
| 404.html | ||
| favicon-black.ico | ||
| index.html | ||
| manifest.json | ||
| page.min.js | ||
| privacy-policy.html | ||
| terms-and-conditions.html | ||
