Split of evalutions actions is required to add module specific events on ee. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: Ashit Rath <ashit@appsmith.com>
122 lines
3.5 KiB
TypeScript
122 lines
3.5 KiB
TypeScript
import type { ReduxAction } from "@appsmith/constants/ReduxActionConstants";
|
|
import { ReduxActionTypes } from "@appsmith/constants/ReduxActionConstants";
|
|
import { intersection } from "lodash";
|
|
import type { DependencyMap } from "utils/DynamicBindingUtils";
|
|
import type { QueryActionConfig } from "entities/Action";
|
|
import type { DatasourceConfiguration } from "entities/Datasource";
|
|
import type { DiffWithReferenceState } from "workers/Evaluation/helpers";
|
|
import {
|
|
EVALUATE_REDUX_ACTIONS,
|
|
EVAL_AND_LINT_REDUX_ACTIONS,
|
|
LINT_REDUX_ACTIONS,
|
|
LOG_REDUX_ACTIONS,
|
|
} from "@appsmith/actions/evaluationActionsList";
|
|
|
|
export const shouldTriggerEvaluation = (action: ReduxAction<unknown>) => {
|
|
return (
|
|
shouldProcessAction(action) && EVALUATE_REDUX_ACTIONS.includes(action.type)
|
|
);
|
|
};
|
|
export const shouldTriggerLinting = (action: ReduxAction<unknown>) => {
|
|
return shouldProcessAction(action) && !!LINT_REDUX_ACTIONS[action.type];
|
|
};
|
|
|
|
export const getAllActionTypes = (action: ReduxAction<unknown>) => {
|
|
if (
|
|
action.type === ReduxActionTypes.BATCH_UPDATES_SUCCESS &&
|
|
Array.isArray(action.payload)
|
|
) {
|
|
const batchedActionTypes = action.payload.map(
|
|
(batchedAction) => batchedAction.type as string,
|
|
);
|
|
return batchedActionTypes;
|
|
}
|
|
return [action.type];
|
|
};
|
|
|
|
export const shouldProcessAction = (action: ReduxAction<unknown>) => {
|
|
const actionTypes = getAllActionTypes(action);
|
|
|
|
return intersection(EVAL_AND_LINT_REDUX_ACTIONS, actionTypes).length > 0;
|
|
};
|
|
|
|
export function shouldLog(action: ReduxAction<unknown>) {
|
|
if (
|
|
action.type === ReduxActionTypes.BATCH_UPDATES_SUCCESS &&
|
|
Array.isArray(action.payload)
|
|
) {
|
|
const batchedActionTypes = action.payload.map(
|
|
(batchedAction) => batchedAction.type,
|
|
);
|
|
return batchedActionTypes.some(
|
|
(actionType) => LOG_REDUX_ACTIONS[actionType],
|
|
);
|
|
}
|
|
|
|
return LOG_REDUX_ACTIONS[action.type];
|
|
}
|
|
|
|
export const setEvaluatedTree = (
|
|
updates: DiffWithReferenceState[],
|
|
): ReduxAction<{ updates: DiffWithReferenceState[] }> => {
|
|
return {
|
|
type: ReduxActionTypes.SET_EVALUATED_TREE,
|
|
payload: { updates },
|
|
};
|
|
};
|
|
|
|
export const setDependencyMap = (
|
|
inverseDependencyMap: DependencyMap,
|
|
): ReduxAction<{ inverseDependencyMap: DependencyMap }> => {
|
|
return {
|
|
type: ReduxActionTypes.SET_EVALUATION_INVERSE_DEPENDENCY_MAP,
|
|
payload: { inverseDependencyMap },
|
|
};
|
|
};
|
|
|
|
// Called when a form is being setup, for setting up the base condition evaluations for the form
|
|
export const initFormEvaluations = (
|
|
editorConfig: any,
|
|
settingConfig: any,
|
|
formId: string,
|
|
) => {
|
|
return {
|
|
type: ReduxActionTypes.INIT_FORM_EVALUATION,
|
|
payload: { editorConfig, settingConfig, formId },
|
|
};
|
|
};
|
|
|
|
// Called when there is change in the data of the form, re evaluates the whole form
|
|
export const startFormEvaluations = (
|
|
formId: string,
|
|
formData: QueryActionConfig,
|
|
datasourceId: string,
|
|
pluginId: string,
|
|
actionDiffPath?: string,
|
|
hasRouteChanged?: boolean,
|
|
datasourceConfiguration?: DatasourceConfiguration,
|
|
) => {
|
|
return {
|
|
type: ReduxActionTypes.RUN_FORM_EVALUATION,
|
|
payload: {
|
|
formId,
|
|
actionConfiguration: formData,
|
|
datasourceId,
|
|
pluginId,
|
|
actionDiffPath,
|
|
hasRouteChanged,
|
|
datasourceConfiguration,
|
|
},
|
|
};
|
|
};
|
|
|
|
// These actions require the entire tree to be re-evaluated
|
|
const FORCE_EVAL_ACTIONS = {
|
|
[ReduxActionTypes.INSTALL_LIBRARY_SUCCESS]: true,
|
|
[ReduxActionTypes.UNINSTALL_LIBRARY_SUCCESS]: true,
|
|
};
|
|
|
|
export const shouldForceEval = (action: ReduxAction<unknown>) => {
|
|
return !!FORCE_EVAL_ACTIONS[action.type];
|
|
};
|