Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
f49cf0a219
PromucFlow_constructor/app/server
History
Nilansh Bansal 00fb934f34
fix: updated the max connection pool size and datasourceDestroy method (#36631) 
## Description
- This PR updates the max connection pool size for MySQL datasource from
5 to 20 as from the logs we found out that the maximum connections are
always getting used.
- This PR also updates the datasourceDestroy method for MySQL plugin to
ensure the graceful shutdown of thread takes places and ensures the
connection is closed as opposed to immediate termination of the thread
earlier which does not ensure closure of existing connection.

<img width="1100" alt="SCR-20241001-lbq-2"
src="https://github.com/user-attachments/assets/1f9e5b10-3036-41bc-94a7-8fa39056bcd6">



Fixes #34028  

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11129233985>
> Commit: 04617ce742961952b863cedaff60060bd46c02b0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11129233985&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Tue, 01 Oct 2024 16:44:48 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Increased the maximum connection pool size for MySQL from 5 to 20,
allowing for more concurrent database connections.
  
- **Bug Fixes**
- Improved the termination process of the SSH tunnel thread for better
handling during datasource destruction.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-10-02 10:21:53 +05:30
..
.run feat: Databricks plugin (#29746) 2023-12-26 10:04:09 +05:30
appsmith-git chore: making autocommit GA (#36347) 2024-09-25 14:32:01 +05:30
appsmith-interfaces chore: Upgrading spring to 3.3.3 to resolve vulnerable dependencies (#36266) 2024-10-01 22:12:56 +05:30
appsmith-plugins fix: updated the max connection pool size and datasourceDestroy method (#36631) 2024-10-02 10:21:53 +05:30
appsmith-server fix: updated the max connection pool size and datasourceDestroy method (#36631) 2024-10-02 10:21:53 +05:30
envs test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
mongo-seed
reactive-caching chore: Upgrading spring to 3.3.3 to resolve vulnerable dependencies (#36266) 2024-10-01 22:12:56 +05:30
scripts chore: Revert "chore: delete redundant files" (#35022) 2024-07-18 16:18:10 +05:30
.gitignore chore: Removed failed tests file from git (#29602) 2023-12-14 13:02:36 +05:30
build.sh test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
buildpack-run.sh
pom.xml chore: Upgrading spring to 3.3.3 to resolve vulnerable dependencies (#36266) 2024-10-01 22:12:56 +05:30
Procfile
README.md
system.properties

README.md

Appsmith Server

This is the server-side repository for the Appsmith framework.

For details on setting up your development machine, please refer to this Setup Guide.