a4972258ed
## Description - In the fixed layout system, the background of the canvas fell short of the bottom most widget. - This was due to an unnecessary `height: 100%` applied to the Fixed layout system. - Changed the code so that the `height: 100%` is only applied in the Anvil layout system #### PR fixes following issue(s) Fixes #29797 Fixes #29883 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress #### Test Plan #### Issues raised during DP testing ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Enhanced the Canvas layout to adjust its height dynamically according to the layout system in use. - **Tests** - Introduced tests to validate the main container's overflow behavior in mobile responsive scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
120 lines
3.8 KiB
JSON
120 lines
3.8 KiB
JSON
{
|
|
"dsl": {
|
|
"widgetName": "MainContainer",
|
|
"backgroundColor": "none",
|
|
"rightColumn": 4896,
|
|
"snapColumns": 64,
|
|
"detachFromLayout": true,
|
|
"widgetId": "0",
|
|
"topRow": 0,
|
|
"bottomRow": 1390,
|
|
"containerStyle": "none",
|
|
"snapRows": 124,
|
|
"parentRowSpace": 1,
|
|
"type": "CANVAS_WIDGET",
|
|
"canExtend": true,
|
|
"version": 87,
|
|
"minHeight": 1292,
|
|
"dynamicTriggerPathList": [],
|
|
"parentColumnSpace": 1,
|
|
"dynamicBindingPathList": [],
|
|
"leftColumn": 0,
|
|
"children": [
|
|
{
|
|
"boxShadow": "{{appsmith.theme.boxShadow.appBoxShadow}}",
|
|
"borderColor": "#E0DEDE",
|
|
"isVisibleDownload": true,
|
|
"iconSVG": "https://release-appcdn.appsmith.com/static/media/icon.e6911f8bb94dc6c4a102a74740c41763.svg",
|
|
"topRow": 111,
|
|
"isSortable": true,
|
|
"type": "TABLE_WIDGET_V2",
|
|
"inlineEditingSaveOption": "ROW_LEVEL",
|
|
"animateLoading": true,
|
|
"dynamicBindingPathList": [
|
|
{
|
|
"key": "accentColor"
|
|
},
|
|
{
|
|
"key": "borderRadius"
|
|
},
|
|
{
|
|
"key": "boxShadow"
|
|
}
|
|
],
|
|
"needsHeightForContent": true,
|
|
"leftColumn": 3,
|
|
"delimiter": ",",
|
|
"defaultSelectedRowIndex": 0,
|
|
"flexVerticalAlignment": "start",
|
|
"accentColor": "{{appsmith.theme.colors.primaryColor}}",
|
|
"isVisibleFilters": true,
|
|
"isVisible": true,
|
|
"enableClientSideSearch": true,
|
|
"version": 2,
|
|
"totalRecordsCount": 0,
|
|
"tags": ["Suggested", "Display"],
|
|
"isLoading": false,
|
|
"childStylesheet": {
|
|
"button": {
|
|
"buttonColor": "{{appsmith.theme.colors.primaryColor}}",
|
|
"borderRadius": "{{appsmith.theme.borderRadius.appBorderRadius}}",
|
|
"boxShadow": "none"
|
|
},
|
|
"menuButton": {
|
|
"menuColor": "{{appsmith.theme.colors.primaryColor}}",
|
|
"borderRadius": "{{appsmith.theme.borderRadius.appBorderRadius}}",
|
|
"boxShadow": "none"
|
|
},
|
|
"iconButton": {
|
|
"buttonColor": "{{appsmith.theme.colors.primaryColor}}",
|
|
"borderRadius": "{{appsmith.theme.borderRadius.appBorderRadius}}",
|
|
"boxShadow": "none"
|
|
},
|
|
"editActions": {
|
|
"saveButtonColor": "{{appsmith.theme.colors.primaryColor}}",
|
|
"saveBorderRadius": "{{appsmith.theme.borderRadius.appBorderRadius}}",
|
|
"discardButtonColor": "{{appsmith.theme.colors.primaryColor}}",
|
|
"discardBorderRadius": "{{appsmith.theme.borderRadius.appBorderRadius}}"
|
|
}
|
|
},
|
|
"borderRadius": "{{appsmith.theme.borderRadius.appBorderRadius}}",
|
|
"columnUpdatedAt": 1704217537092,
|
|
"defaultSelectedRowIndices": [0],
|
|
"mobileBottomRow": 139,
|
|
"widgetName": "Table1",
|
|
"defaultPageSize": 0,
|
|
"columnOrder": [],
|
|
"dynamicPropertyPathList": [],
|
|
"displayName": "Table",
|
|
"bottomRow": 139,
|
|
"columnWidthMap": {},
|
|
"parentRowSpace": 10,
|
|
"hideCard": false,
|
|
"mobileRightColumn": 37,
|
|
"parentColumnSpace": 21.4375,
|
|
"borderWidth": "1",
|
|
"primaryColumns": {},
|
|
"key": "v08fxdj0xy",
|
|
"canFreezeColumn": true,
|
|
"isDeprecated": false,
|
|
"rightColumn": 37,
|
|
"textSize": "0.875rem",
|
|
"widgetId": "bx7fchps66",
|
|
"minWidth": 450,
|
|
"tableData": "",
|
|
"label": "Data",
|
|
"searchKey": "",
|
|
"parentId": "0",
|
|
"renderMode": "CANVAS",
|
|
"mobileTopRow": 111,
|
|
"horizontalAlignment": "LEFT",
|
|
"isVisibleSearch": true,
|
|
"responsiveBehavior": "fill",
|
|
"mobileLeftColumn": 3,
|
|
"isVisiblePagination": true,
|
|
"verticalAlignment": "CENTER"
|
|
}
|
|
]
|
|
}
|
|
}
|