PromucFlow_constructor/app/client/src/widgets
Rahul Barwal ef5a253a92
fix: Improve conditional rendering in ChartWidget (#36806)
## Description
Simplify the conditional rendering logic in the ChartWidget component by
separating the cases for an empty chart and loading state. This improves
readability and maintainability of the code.


Fixes #36213
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Chart"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11288506543>
> Commit: 09b7635c04bbf72b12a6461deafc0789f7a04ea7
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11288506543&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Chart`
> Spec:
> <hr>Fri, 11 Oct 2024 08:17:45 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced the `ChartWidget` component for improved control flow and
readability.
- Introduced a streamlined rendering process for different chart states
(loading, empty, error).
- Added an optional `onDataPointClick` property to the
`ChartWidgetProps` interface.

- **Improvements**
	- Modularized rendering logic for better maintainability.
- Added a comprehensive set of unit tests for the `ChartWidget`
component to ensure consistent rendering behavior across various states.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-10-11 18:10:08 +05:30
..
AudioRecorderWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
AudioWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
BaseInputWidget fix:icon align when datatype is of image (#35992) 2024-09-26 19:48:29 +05:30
BaseWidgetHOC chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
ButtonGroupWidget chore: delete unused code (#36461) 2024-09-23 13:52:00 +03:00
ButtonWidget chore: delete unused code (#36461) 2024-09-23 13:52:00 +03:00
CameraWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
CategorySliderWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
ChartWidget fix: Improve conditional rendering in ChartWidget (#36806) 2024-10-11 18:10:08 +05:30
CheckboxGroupWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
CheckboxWidget chore: enable no-explicit-any rule (#35321) 2024-07-31 18:41:28 +03:00
CircularProgressWidget chore: Move widget deprecation messages from propertyPaneView to individual Widget configurations (#33759) 2024-06-04 11:55:55 +05:30
CodeScannerWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
components chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
ContainerWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
CurrencyInputWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
CustomWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
DatePickerWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
DatePickerWidget2 chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
DividerWidget chore: delete unused code (#36461) 2024-09-23 13:52:00 +03:00
DocumentViewerWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
DropdownWidget chore:delete unused files (#36368) 2024-09-19 16:01:03 +03:00
ExternalWidget chore: delete unused code (#36461) 2024-09-23 13:52:00 +03:00
FilepickerWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
FilePickerWidgetV2 chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
FormButtonWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
FormWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
IconButtonWidget chore: delete unused code (#36461) 2024-09-23 13:52:00 +03:00
IconWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
IframeWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
ImageWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
InputWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
InputWidgetV2 chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
JSONFormWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
ListWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
ListWidgetV2 chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
MapChartWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
MapWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
MenuButtonWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
ModalWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
MultiSelectTreeWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
MultiSelectWidget chore: delete unused code (#36461) 2024-09-23 13:52:00 +03:00
MultiSelectWidgetV2 chore: removed old flags for airgap instances (#36609) 2024-10-07 15:26:25 +05:30
NumberSliderWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
PhoneInputWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
ProgressBarWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
ProgressWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
RadioGroupWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
RangeSliderWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
RateWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
RichTextEditorWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
SelectWidget chore: removed old flags for airgap instances (#36609) 2024-10-07 15:26:25 +05:30
SingleSelectTreeWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
StatboxWidget chore: delete unused code (#36461) 2024-09-23 13:52:00 +03:00
SwitchGroupWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
SwitchWidget chore: delete unused code (#36461) 2024-09-23 13:52:00 +03:00
TableWidget chore:delete unused files (#36368) 2024-09-19 16:01:03 +03:00
TableWidgetV2 feat: Allow filtering of table select column label (#36755) 2024-10-09 09:09:12 +01:00
TabsMigrator chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
TabsWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
TextWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
VideoWidget chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
BaseComponent.tsx
BaseWidget.tsx chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
CanvasWidget.tsx chore: enable no-explicit-any rule (#35321) 2024-07-31 18:41:28 +03:00
ConnectDataOverlay.tsx chore: rename ADS package (#35583) 2024-08-09 17:20:29 +03:00
index.ts feat: init AI chat widget (#36610) 2024-10-03 14:26:18 +03:00
MetaHOC.tsx chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
MetaWidgetContextProvider.tsx chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
Skeleton.tsx
SkeletonWidget.tsx feat: implement dropping building blocks on canvas (#31857) 2024-04-16 09:41:09 +01:00
useDropdown.tsx chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
utils.test.ts feat: code scanner widget default camera (#26083) 2023-08-10 12:18:51 +05:30
utils.ts feat: code scanner widget default camera (#26083) 2023-08-10 12:18:51 +05:30
WidgetUtils.test.ts chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
WidgetUtils.ts chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
withLazyRender.tsx chore: enable no-explicit-any rule (#35321) 2024-07-31 18:41:28 +03:00
withWidgetProps.tsx chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00