c7fc7cf7a9
Related to https://github.com/appsmithorg/appsmith/issues/15538 Need to listen to route change outside editor for that feature. ## Description Made `ROUTE_CHANGE` redux event to be triggered on every route change. Previously it was just for editor route changes. (Not for app viewer, home page etc...) Made sure existing methods called on `NavigationSaga` -> `handleRouteChange` listen only to editor route events, as it was before. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Existing cypress tests should pass, since there are no functional changes. - Manually verified events are triggered ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test Co-authored-by: Hetu Nandu <hetu@appsmith.com> |
||
|---|---|---|
| .. | ||
| cypress | ||
| docker | ||
| generators | ||
| patches | ||
| public | ||
| src | ||
| test | ||
| typings | ||
| .babelrc | ||
| .dockerignore | ||
| .editorconfig | ||
| .eslintrc.json | ||
| .flowconfig | ||
| .gitignore | ||
| .huskyrc | ||
| .lintstagedrc | ||
| .nvmrc | ||
| .prettierignore | ||
| .prettierrc | ||
| .sentryclirc | ||
| build.sh | ||
| craco.build.config.js | ||
| craco.common.config.js | ||
| craco.dev.config.js | ||
| cypress_fat.json | ||
| cypress.env.json | ||
| cypress.json | ||
| Dockerfile | ||
| index.tsx | ||
| jest.config.js | ||
| netlify.toml | ||
| package.json | ||
| postcss.config.js | ||
| README.md | ||
| README.old.md | ||
| start-https.sh | ||
| stats.json | ||
| tailwind.config.js | ||
| tsconfig.json | ||
| tsconfig.path.json | ||
| vercel.json | ||
| yarn.lock | ||
Appsmith Client
This project was bootstrapped with Create React App.
For details on setting up your development machine, please refer to the Setup Guide