Go to file
Abhinav Jha e62a2d8eb6
fix: error in scroll on load feature (#27214)
## Description
- Fixes #27064 
- issue where the scroll on load feature threw an error when failing to
find the container to scroll into
Fixed by organising the code such that `undefined` values don't have
their properties accessed.
In an edge case, the widget's parent container like widget was not
correctly identified, as a result, accessing the `dynamicHeight`
property of the parent container like widget threw an error.

- Fixes #27209 
- issue where the ButtonWidgetV2's dynamic height feature was
incorrectly configured
    Fixed by removing the dynamic height feature from ButtonWidgetV2.


#### Type of change
- Bug fix (non-breaking change which fixes an issue)
## Testing
- As the issue is an edge case scenario, no reliable mechanism to
replicate this has been identified to automate. @Sripriya93
@kamakshibhat-appsmith
#### How Has This Been Tested?
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress

#### Test Plan
#### Issues raised during DP testing
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-09-13 11:59:41 +05:30
.github ci: Cypress Push Slack notification fixes (#27241) 2023-09-13 11:55:31 +05:30
app fix: error in scroll on load feature (#27214) 2023-09-13 11:59:41 +05:30
contributions chore: Move the widget config to widget class (#26073) 2023-09-06 17:45:04 +05:30
deploy chore: disable allowprivilegeescalation in the securitycontext of helm chart (#27041) 2023-09-12 11:18:03 +05:30
scripts Delete scripts/efs_guardian_job.json (#27160) 2023-09-11 16:44:10 +05:30
static Add files via upload 2023-08-11 19:09:51 +05:30
utils/observability chore: Adding Redis metrics and dashboard to observability stack (#24755) 2023-06-27 11:19:09 +05:30
.deepsource.toml
.env.example chore: Move Maps API Key to database (#20771) 2023-07-24 13:33:53 +05:30
.gitignore chore: Include tag information, if any in info.json (#25952) 2023-08-03 16:57:04 +05:30
.imgbotconfig
.nojekyll
app.json fix: Update app.json, Heroku deployment is broken (#19540) 2023-02-17 10:58:35 +05:30
appsmith_events.md
appsmith_templates.md
ci-debug.sh ci: CI optimisation to reduce ci-test run time and modularise docker image building (#21219) 2023-03-10 12:51:32 +05:30
CODE_OF_CONDUCT.md
CODEOWNERS chore: Rename and cleanup of editor components (#26944) 2023-09-12 19:44:02 +05:30
CONTRIBUTING.md docs: Updating contribution guidelines (#18190) 2022-11-23 11:41:40 +05:30
depot.json ci: Fixing the RTS build workflow (#16748) 2022-09-14 14:24:20 +05:30
Dockerfile chore: Place local MongoDB cluster key in /tmp instead of / (#26963) 2023-09-11 12:54:50 +05:30
heroku.yml
IssuesReport.md
LICENSE
README.md Update top contributors 2023-09-13 06:53:01 +05:30
SECURITY.md

Appsmith Logo

Discord GitHub commit activity


Organizations build internal applications such as dashboards, database GUIs, admin panels, approval apps, customer support dashboards, and more to help their teams perform day-to-day operations. Appsmith is an open-source tool that enables the rapid development of these internal apps. Read more on our website.

Appsmith in 100 secs

Installation

There are two ways to start using Appsmith:

  • Signup on Appsmith Cloud.
  • Install Appsmith on your machine. See the installation guides below.
Installation Methods Documentation
Docker Docker (Recommended)
Kubernetes Kubernetes
AWS AWS AMI

For other deployment options, see the Installation Guides documentation.

Development

To build and run Appsmith in your local dev environment, see Setup for local development.

Learning Resources

Need Help?

Contributing

We ❤️ our contributors. We're committed to fostering an open, welcoming, and safe environment in the community.

📕 We expect everyone participating in the community to abide by our Code of Conduct. Please read and follow it.
🤝 If you'd like to contribute, start by reading our Contribution Guide.
👾 Explore some good first issues.

Let's build great software together.

Top Contributors

Nikhil-Nandagopal mohanarpit sharat87 hetunandu trishaanand riodeuno akash-codemonk vicky-primathon nidhi-nair satbir121 Aishwarya-U-R Tooluloope sumitsum AnaghHegde arunvjn NandanAnantharamu abhvsn nayan-rafiq ankitakinger jsartisan Rishabh-Rathod Irongade ohansFavour sbalaji1192 aswathkk sarojsarab SatishGandham rahulramesha prsidhu yatinappsmith AmanAgarwal041 ApekshaBhosale somangshu pranavkanade ayushpahwa Parthvi12 sneha122 pratapaprasanna Vijetha-Kaja albinAppsmith marks0351 berzerkeer sum35h keyurparalkar ChandanBalajiBP ashit-rath rajatagrawal areyabhishek dhruvikn sondermanish nsarupr NilanshBansal KelvinOm Druthi tanvibhakta ichik megaconfidence subrata71 vsvamsi1 ankitsrivas14 rahulbarwal dipyamanbiswas07 sharanya-appsmith tkAppsmith brayn003 rohitagarwal88 ramsaptami gitstart-appsmith rohan-arthur shubham7saxena7 danciaclara dvj1988 vivonk kocharrahul7 abm17 jacquesikot RakshaKShetty Rishabhkaul sandeepravi tejasahluwalia dilippitchika nerbos riteshkew srix rlnorthcutt kevinblanco AbhaySM tomjose92 andreevanatasha LagunaElectric sw4ti493 ginilpg sribalajig infinitetrooper RoopKrrish9696 bharath31 GreenFlux z-l-t Debsourabh shadabbuchh harshilp24 narhzih appsmith-bot shastry-gg AnandiKulkarni momcilo-appsmith shwetha-ramesh vasanthappsmith parth-appsmith chandannkumar jnikhila vinay-appsmith ame-appsmith btsgh Sripriya93 theparthacus laveena-en pranayagarwal96 kamakshibhat-appsmith felix-appsmith sujdev7 BharghaviK carinanfonseca deepikaappsmith prapullc Harshask93 cssonic kavitasmoolya NeelPattani1 rashmi-sahoo-git rishabhsaxena wmdev0808 techbhavin yaldram sidhantgoel haojin111 devrk96 eco-monk vibhandikyash ofpiyush vishnu-gp rimildeyjsr rashmigowda55 ankurrsinghal geekup-legodevops vihar danieldare Nikhil-Curefit souma-ghosh arslanhaiderbuttar rashmi-rai leotom2000 ravikp7 Adityaacharya1807 RashmiNagarajp prapullac kaushik94 PiyushPushkar02 akshayrangasaid mojtab23 iamakulov iamrkcheers sumanthyedoti vaibh1297 vnodecg pc9795 Rhitottam Pranay105 iSatVeerSingh akshay11298 daniel-shuy daniloff200 osis harshitpandey0426 ganganimaulik jyash97 ram-primathon sub1983 sanjus-robotic-studio AR10X shreemaan-abhishek A-Scratchy manish535 shinnlok suhasranganath ThakurKarthik trdillon acharyaaditya18 amogh2019 appsmithguru pric-appsmith sunil-codemonk abhiappsmith ajinkyakulkarni Cool-Runningz akbansa ArjobanSingh bharat-patodi Bhavin789 bhuvanaindukuri donno2048 jacobwgillespie reachtokish nuwan94 OmkarPh parthiv11 priyanka-mahour rafaeelaudibert samyakjain10 Jain-Sanchit irfan-ansari-au28 sheetal2001p Hard-Coder05 vj-codes knockknockyoo jdun28 alphaX86 aanchal-fatwani monarch0111 abhishekS14 adarshlilha avats-dev visibleajay blenderskool AlekSi alzaar heroic AJ-72 apoorv-mishra anvaravind ari-hacks arunstar ashwanisindhu1 ayushkumarbhadani Caitlin-Fotheringham Chiradeep-Banik chrismaeda CommanderRoot DevSnap DiptoChakrabarty felixsuarez0727 gitstart harshmange44 indrajitbnikam ishaanmehta4 jaikanthjay46 jarimayenburg JarLob JeffResc jmakhack jlund jrcamelo khoahuynhdev kylegalbraith loiscodes jk2K micarner me-heer MuhammadAakash Hammad9219 moulik-deepsource Nandanha wasabigeek nipun1999 nishihere19 Nitesh2905 eagleera NoxiousPenguin palashkaria pallavagarwal07 paususe neok sanchezpili6 pushkar1393 imor ricardocarrola RishiKumarRay Rooney30 Saket2 Sheikh-JamirAlam withshubh smrutiparida somnathdasadhikari srijanshetty Sufiyan1997 rayrny trishitapingolia webdott vasanthkumar18 VanshajPoonia vedant-pandey vvkpd Yash-Bhange YogeshJayaseelan Ian-Yy devnamrits deepakchethan IAmAnubhavSaini gokuatkai Jackenmen Mrxyy zimkjh kyteinsky lifeneedspassion nikhil-babar nupur-singhal1992 nzidol onifs10 ps-xaf

License

Appsmith is licensed under the terms of Apache License 2.0.