PromucFlow_constructor/app/client/src/pages/common
Hetu Nandu 3e8ff46716
fix: Cannot navigate out of an error page (#22021)
## Description

When an error occurs, we take over the whole router and keep it the
error state till the errors are flushed. By default, we will flush out
the error state when a CTA on the page is clicked but in case the user
navigates via the browser buttons, this will ensure the errors are
flushed

> Clear out errors when using browser navigation buttons to avoid error
page persistence

Fixes #18564
Fixes #22068

Media


https://user-images.githubusercontent.com/12022471/229461625-d4bfc72f-c551-4063-aad8-8ba8b97f2db5.mov


## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual


### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-06 11:50:35 +05:30
..
CanvasArenas chore: Code splitting FE files to support app level invites on Business edition (#21783) 2023-03-29 17:07:06 +00:00
CustomizedDropdown chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
datasourceAuth feat: Added file id mapping in datasource config (#21699) 2023-04-04 13:43:49 +05:30
ErrorPages fix: Cannot navigate out of an error page (#22021) 2023-04-06 11:50:35 +05:30
AppHeader.tsx feat: Improved App Navigation (#19312) 2023-03-23 17:11:58 +05:30
ArtBoard.tsx fix: layout control not working (#7502) 2021-09-17 11:07:09 +05:30
ErrorPage.tsx Use generic error page by default 2023-03-30 16:50:26 +05:30
ErrorPageHeader.tsx feat: Improved App Navigation (#19312) 2023-03-23 17:11:58 +05:30
Loader.tsx Development: Add eslint rules for code consistency (#4083) 2021-04-28 15:58:39 +05:30
LoginHeader.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
MobileSidebar.tsx feat: Renamed design system package (#19854) 2023-01-23 09:20:47 +05:30
NotFound.tsx - Auto fix sort ddestructured props rule 2021-05-13 14:05:39 +05:30
PageHeader.tsx feat: Improved App Navigation (#19312) 2023-03-23 17:11:58 +05:30
PageLoadingBar.tsx Development: Add eslint rules for code consistency (#4083) 2021-04-28 15:58:39 +05:30
PageSectionDivider.tsx Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
PageSectionHeader.tsx Add favicon. Connect Nav Dropdown. Fix TagInputComponent. Fetch org and user details. Navigate to applications from /, Check for login 2019-12-23 12:16:33 +00:00
PaneCountSwitcher.tsx feat: Multi Pane IDE: Phase 1 (#19261) 2023-01-09 10:54:41 +05:30
PaneWrapper.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
ProfileDropdown.tsx feat: Improved App Navigation (#19312) 2023-03-23 17:11:58 +05:30
ProfileImage.tsx feat: Renamed design system package (#19854) 2023-01-23 09:20:47 +05:30
SharedUserList.tsx chore: Code splitting FE files to support app level invites on Business edition (#21783) 2023-03-29 17:07:06 +00:00
SideNav.tsx feat: Multi Pane IDE: Phase 1 (#19261) 2023-01-09 10:54:41 +05:30
SpinnerLoader.tsx feat: git sync - add error, progress states to connect and merge tabs (#9007) 2021-11-09 15:21:18 +05:30
SubHeader.tsx chore: Code splitting FE files to support app level invites on Business edition (#21783) 2023-03-29 17:07:06 +00:00
SuccessTick.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
ThemeSwitcher.tsx feat: Renamed design system package (#19854) 2023-01-23 09:20:47 +05:30