## Description - Added support for multiple highlights in walkthrough - Corrected walkthrough events for each feature walkthrough - Added fix for the walkthrough dismissal in case of empty/no schema feature #### PR fixes following issue(s) Fixes #25417 Fixes #25416 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>
61 lines
1.8 KiB
TypeScript
61 lines
1.8 KiB
TypeScript
import React from "react";
|
|
|
|
export type PositionType = "top" | "bottom" | "left" | "right";
|
|
|
|
export const DEFAULT_DELAY = 0;
|
|
|
|
export type OffsetType = {
|
|
// Position for the instructions and indicator
|
|
position?: PositionType;
|
|
// Adds an offset to top or bottom properties (of Instruction div) depending upon the position
|
|
top?: number;
|
|
// Adds an offset to left or right properties (of Instruction div) depending upon the position
|
|
left?: number;
|
|
// Style for the Instruction div overrides all other styles
|
|
style?: any;
|
|
// Indicator top and left offsets
|
|
indicatorTop?: number;
|
|
indicatorLeft?: number;
|
|
// container offset for highlight
|
|
highlightPad?: number;
|
|
};
|
|
|
|
export type FeatureDetails = {
|
|
// Title to show on the instruction screen
|
|
title: string;
|
|
// Description to show on the instruction screen
|
|
description: string;
|
|
// Gif or Image to give a walkthrough
|
|
imageURL?: string;
|
|
};
|
|
|
|
export type FeatureParams = {
|
|
// To execute a function on dismissing the tutorial walkthrough.
|
|
onDismiss?: () => void;
|
|
// Target Id without # to highlight the feature
|
|
targetId: string;
|
|
// Details for the instruction screen
|
|
details?: FeatureDetails;
|
|
// Offsets for the instruction screen and the indicator
|
|
offset?: OffsetType;
|
|
// Event params
|
|
eventParams?: Record<string, any>;
|
|
// Walkthrough delay in ms
|
|
delay?: number;
|
|
// Multiple Highlights -> multiple ids for highlighter, if not present considers targetId as the only highlighting div.
|
|
multipleHighlights?: string[];
|
|
};
|
|
|
|
type WalkthroughContextType = {
|
|
pushFeature: (feature: FeatureParams) => void;
|
|
popFeature: (triggeredFrom?: string) => void;
|
|
feature: FeatureParams[];
|
|
isOpened: boolean;
|
|
};
|
|
|
|
const WalkthroughContext = React.createContext<
|
|
WalkthroughContextType | undefined
|
|
>(undefined);
|
|
|
|
export default WalkthroughContext;
|