## Description This PR includes Changes for Drag and drop Improvements, That includes, - Resizing dragging widgets along Container edges. - Initially resize widgets against Container/Droptarget widgets. - While holding close to Container/Droptarget widgets for half a second, start to reflow the widget. Fixes #19139 Fixes #12892 Media https://user-images.githubusercontent.com/71900764/209154834-66acecbb-2df8-4598-86d5-4fe7843dd21b.mp4 ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test
103 lines
2.9 KiB
TypeScript
103 lines
2.9 KiB
TypeScript
import { WidgetProps, WidgetRowCols } from "widgets/BaseWidget";
|
|
import { GridDefaults } from "constants/WidgetConstants";
|
|
import { XYCord } from "pages/common/CanvasArenas/hooks/useRenderBlocksOnCanvas";
|
|
import { ReflowDirection } from "reflow/reflowTypes";
|
|
|
|
export type UIElementSize = { height: number; width: number };
|
|
|
|
export const RESIZABLE_CONTAINER_BORDER_THEME_INDEX = 1;
|
|
|
|
export type WidgetPosition = {
|
|
rightColumn: number;
|
|
leftColumn: number;
|
|
bottomRow: number;
|
|
topRow: number;
|
|
parentRowSpace: number;
|
|
parentColumnSpace: number;
|
|
};
|
|
|
|
export type WidgetExtendedPosition = WidgetPosition & {
|
|
paddingOffset: number;
|
|
};
|
|
|
|
export const computeRowCols = (
|
|
delta: UIElementSize,
|
|
position: XYCord,
|
|
props: WidgetPosition,
|
|
) => {
|
|
return {
|
|
leftColumn: Math.round(
|
|
props.leftColumn + position.x / props.parentColumnSpace,
|
|
),
|
|
topRow: Math.round(props.topRow + position.y / props.parentRowSpace),
|
|
rightColumn: Math.round(
|
|
props.rightColumn + (delta.width + position.x) / props.parentColumnSpace,
|
|
),
|
|
bottomRow: Math.round(
|
|
props.bottomRow + (delta.height + position.y) / props.parentRowSpace,
|
|
),
|
|
};
|
|
};
|
|
|
|
export const computeBoundedRowCols = (rowCols: WidgetRowCols) => {
|
|
return {
|
|
leftColumn: Math.max(rowCols.leftColumn, 0),
|
|
rightColumn: Math.min(
|
|
rowCols.rightColumn,
|
|
GridDefaults.DEFAULT_GRID_COLUMNS,
|
|
),
|
|
topRow: rowCols.topRow,
|
|
bottomRow: rowCols.bottomRow,
|
|
};
|
|
};
|
|
|
|
export const hasRowColsChanged = (
|
|
newRowCols: WidgetRowCols,
|
|
props: WidgetProps,
|
|
) => {
|
|
return (
|
|
props.leftColumn !== newRowCols.leftColumn ||
|
|
props.topRow !== newRowCols.topRow ||
|
|
props.bottomRow !== newRowCols.bottomRow ||
|
|
props.rightColumn !== newRowCols.rightColumn
|
|
);
|
|
};
|
|
|
|
export const computeFinalRowCols = (
|
|
delta: UIElementSize,
|
|
position: XYCord,
|
|
props: WidgetProps,
|
|
): WidgetRowCols | false => {
|
|
const newRowCols = computeBoundedRowCols(
|
|
computeRowCols(delta, position, props),
|
|
);
|
|
|
|
return hasRowColsChanged(newRowCols, props) ? newRowCols : false;
|
|
};
|
|
|
|
/**
|
|
* A rudimentary function which based on horizontal and vertical resize enabled
|
|
* tells us whether a resize handle in a particular direction works
|
|
* Note: This works only if vertical or horizontal directions are provided.
|
|
* @param horizontalEnabled : boolean
|
|
* @param verticalEnabled : boolean
|
|
* @param direction : ReflowDirection
|
|
* @returns if resize is allowed in the direction provided
|
|
* Works only for vertical and horizontal directions
|
|
*/
|
|
export function isHandleResizeAllowed(
|
|
horizontalEnabled: boolean,
|
|
verticalEnabled: boolean,
|
|
direction?: ReflowDirection,
|
|
): boolean {
|
|
if (direction === ReflowDirection.TOP || direction === ReflowDirection.BOTTOM)
|
|
return verticalEnabled;
|
|
else if (
|
|
direction === ReflowDirection.LEFT ||
|
|
direction === ReflowDirection.RIGHT
|
|
) {
|
|
return horizontalEnabled;
|
|
}
|
|
return true;
|
|
}
|