## Description This PR removes the error logs added to debug CI issue #### PR fixes following issue(s) Fixes #28319 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed Co-authored-by: “sneha122” <“sneha@appsmith.com”>
272 lines
8.7 KiB
TypeScript
272 lines
8.7 KiB
TypeScript
import { all, takeEvery, call, put, select } from "redux-saga/effects";
|
|
import type { ReduxAction } from "@appsmith/constants/ReduxActionConstants";
|
|
import {
|
|
ReduxActionTypes,
|
|
ReduxActionErrorTypes,
|
|
} from "@appsmith/constants/ReduxActionConstants";
|
|
import type { DefaultPlugin, PluginFormPayload } from "api/PluginApi";
|
|
import PluginsApi from "api/PluginApi";
|
|
import { validateResponse } from "sagas/ErrorSagas";
|
|
import { getCurrentWorkspaceId } from "@appsmith/selectors/workspaceSelectors";
|
|
import {
|
|
getActions,
|
|
getDatasources,
|
|
getPlugin,
|
|
getPluginForm,
|
|
getPlugins,
|
|
} from "@appsmith/selectors/entitiesSelector";
|
|
import type { Datasource } from "entities/Datasource";
|
|
import type { Plugin } from "api/PluginApi";
|
|
import {
|
|
fetchPluginFormConfigsSuccess,
|
|
fetchPluginFormConfigSuccess,
|
|
fetchPluginFormConfigError,
|
|
} from "actions/pluginActions";
|
|
import {
|
|
defaultActionDependenciesConfig,
|
|
defaultActionEditorConfigs,
|
|
defaultActionSettings,
|
|
defaultDatasourceFormButtonConfig,
|
|
} from "constants/AppsmithActionConstants/ActionConstants";
|
|
import type { ApiResponse } from "api/ApiResponses";
|
|
import PluginApi from "api/PluginApi";
|
|
import log from "loglevel";
|
|
import { getGraphQLPlugin, PluginType } from "entities/Action";
|
|
import type {
|
|
FormEditorConfigs,
|
|
FormSettingsConfigs,
|
|
FormDependencyConfigs,
|
|
FormDatasourceButtonConfigs,
|
|
} from "utils/DynamicBindingUtils";
|
|
import type { ActionDataState } from "@appsmith/reducers/entityReducers/actionsReducer";
|
|
|
|
function* fetchPluginsSaga(
|
|
action: ReduxAction<{ workspaceId?: string } | undefined>,
|
|
) {
|
|
try {
|
|
let workspaceId: string = yield select(getCurrentWorkspaceId);
|
|
if (action.payload?.workspaceId) workspaceId = action.payload?.workspaceId;
|
|
|
|
if (!workspaceId) {
|
|
throw Error("Workspace id does not exist");
|
|
}
|
|
const pluginsResponse: ApiResponse<Plugin[]> = yield call(
|
|
PluginsApi.fetchPlugins,
|
|
workspaceId,
|
|
);
|
|
const isValid: boolean = yield validateResponse(pluginsResponse);
|
|
if (isValid) {
|
|
yield put({
|
|
type: ReduxActionTypes.FETCH_PLUGINS_SUCCESS,
|
|
payload: pluginsResponse.data,
|
|
});
|
|
}
|
|
} catch (error) {
|
|
yield put({
|
|
type: ReduxActionErrorTypes.FETCH_PLUGINS_ERROR,
|
|
payload: { error },
|
|
});
|
|
}
|
|
}
|
|
|
|
function* fetchPluginFormConfigsSaga() {
|
|
try {
|
|
const datasources: Datasource[] = yield select(getDatasources);
|
|
const plugins: Plugin[] = yield select(getPlugins);
|
|
// Add plugins of all the datasources of their workspace
|
|
const pluginIdFormsToFetch = new Set(
|
|
datasources.map((datasource) => datasource.pluginId),
|
|
);
|
|
// Add the api plugin id by default as API, JS, Graphql can exists without datasource
|
|
const apiPlugin = plugins.find((plugin) => plugin.type === PluginType.API);
|
|
const jsPlugin = plugins.find((plugin) => plugin.type === PluginType.JS);
|
|
const graphqlPlugin = getGraphQLPlugin(plugins);
|
|
if (apiPlugin) {
|
|
pluginIdFormsToFetch.add(apiPlugin.id);
|
|
}
|
|
|
|
if (graphqlPlugin) {
|
|
pluginIdFormsToFetch.add(graphqlPlugin.id);
|
|
}
|
|
|
|
const actions: ActionDataState = yield select(getActions);
|
|
const actionPluginIds = actions.map((action) => action.config.pluginId);
|
|
for (const pluginId of actionPluginIds) {
|
|
pluginIdFormsToFetch.add(pluginId);
|
|
}
|
|
|
|
const pluginFormData: PluginFormPayload[] = [];
|
|
const pluginFormResponses: ApiResponse<PluginFormPayload>[] = yield all(
|
|
[...pluginIdFormsToFetch].map((id) =>
|
|
call(PluginsApi.fetchFormConfig, id),
|
|
),
|
|
);
|
|
|
|
for (let i = 0; i < pluginFormResponses.length; i++) {
|
|
const response = pluginFormResponses[i];
|
|
yield validateResponse(response);
|
|
pluginFormData.push(response.data);
|
|
}
|
|
|
|
if (jsPlugin) {
|
|
pluginIdFormsToFetch.add(jsPlugin.id);
|
|
}
|
|
const formConfigs: Record<string, any[]> = {};
|
|
const editorConfigs: FormEditorConfigs = {};
|
|
const settingConfigs: FormSettingsConfigs = {};
|
|
const dependencies: FormDependencyConfigs = {};
|
|
const datasourceFormButtonConfigs: FormDatasourceButtonConfigs = {};
|
|
|
|
Array.from(pluginIdFormsToFetch).forEach((pluginId, index) => {
|
|
const plugin = plugins.find((plugin) => plugin.id === pluginId);
|
|
if (plugin && plugin.type === PluginType.JS) {
|
|
settingConfigs[pluginId] = defaultActionSettings[plugin.type];
|
|
editorConfigs[pluginId] = defaultActionEditorConfigs[plugin.type];
|
|
formConfigs[pluginId] = [];
|
|
dependencies[pluginId] = defaultActionDependenciesConfig[plugin.type];
|
|
} else {
|
|
// Datasource form always use server's copy
|
|
if (!!pluginFormData[index]) {
|
|
formConfigs[pluginId] = pluginFormData[index].form;
|
|
// Action editor form if not available use default
|
|
if (plugin && !pluginFormData[index].editor) {
|
|
editorConfigs[pluginId] = defaultActionEditorConfigs[plugin.type];
|
|
} else {
|
|
editorConfigs[pluginId] = pluginFormData[index].editor;
|
|
}
|
|
// Action settings form if not available use default
|
|
if (plugin && !pluginFormData[index].setting) {
|
|
settingConfigs[pluginId] = defaultActionSettings[plugin.type];
|
|
} else {
|
|
settingConfigs[pluginId] = pluginFormData[index].setting;
|
|
}
|
|
// Action dependencies config if not available use default
|
|
if (plugin && !pluginFormData[index].dependencies) {
|
|
dependencies[pluginId] =
|
|
defaultActionDependenciesConfig[plugin.type];
|
|
} else {
|
|
dependencies[pluginId] = pluginFormData[index].dependencies;
|
|
}
|
|
// Datasource form buttons config if not available use default
|
|
if (plugin && !pluginFormData[index].formButton) {
|
|
datasourceFormButtonConfigs[pluginId] =
|
|
defaultDatasourceFormButtonConfig[plugin.type];
|
|
} else {
|
|
datasourceFormButtonConfigs[pluginId] =
|
|
pluginFormData[index].formButton;
|
|
}
|
|
}
|
|
}
|
|
});
|
|
|
|
yield put(
|
|
fetchPluginFormConfigsSuccess({
|
|
formConfigs,
|
|
editorConfigs,
|
|
settingConfigs,
|
|
dependencies,
|
|
datasourceFormButtonConfigs,
|
|
}),
|
|
);
|
|
} catch (error) {
|
|
yield put({
|
|
type: ReduxActionErrorTypes.FETCH_PLUGIN_FORM_CONFIGS_ERROR,
|
|
payload: { error },
|
|
});
|
|
}
|
|
}
|
|
|
|
export function* checkAndGetPluginFormConfigsSaga(pluginId: string) {
|
|
try {
|
|
const plugin: Plugin = yield select(getPlugin, pluginId);
|
|
const formConfig: Record<string, unknown> = yield select(
|
|
getPluginForm,
|
|
pluginId,
|
|
);
|
|
if (!formConfig) {
|
|
const formConfigResponse: ApiResponse<PluginFormPayload> =
|
|
yield PluginApi.fetchFormConfig(pluginId);
|
|
yield validateResponse(formConfigResponse);
|
|
if (!formConfigResponse.data.setting) {
|
|
formConfigResponse.data.setting = defaultActionSettings[plugin.type];
|
|
}
|
|
if (!formConfigResponse.data.editor) {
|
|
formConfigResponse.data.editor =
|
|
defaultActionEditorConfigs[plugin.type];
|
|
}
|
|
if (!formConfigResponse.data.dependencies) {
|
|
formConfigResponse.data.dependencies =
|
|
defaultActionDependenciesConfig[plugin.type];
|
|
}
|
|
if (!formConfigResponse.data.formButton) {
|
|
formConfigResponse.data.formButton =
|
|
defaultDatasourceFormButtonConfig[plugin.type];
|
|
}
|
|
yield put(
|
|
fetchPluginFormConfigSuccess({
|
|
id: pluginId,
|
|
...formConfigResponse.data,
|
|
}),
|
|
);
|
|
}
|
|
} catch (e) {
|
|
log.error("Failed to get plugin form");
|
|
yield put(
|
|
fetchPluginFormConfigError({
|
|
id: pluginId,
|
|
}),
|
|
);
|
|
}
|
|
}
|
|
|
|
interface GetPluginFormConfigParams {
|
|
id: string;
|
|
type: string;
|
|
}
|
|
|
|
function* getPluginFormConfig({ id }: GetPluginFormConfigParams) {
|
|
yield call(checkAndGetPluginFormConfigsSaga, id);
|
|
}
|
|
|
|
function* getDefaultPluginsSaga() {
|
|
try {
|
|
const response: ApiResponse<DefaultPlugin> = yield call(
|
|
PluginsApi.fetchDefaultPlugins,
|
|
);
|
|
const isValid: boolean = yield validateResponse(response);
|
|
if (isValid) {
|
|
yield put({
|
|
type: ReduxActionTypes.GET_DEFAULT_PLUGINS_SUCCESS,
|
|
payload: response.data,
|
|
});
|
|
}
|
|
} catch (error) {
|
|
yield put({
|
|
type: ReduxActionErrorTypes.GET_DEFAULT_PLUGINS_ERROR,
|
|
payload: {
|
|
error,
|
|
},
|
|
});
|
|
}
|
|
}
|
|
|
|
function* root() {
|
|
yield all([
|
|
takeEvery(ReduxActionTypes.FETCH_PLUGINS_REQUEST, fetchPluginsSaga),
|
|
takeEvery(
|
|
ReduxActionTypes.FETCH_PLUGIN_FORM_CONFIGS_REQUEST,
|
|
fetchPluginFormConfigsSaga,
|
|
),
|
|
takeEvery(
|
|
ReduxActionTypes.GET_PLUGIN_FORM_CONFIG_INIT,
|
|
getPluginFormConfig,
|
|
),
|
|
takeEvery(
|
|
ReduxActionTypes.GET_DEFAULT_PLUGINS_REQUEST,
|
|
getDefaultPluginsSaga,
|
|
),
|
|
]);
|
|
}
|
|
|
|
export default root;
|