PromucFlow_constructor/app/client/src/sagas/PluginSagas.ts
Ivan Akulov 424d2f6965
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description

This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.

As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes

This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)

### Why is this needed?

This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.

However, just using `import type` in the current codebase will give you
this:

<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">

That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.

### Why enforce `import type`?

Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)

I’m doing this because I believe `import type` improves DX and makes
refactorings easier.

Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)

```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

It’s pretty hard, right?

What about now?

```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

Now, it’s clear that only `lodash` will be bundled.

This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.

This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.

## Type of change

- Chore (housekeeping or task changes that don't impact user perception)


## How Has This Been Tested?

This was tested to not break the build.

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 17:11:47 +05:30

264 lines
8.5 KiB
TypeScript

import { all, takeEvery, call, put, select } from "redux-saga/effects";
import type { ReduxAction } from "@appsmith/constants/ReduxActionConstants";
import {
ReduxActionTypes,
ReduxActionErrorTypes,
} from "@appsmith/constants/ReduxActionConstants";
import type { DefaultPlugin, PluginFormPayload } from "api/PluginApi";
import PluginsApi from "api/PluginApi";
import { validateResponse } from "sagas/ErrorSagas";
import { getCurrentWorkspaceId } from "@appsmith/selectors/workspaceSelectors";
import {
getActions,
getDatasources,
getPlugin,
getPluginForm,
getPlugins,
} from "selectors/entitiesSelector";
import type { Datasource } from "entities/Datasource";
import type { Plugin } from "api/PluginApi";
import {
fetchPluginFormConfigsSuccess,
fetchPluginFormConfigSuccess,
fetchPluginFormConfigError,
} from "actions/pluginActions";
import {
defaultActionDependenciesConfig,
defaultActionEditorConfigs,
defaultActionSettings,
defaultDatasourceFormButtonConfig,
} from "constants/AppsmithActionConstants/ActionConstants";
import type { ApiResponse } from "api/ApiResponses";
import PluginApi from "api/PluginApi";
import log from "loglevel";
import { getGraphQLPlugin, PluginType } from "entities/Action";
import type {
FormEditorConfigs,
FormSettingsConfigs,
FormDependencyConfigs,
FormDatasourceButtonConfigs,
} from "utils/DynamicBindingUtils";
import type { ActionDataState } from "reducers/entityReducers/actionsReducer";
function* fetchPluginsSaga(
action: ReduxAction<{ workspaceId?: string } | undefined>,
) {
try {
let workspaceId: string = yield select(getCurrentWorkspaceId);
if (action.payload?.workspaceId) workspaceId = action.payload?.workspaceId;
if (!workspaceId) {
throw Error("Workspace id does not exist");
}
const pluginsResponse: ApiResponse<Plugin[]> = yield call(
PluginsApi.fetchPlugins,
workspaceId,
);
const isValid: boolean = yield validateResponse(pluginsResponse);
if (isValid) {
yield put({
type: ReduxActionTypes.FETCH_PLUGINS_SUCCESS,
payload: pluginsResponse.data,
});
}
} catch (error) {
yield put({
type: ReduxActionErrorTypes.FETCH_PLUGINS_ERROR,
payload: { error },
});
}
}
function* fetchPluginFormConfigsSaga() {
try {
const datasources: Datasource[] = yield select(getDatasources);
const plugins: Plugin[] = yield select(getPlugins);
// Add plugins of all the datasources of their workspace
const pluginIdFormsToFetch = new Set(
datasources.map((datasource) => datasource.pluginId),
);
// Add the api plugin id by default as API, JS, Graphql can exists without datasource
const apiPlugin = plugins.find((plugin) => plugin.type === PluginType.API);
const jsPlugin = plugins.find((plugin) => plugin.type === PluginType.JS);
const graphqlPlugin = getGraphQLPlugin(plugins);
if (apiPlugin) {
pluginIdFormsToFetch.add(apiPlugin.id);
}
if (graphqlPlugin) {
pluginIdFormsToFetch.add(graphqlPlugin.id);
}
const actions: ActionDataState = yield select(getActions);
const actionPluginIds = actions.map((action) => action.config.pluginId);
for (const pluginId of actionPluginIds) {
pluginIdFormsToFetch.add(pluginId);
}
const pluginFormData: PluginFormPayload[] = [];
const pluginFormResponses: ApiResponse<PluginFormPayload>[] = yield all(
[...pluginIdFormsToFetch].map((id) =>
call(PluginsApi.fetchFormConfig, id),
),
);
for (const response of pluginFormResponses) {
yield validateResponse(response);
pluginFormData.push(response.data);
}
if (jsPlugin) {
pluginIdFormsToFetch.add(jsPlugin.id);
}
const formConfigs: Record<string, any[]> = {};
const editorConfigs: FormEditorConfigs = {};
const settingConfigs: FormSettingsConfigs = {};
const dependencies: FormDependencyConfigs = {};
const datasourceFormButtonConfigs: FormDatasourceButtonConfigs = {};
Array.from(pluginIdFormsToFetch).forEach((pluginId, index) => {
const plugin = plugins.find((plugin) => plugin.id === pluginId);
if (plugin && plugin.type === PluginType.JS) {
settingConfigs[pluginId] = defaultActionSettings[plugin.type];
editorConfigs[pluginId] = defaultActionEditorConfigs[plugin.type];
formConfigs[pluginId] = [];
dependencies[pluginId] = defaultActionDependenciesConfig[plugin.type];
} else {
// Datasource form always use server's copy
formConfigs[pluginId] = pluginFormData[index].form;
// Action editor form if not available use default
if (plugin && !pluginFormData[index].editor) {
editorConfigs[pluginId] = defaultActionEditorConfigs[plugin.type];
} else {
editorConfigs[pluginId] = pluginFormData[index].editor;
}
// Action settings form if not available use default
if (plugin && !pluginFormData[index].setting) {
settingConfigs[pluginId] = defaultActionSettings[plugin.type];
} else {
settingConfigs[pluginId] = pluginFormData[index].setting;
}
// Action dependencies config if not available use default
if (plugin && !pluginFormData[index].dependencies) {
dependencies[pluginId] = defaultActionDependenciesConfig[plugin.type];
} else {
dependencies[pluginId] = pluginFormData[index].dependencies;
}
// Datasource form buttons config if not available use default
if (plugin && !pluginFormData[index].formButton) {
datasourceFormButtonConfigs[pluginId] =
defaultDatasourceFormButtonConfig[plugin.type];
} else {
datasourceFormButtonConfigs[pluginId] =
pluginFormData[index].formButton;
}
}
});
yield put(
fetchPluginFormConfigsSuccess({
formConfigs,
editorConfigs,
settingConfigs,
dependencies,
datasourceFormButtonConfigs,
}),
);
} catch (error) {
log.error(error);
yield put({
type: ReduxActionErrorTypes.FETCH_PLUGIN_FORM_CONFIGS_ERROR,
payload: { error },
});
}
}
export function* checkAndGetPluginFormConfigsSaga(pluginId: string) {
try {
const plugin: Plugin = yield select(getPlugin, pluginId);
const formConfig: Record<string, unknown> = yield select(
getPluginForm,
pluginId,
);
if (!formConfig) {
const formConfigResponse: ApiResponse<PluginFormPayload> =
yield PluginApi.fetchFormConfig(pluginId);
yield validateResponse(formConfigResponse);
if (!formConfigResponse.data.setting) {
formConfigResponse.data.setting = defaultActionSettings[plugin.type];
}
if (!formConfigResponse.data.editor) {
formConfigResponse.data.editor =
defaultActionEditorConfigs[plugin.type];
}
if (!formConfigResponse.data.dependencies) {
formConfigResponse.data.dependencies =
defaultActionDependenciesConfig[plugin.type];
}
if (!formConfigResponse.data.formButton) {
formConfigResponse.data.formButton =
defaultDatasourceFormButtonConfig[plugin.type];
}
yield put(
fetchPluginFormConfigSuccess({
id: pluginId,
...formConfigResponse.data,
}),
);
}
} catch (e) {
log.error("Failed to get plugin form");
yield put(
fetchPluginFormConfigError({
id: pluginId,
}),
);
}
}
type GetPluginFormConfigParams = { id: string; type: string };
function* getPluginFormConfig({ id }: GetPluginFormConfigParams) {
yield call(checkAndGetPluginFormConfigsSaga, id);
}
function* getDefaultPluginsSaga() {
try {
const response: ApiResponse<DefaultPlugin> = yield call(
PluginsApi.fetchDefaultPlugins,
);
const isValid: boolean = yield validateResponse(response);
if (isValid) {
yield put({
type: ReduxActionTypes.GET_DEFAULT_PLUGINS_SUCCESS,
payload: response.data,
});
}
} catch (error) {
yield put({
type: ReduxActionErrorTypes.GET_DEFAULT_PLUGINS_ERROR,
payload: {
error,
},
});
}
}
function* root() {
yield all([
takeEvery(ReduxActionTypes.FETCH_PLUGINS_REQUEST, fetchPluginsSaga),
takeEvery(
ReduxActionTypes.FETCH_PLUGIN_FORM_CONFIGS_REQUEST,
fetchPluginFormConfigsSaga,
),
takeEvery(
ReduxActionTypes.GET_PLUGIN_FORM_CONFIG_INIT,
getPluginFormConfig,
),
takeEvery(
ReduxActionTypes.GET_DEFAULT_PLUGINS_REQUEST,
getDefaultPluginsSaga,
),
]);
}
export default root;