PromucFlow_constructor/app/client/src/utils/WidgetFactoryHelpers.ts
Ivan Akulov 424d2f6965
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
## Description

This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.

As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes

This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)

### Why is this needed?

This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.

However, just using `import type` in the current codebase will give you
this:

<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">

That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.

### Why enforce `import type`?

Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)

I’m doing this because I believe `import type` improves DX and makes
refactorings easier.

Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)

```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

It’s pretty hard, right?

What about now?

```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

Now, it’s clear that only `lodash` will be bundled.

This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.

This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.

## Type of change

- Chore (housekeeping or task changes that don't impact user perception)


## How Has This Been Tested?

This was tested to not break the build.

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 17:11:47 +05:30

285 lines
8.5 KiB
TypeScript

import type {
PropertyPaneConfig,
PropertyPaneControlConfig,
PropertyPaneSectionConfig,
} from "constants/PropertyControlConstants";
import { ValidationTypes } from "constants/WidgetValidation";
import { memoize } from "lodash";
import log from "loglevel";
import { generateReactKey } from "./generators";
import type { WidgetType } from "./WidgetFactory";
import WidgetFactory from "./WidgetFactory";
import type {
RegisteredWidgetFeatures,
WidgetFeatures,
} from "./WidgetFeatures";
import {
PropertyPaneConfigTemplates,
WidgetFeaturePropertyPaneEnhancements,
} from "./WidgetFeatures";
export enum PropertyPaneConfigTypes {
STYLE = "STYLE",
CONTENT = "CONTENT",
}
export function addSearchConfigToPanelConfig(
config: readonly PropertyPaneConfig[],
) {
return config.map((configItem) => {
if ((configItem as PropertyPaneSectionConfig).sectionName) {
const sectionConfig = {
...configItem,
};
if (configItem.children) {
sectionConfig.children = addSearchConfigToPanelConfig(
configItem.children,
);
}
return sectionConfig;
} else if ((configItem as PropertyPaneControlConfig).controlType) {
const controlConfig = configItem as PropertyPaneControlConfig;
if (controlConfig.panelConfig) {
return {
...controlConfig,
panelConfig: {
...controlConfig.panelConfig,
searchConfig: generatePropertyPaneSearchConfig(
controlConfig.panelConfig?.contentChildren ?? [],
controlConfig.panelConfig?.styleChildren ?? [],
),
},
};
}
return controlConfig;
}
return configItem;
});
}
function addSearchSpecificPropertiesToConfig(
config: readonly PropertyPaneConfig[],
tag: string,
): PropertyPaneConfig[] {
return config.map((configItem) => {
if ((configItem as PropertyPaneSectionConfig).sectionName) {
const sectionConfig = {
...configItem,
collapsible: false,
tag,
};
if (configItem.children) {
sectionConfig.children = addSearchSpecificPropertiesToConfig(
configItem.children,
tag,
);
}
return sectionConfig;
} else if ((configItem as PropertyPaneControlConfig).controlType) {
const controlConfig = configItem as PropertyPaneControlConfig;
if (controlConfig.panelConfig) {
return {
...controlConfig,
panelConfig: {
...controlConfig.panelConfig,
searchConfig: generatePropertyPaneSearchConfig(
controlConfig.panelConfig?.contentChildren ?? [],
controlConfig.panelConfig?.styleChildren ?? [],
),
},
};
}
return controlConfig;
}
return configItem;
});
}
export function generatePropertyPaneSearchConfig(
contentConfig: readonly PropertyPaneConfig[],
styleConfig: readonly PropertyPaneConfig[],
) {
return [
...addSearchSpecificPropertiesToConfig(contentConfig, "CONTENT"),
...addSearchSpecificPropertiesToConfig(styleConfig, "STYLE"),
];
}
/* This function recursively parses the property pane configuration and
adds random hash values as `id`.
These are generated once when the Appsmith editor is loaded,
the resulting config is frozen and re-used during the lifecycle
of the current browser session. See WidgetFactory
*/
export const addPropertyConfigIds = (config: PropertyPaneConfig[]) => {
return config.map((sectionOrControlConfig: PropertyPaneConfig) => {
sectionOrControlConfig.id = generateReactKey();
if (sectionOrControlConfig.children) {
sectionOrControlConfig.children = addPropertyConfigIds(
sectionOrControlConfig.children,
);
}
const config = sectionOrControlConfig as PropertyPaneControlConfig;
if (config.panelConfig) {
if (
config.panelConfig.children &&
Array.isArray(config.panelConfig.children)
) {
config.panelConfig.children = addPropertyConfigIds(
config.panelConfig.children,
);
}
if (
config.panelConfig.contentChildren &&
Array.isArray(config.panelConfig.contentChildren)
) {
config.panelConfig.contentChildren = addPropertyConfigIds(
config.panelConfig.contentChildren,
);
}
if (
config.panelConfig.styleChildren &&
Array.isArray(config.panelConfig.styleChildren)
) {
config.panelConfig.styleChildren = addPropertyConfigIds(
config.panelConfig.styleChildren,
);
}
(sectionOrControlConfig as PropertyPaneControlConfig) = config;
}
return sectionOrControlConfig;
});
};
/* General function which enhances the property pane configuration
We can use this to insert or add property configs based on widget
features passed as the second argument.
*/
export function enhancePropertyPaneConfig(
config: PropertyPaneConfig[],
features?: WidgetFeatures,
configType?: PropertyPaneConfigTypes,
widgetType?: WidgetType,
) {
// Enhance property pane with widget features
// TODO(abhinav): The following "configType" check should come
// from the features themselves.
if (
features &&
(configType === undefined || configType === PropertyPaneConfigTypes.CONTENT)
) {
Object.keys(features).forEach((registeredFeature: string) => {
const { sectionIndex } =
features[registeredFeature as RegisteredWidgetFeatures];
const sectionName = (config[sectionIndex] as PropertyPaneSectionConfig)
?.sectionName;
if (!sectionName || sectionName !== "General") {
log.error(`Invalid section index for feature: ${registeredFeature}`);
}
if (
Array.isArray(config[sectionIndex].children) &&
PropertyPaneConfigTemplates[
registeredFeature as RegisteredWidgetFeatures
]
) {
config[sectionIndex].children?.push(
...PropertyPaneConfigTemplates[
registeredFeature as RegisteredWidgetFeatures
],
);
config = WidgetFeaturePropertyPaneEnhancements[
registeredFeature as RegisteredWidgetFeatures
](config, widgetType);
}
});
}
return config;
}
/*
ValidationTypes.FUNCTION, allow us to configure functions within them,
However, these are not serializable, which results in them not being able to
be sent to the workers.
We convert these functions to strings and delete the original function properties
in this function
property added `fnString`
property deleted `fn`
*/
export function convertFunctionsToString(config: PropertyPaneConfig[]) {
return config.map((sectionOrControlConfig: PropertyPaneConfig) => {
const controlConfig = sectionOrControlConfig as PropertyPaneControlConfig;
if (
controlConfig.validation &&
controlConfig.validation?.type === ValidationTypes.FUNCTION &&
controlConfig.validation?.params &&
controlConfig.validation?.params.fn
) {
controlConfig.validation.params.fnString =
controlConfig.validation.params.fn.toString();
delete controlConfig.validation.params.fn;
return sectionOrControlConfig;
}
if (sectionOrControlConfig.children) {
sectionOrControlConfig.children = convertFunctionsToString(
sectionOrControlConfig.children,
);
}
const config = sectionOrControlConfig as PropertyPaneControlConfig;
if (
config.panelConfig &&
config.panelConfig.children &&
Array.isArray(config.panelConfig.children)
) {
config.panelConfig.children = convertFunctionsToString(
config.panelConfig.children,
);
(sectionOrControlConfig as PropertyPaneControlConfig) = config;
}
if (
config.panelConfig &&
config.panelConfig.contentChildren &&
Array.isArray(config.panelConfig.contentChildren)
) {
config.panelConfig.contentChildren = convertFunctionsToString(
config.panelConfig.contentChildren,
);
(sectionOrControlConfig as PropertyPaneControlConfig) = config;
}
if (
config.panelConfig &&
config.panelConfig.styleChildren &&
Array.isArray(config.panelConfig.styleChildren)
) {
config.panelConfig.styleChildren = convertFunctionsToString(
config.panelConfig.styleChildren,
);
(sectionOrControlConfig as PropertyPaneControlConfig) = config;
}
return sectionOrControlConfig;
});
}
export const checkIsDropTarget = memoize(function isDropTarget(
type: WidgetType,
) {
return !!WidgetFactory.widgetConfigMap.get(type)?.isCanvas;
});