## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
331 lines
10 KiB
TypeScript
331 lines
10 KiB
TypeScript
import { all, takeEvery, call, put, select } from "redux-saga/effects";
|
|
import type { ReduxAction } from "ee/constants/ReduxActionConstants";
|
|
import {
|
|
ReduxActionTypes,
|
|
ReduxActionErrorTypes,
|
|
} from "ee/constants/ReduxActionConstants";
|
|
import type { DefaultPlugin, PluginFormPayload } from "api/PluginApi";
|
|
import PluginsApi from "api/PluginApi";
|
|
import { validateResponse } from "sagas/ErrorSagas";
|
|
import { getCurrentWorkspaceId } from "ee/selectors/selectedWorkspaceSelectors";
|
|
import {
|
|
getActions,
|
|
getDatasources,
|
|
getPlugin,
|
|
getPluginForm,
|
|
getPlugins,
|
|
} from "ee/selectors/entitiesSelector";
|
|
import type { Datasource } from "entities/Datasource";
|
|
import type { Plugin } from "api/PluginApi";
|
|
import {
|
|
fetchPluginFormConfigsSuccess,
|
|
fetchPluginFormConfigSuccess,
|
|
fetchPluginFormConfigError,
|
|
} from "actions/pluginActions";
|
|
import {
|
|
defaultActionDependenciesConfig,
|
|
defaultActionEditorConfigs,
|
|
defaultActionSettings,
|
|
defaultDatasourceFormButtonConfig,
|
|
} from "constants/AppsmithActionConstants/ActionConstants";
|
|
import type { ApiResponse } from "api/ApiResponses";
|
|
import PluginApi from "api/PluginApi";
|
|
import log from "loglevel";
|
|
import {
|
|
getAppsmithAIPlugin,
|
|
getGraphQLPlugin,
|
|
PluginType,
|
|
} from "entities/Action";
|
|
import type {
|
|
FormEditorConfigs,
|
|
FormSettingsConfigs,
|
|
FormDependencyConfigs,
|
|
FormDatasourceButtonConfigs,
|
|
} from "utils/DynamicBindingUtils";
|
|
import type { ActionDataState } from "ee/reducers/entityReducers/actionsReducer";
|
|
import { getFromServerWhenNoPrefetchedResult } from "./helper";
|
|
|
|
function* fetchPluginsSaga(
|
|
action: ReduxAction<
|
|
{ workspaceId?: string; plugins?: ApiResponse<Plugin[]> } | undefined
|
|
>,
|
|
) {
|
|
try {
|
|
const plugins = action.payload?.plugins;
|
|
let workspaceId: string = yield select(getCurrentWorkspaceId);
|
|
|
|
if (action.payload?.workspaceId) workspaceId = action.payload?.workspaceId;
|
|
|
|
if (!workspaceId) {
|
|
throw Error("Workspace id does not exist");
|
|
}
|
|
|
|
const pluginsResponse: ApiResponse<Plugin[]> = yield call(
|
|
getFromServerWhenNoPrefetchedResult,
|
|
plugins,
|
|
() => call(PluginsApi.fetchPlugins, workspaceId),
|
|
);
|
|
|
|
const isValid: boolean = yield validateResponse(pluginsResponse);
|
|
|
|
if (isValid) {
|
|
yield put({
|
|
type: ReduxActionTypes.FETCH_PLUGINS_SUCCESS,
|
|
payload: pluginsResponse.data,
|
|
});
|
|
}
|
|
} catch (error) {
|
|
yield put({
|
|
type: ReduxActionErrorTypes.FETCH_PLUGINS_ERROR,
|
|
payload: { error },
|
|
});
|
|
}
|
|
}
|
|
|
|
function* fetchPluginFormConfigsSaga(action?: {
|
|
payload?: { pluginFormConfigs?: ApiResponse<PluginFormPayload[]> };
|
|
}) {
|
|
const pluginFormConfigs = action?.payload?.pluginFormConfigs;
|
|
|
|
try {
|
|
const datasources: Datasource[] = yield select(getDatasources);
|
|
const plugins: Plugin[] = yield select(getPlugins);
|
|
// Add plugins of all the datasources of their workspace
|
|
const pluginIdFormsToFetch = new Set(
|
|
datasources.map((datasource) => datasource.pluginId),
|
|
);
|
|
// Add the api plugin id by default as API, JS, Graphql can exists without datasource
|
|
const apiPlugin = plugins.find((plugin) => plugin.type === PluginType.API);
|
|
const jsPlugin = plugins.find((plugin) => plugin.type === PluginType.JS);
|
|
const graphqlPlugin = getGraphQLPlugin(plugins);
|
|
const appsmithAIPlugin = getAppsmithAIPlugin(plugins);
|
|
|
|
if (apiPlugin) {
|
|
pluginIdFormsToFetch.add(apiPlugin.id);
|
|
}
|
|
|
|
if (graphqlPlugin) {
|
|
pluginIdFormsToFetch.add(graphqlPlugin.id);
|
|
}
|
|
|
|
if (appsmithAIPlugin) {
|
|
pluginIdFormsToFetch.add(appsmithAIPlugin.id);
|
|
}
|
|
|
|
const actions: ActionDataState = yield select(getActions);
|
|
const actionPluginIds = actions.map((action) => action.config.pluginId);
|
|
|
|
for (const pluginId of actionPluginIds) {
|
|
pluginIdFormsToFetch.add(pluginId);
|
|
}
|
|
|
|
const pluginCalls = [...pluginIdFormsToFetch].map((id) =>
|
|
call(
|
|
getFromServerWhenNoPrefetchedResult,
|
|
// Set the data if it exists in the prefetched data
|
|
// This is to avoid making a call to the server for the data
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
pluginFormConfigs?.data?.[id as any]
|
|
? {
|
|
...pluginFormConfigs,
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
data: pluginFormConfigs?.data?.[id as any],
|
|
}
|
|
: undefined,
|
|
// If the data does not exist in the prefetched data, make a call to the server
|
|
() => call(PluginsApi.fetchFormConfig, id),
|
|
),
|
|
);
|
|
|
|
const pluginFormResponses: ApiResponse<PluginFormPayload>[] =
|
|
yield all(pluginCalls);
|
|
|
|
const pluginFormData: PluginFormPayload[] = [];
|
|
|
|
for (let i = 0; i < pluginFormResponses.length; i++) {
|
|
const response = pluginFormResponses[i];
|
|
|
|
yield validateResponse(response);
|
|
pluginFormData.push(response.data);
|
|
}
|
|
|
|
if (jsPlugin) {
|
|
pluginIdFormsToFetch.add(jsPlugin.id);
|
|
}
|
|
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const formConfigs: Record<string, any[]> = {};
|
|
const editorConfigs: FormEditorConfigs = {};
|
|
const settingConfigs: FormSettingsConfigs = {};
|
|
const dependencies: FormDependencyConfigs = {};
|
|
const datasourceFormButtonConfigs: FormDatasourceButtonConfigs = {};
|
|
|
|
Array.from(pluginIdFormsToFetch).forEach((pluginId, index) => {
|
|
const plugin = plugins.find((plugin) => plugin.id === pluginId);
|
|
|
|
if (plugin && plugin.type === PluginType.JS) {
|
|
settingConfigs[pluginId] = defaultActionSettings[plugin.type];
|
|
editorConfigs[pluginId] = defaultActionEditorConfigs[plugin.type];
|
|
formConfigs[pluginId] = [];
|
|
dependencies[pluginId] = defaultActionDependenciesConfig[plugin.type];
|
|
} else {
|
|
// Datasource form always use server's copy
|
|
if (!!pluginFormData[index]) {
|
|
formConfigs[pluginId] = pluginFormData[index].form;
|
|
|
|
// Action editor form if not available use default
|
|
if (plugin && !pluginFormData[index].editor) {
|
|
editorConfigs[pluginId] = defaultActionEditorConfigs[plugin.type];
|
|
} else {
|
|
editorConfigs[pluginId] = pluginFormData[index].editor;
|
|
}
|
|
|
|
// Action settings form if not available use default
|
|
if (plugin && !pluginFormData[index].setting) {
|
|
settingConfigs[pluginId] = defaultActionSettings[plugin.type];
|
|
} else {
|
|
settingConfigs[pluginId] = pluginFormData[index].setting;
|
|
}
|
|
|
|
// Action dependencies config if not available use default
|
|
if (plugin && !pluginFormData[index].dependencies) {
|
|
dependencies[pluginId] =
|
|
defaultActionDependenciesConfig[plugin.type];
|
|
} else {
|
|
dependencies[pluginId] = pluginFormData[index].dependencies;
|
|
}
|
|
|
|
// Datasource form buttons config if not available use default
|
|
if (plugin && !pluginFormData[index].formButton) {
|
|
datasourceFormButtonConfigs[pluginId] =
|
|
defaultDatasourceFormButtonConfig[plugin.type];
|
|
} else {
|
|
datasourceFormButtonConfigs[pluginId] =
|
|
pluginFormData[index].formButton;
|
|
}
|
|
}
|
|
}
|
|
});
|
|
|
|
yield put(
|
|
fetchPluginFormConfigsSuccess({
|
|
formConfigs,
|
|
editorConfigs,
|
|
settingConfigs,
|
|
dependencies,
|
|
datasourceFormButtonConfigs,
|
|
}),
|
|
);
|
|
} catch (error) {
|
|
yield put({
|
|
type: ReduxActionErrorTypes.FETCH_PLUGIN_FORM_CONFIGS_ERROR,
|
|
payload: { error },
|
|
});
|
|
}
|
|
}
|
|
|
|
export function* checkAndGetPluginFormConfigsSaga(pluginId: string) {
|
|
try {
|
|
const plugin: Plugin = yield select(getPlugin, pluginId);
|
|
const formConfig: Record<string, unknown> = yield select(
|
|
getPluginForm,
|
|
pluginId,
|
|
);
|
|
|
|
if (!formConfig) {
|
|
const formConfigResponse: ApiResponse<PluginFormPayload> =
|
|
yield PluginApi.fetchFormConfig(pluginId);
|
|
|
|
yield validateResponse(formConfigResponse);
|
|
|
|
if (!formConfigResponse.data.setting) {
|
|
formConfigResponse.data.setting = defaultActionSettings[plugin.type];
|
|
}
|
|
|
|
if (!formConfigResponse.data.editor) {
|
|
formConfigResponse.data.editor =
|
|
defaultActionEditorConfigs[plugin.type];
|
|
}
|
|
|
|
if (!formConfigResponse.data.dependencies) {
|
|
formConfigResponse.data.dependencies =
|
|
defaultActionDependenciesConfig[plugin.type];
|
|
}
|
|
|
|
if (!formConfigResponse.data.formButton) {
|
|
formConfigResponse.data.formButton =
|
|
defaultDatasourceFormButtonConfig[plugin.type];
|
|
}
|
|
|
|
yield put(
|
|
fetchPluginFormConfigSuccess({
|
|
id: pluginId,
|
|
...formConfigResponse.data,
|
|
}),
|
|
);
|
|
}
|
|
} catch (e) {
|
|
log.error("Failed to get plugin form");
|
|
yield put(
|
|
fetchPluginFormConfigError({
|
|
id: pluginId,
|
|
}),
|
|
);
|
|
}
|
|
}
|
|
|
|
interface GetPluginFormConfigParams {
|
|
id: string;
|
|
type: string;
|
|
}
|
|
|
|
function* getPluginFormConfig({ id }: GetPluginFormConfigParams) {
|
|
yield call(checkAndGetPluginFormConfigsSaga, id);
|
|
}
|
|
|
|
function* getDefaultPluginsSaga() {
|
|
try {
|
|
const response: ApiResponse<DefaultPlugin> = yield call(
|
|
PluginsApi.fetchDefaultPlugins,
|
|
);
|
|
const isValid: boolean = yield validateResponse(response);
|
|
|
|
if (isValid) {
|
|
yield put({
|
|
type: ReduxActionTypes.GET_DEFAULT_PLUGINS_SUCCESS,
|
|
payload: response.data,
|
|
});
|
|
}
|
|
} catch (error) {
|
|
yield put({
|
|
type: ReduxActionErrorTypes.GET_DEFAULT_PLUGINS_ERROR,
|
|
payload: {
|
|
error,
|
|
},
|
|
});
|
|
}
|
|
}
|
|
|
|
function* root() {
|
|
yield all([
|
|
takeEvery(ReduxActionTypes.FETCH_PLUGINS_REQUEST, fetchPluginsSaga),
|
|
takeEvery(
|
|
ReduxActionTypes.FETCH_PLUGIN_FORM_CONFIGS_REQUEST,
|
|
fetchPluginFormConfigsSaga,
|
|
),
|
|
takeEvery(
|
|
ReduxActionTypes.GET_PLUGIN_FORM_CONFIG_INIT,
|
|
getPluginFormConfig,
|
|
),
|
|
takeEvery(
|
|
ReduxActionTypes.GET_DEFAULT_PLUGINS_REQUEST,
|
|
getDefaultPluginsSaga,
|
|
),
|
|
]);
|
|
}
|
|
|
|
export default root;
|