## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
215 lines
7.8 KiB
TypeScript
215 lines
7.8 KiB
TypeScript
import {
|
|
defaultAffectedJSObjects,
|
|
evalQueueBuffer,
|
|
evaluateTreeSaga,
|
|
evalWorker,
|
|
} from "./EvaluationsSaga";
|
|
import { expectSaga } from "redux-saga-test-plan";
|
|
import { EVAL_WORKER_ACTIONS } from "ee/workers/Evaluation/evalWorkerActions";
|
|
import { select } from "redux-saga/effects";
|
|
import { getMetaWidgets, getWidgets, getWidgetsMeta } from "./selectors";
|
|
import { getAllActionValidationConfig } from "ee//selectors/entitiesSelector";
|
|
import { getSelectedAppTheme } from "selectors/appThemingSelectors";
|
|
import { getAppMode } from "ee/selectors/applicationSelectors";
|
|
import * as log from "loglevel";
|
|
|
|
import type { ReduxAction } from "ee/constants/ReduxActionConstants";
|
|
import {
|
|
ReduxActionErrorTypes,
|
|
ReduxActionTypes,
|
|
} from "ee/constants/ReduxActionConstants";
|
|
import { fetchPluginFormConfigsSuccess } from "actions/pluginActions";
|
|
import { createJSCollectionSuccess } from "actions/jsActionActions";
|
|
jest.mock("loglevel");
|
|
|
|
describe("evaluateTreeSaga", () => {
|
|
afterAll(() => {
|
|
jest.unmock("loglevel");
|
|
});
|
|
test("should set 'shouldRespondWithLogs'to evaluations when the log level is debug", async () => {
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(log.getLevel as any).mockReturnValue(log.levels.DEBUG);
|
|
const unEvalAndConfigTree = { unEvalTree: {}, configTree: {} };
|
|
|
|
return expectSaga(evaluateTreeSaga, unEvalAndConfigTree)
|
|
.provide([
|
|
[select(getAllActionValidationConfig), {}],
|
|
[select(getWidgets), {}],
|
|
[select(getMetaWidgets), {}],
|
|
[select(getSelectedAppTheme), {}],
|
|
[select(getAppMode), false],
|
|
[select(getWidgetsMeta), {}],
|
|
])
|
|
.call(evalWorker.request, EVAL_WORKER_ACTIONS.EVAL_TREE, {
|
|
unevalTree: unEvalAndConfigTree,
|
|
widgetTypeConfigMap: undefined,
|
|
widgets: {},
|
|
theme: {},
|
|
shouldReplay: true,
|
|
allActionValidationConfig: {},
|
|
forceEvaluation: false,
|
|
metaWidgets: {},
|
|
appMode: false,
|
|
widgetsMeta: {},
|
|
shouldRespondWithLogs: true,
|
|
affectedJSObjects: { ids: [], isAllAffected: false },
|
|
})
|
|
.run();
|
|
});
|
|
test("should set 'shouldRespondWithLogs' to false when the log level is not debug", async () => {
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(log.getLevel as any).mockReturnValue(log.levels.INFO);
|
|
const unEvalAndConfigTree = { unEvalTree: {}, configTree: {} };
|
|
|
|
return expectSaga(evaluateTreeSaga, unEvalAndConfigTree)
|
|
.provide([
|
|
[select(getAllActionValidationConfig), {}],
|
|
[select(getWidgets), {}],
|
|
[select(getMetaWidgets), {}],
|
|
[select(getSelectedAppTheme), {}],
|
|
[select(getAppMode), false],
|
|
[select(getWidgetsMeta), {}],
|
|
])
|
|
.call(evalWorker.request, EVAL_WORKER_ACTIONS.EVAL_TREE, {
|
|
unevalTree: unEvalAndConfigTree,
|
|
widgetTypeConfigMap: undefined,
|
|
widgets: {},
|
|
theme: {},
|
|
shouldReplay: true,
|
|
allActionValidationConfig: {},
|
|
forceEvaluation: false,
|
|
metaWidgets: {},
|
|
appMode: false,
|
|
widgetsMeta: {},
|
|
shouldRespondWithLogs: false,
|
|
affectedJSObjects: { ids: [], isAllAffected: false },
|
|
})
|
|
.run();
|
|
});
|
|
test("should propagate affectedJSObjects property to evaluation action", async () => {
|
|
const unEvalAndConfigTree = { unEvalTree: {}, configTree: {} };
|
|
const affectedJSObjects = {
|
|
isAllAffected: false,
|
|
ids: ["1", "2"],
|
|
};
|
|
|
|
return expectSaga(
|
|
evaluateTreeSaga,
|
|
unEvalAndConfigTree,
|
|
[],
|
|
undefined,
|
|
undefined,
|
|
undefined,
|
|
affectedJSObjects,
|
|
)
|
|
.provide([
|
|
[select(getAllActionValidationConfig), {}],
|
|
[select(getWidgets), {}],
|
|
[select(getMetaWidgets), {}],
|
|
[select(getSelectedAppTheme), {}],
|
|
[select(getAppMode), false],
|
|
[select(getWidgetsMeta), {}],
|
|
])
|
|
.call(evalWorker.request, EVAL_WORKER_ACTIONS.EVAL_TREE, {
|
|
unevalTree: unEvalAndConfigTree,
|
|
widgetTypeConfigMap: undefined,
|
|
widgets: {},
|
|
theme: {},
|
|
shouldReplay: true,
|
|
allActionValidationConfig: {},
|
|
forceEvaluation: false,
|
|
metaWidgets: {},
|
|
appMode: false,
|
|
widgetsMeta: {},
|
|
shouldRespondWithLogs: false,
|
|
affectedJSObjects,
|
|
})
|
|
.run();
|
|
});
|
|
});
|
|
|
|
describe("evalQueueBuffer", () => {
|
|
test("should return a buffered action with the default affectedJSObjects state for an action which does not have affectedJSObjects associated to it", () => {
|
|
const buffer = evalQueueBuffer();
|
|
|
|
// this action does not generate an affectedJSObject
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
buffer.put(fetchPluginFormConfigsSuccess({} as any));
|
|
const bufferedAction = buffer.take();
|
|
|
|
expect(bufferedAction).toEqual({
|
|
type: ReduxActionTypes.BUFFERED_ACTION,
|
|
affectedJSObjects: defaultAffectedJSObjects,
|
|
postEvalActions: [],
|
|
});
|
|
});
|
|
test("should club all JS actions affectedJSObjects's ids", () => {
|
|
const buffer = evalQueueBuffer();
|
|
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
buffer.put(createJSCollectionSuccess({ id: "1" } as any));
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
buffer.put(createJSCollectionSuccess({ id: "2" } as any));
|
|
const bufferedAction = buffer.take();
|
|
|
|
expect(bufferedAction).toEqual({
|
|
type: ReduxActionTypes.BUFFERED_ACTION,
|
|
affectedJSObjects: { ids: ["1", "2"], isAllAffected: false },
|
|
postEvalActions: [],
|
|
});
|
|
});
|
|
test("should return all JS actions that have changed when there is a pending action which affects all JS actions ", () => {
|
|
const buffer = evalQueueBuffer();
|
|
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
buffer.put(createJSCollectionSuccess({ id: "1" } as any));
|
|
// this action triggers an isAllAffected flag
|
|
buffer.put({
|
|
type: ReduxActionErrorTypes.FETCH_JS_ACTIONS_ERROR,
|
|
} as ReduxAction<unknown>);
|
|
// queue is not empty
|
|
expect(buffer.isEmpty()).not.toBeTruthy();
|
|
|
|
const bufferedAction = buffer.take();
|
|
|
|
expect(bufferedAction).toEqual({
|
|
type: ReduxActionTypes.BUFFERED_ACTION,
|
|
affectedJSObjects: { ids: [], isAllAffected: true },
|
|
postEvalActions: [],
|
|
});
|
|
expect(buffer.isEmpty()).toBeTruthy();
|
|
});
|
|
test("should reset the collectedAffectedJSObjects after the buffered action has been dequeued and the subsequent actions should have the defaultAffectedJSObjects", () => {
|
|
const buffer = evalQueueBuffer();
|
|
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
buffer.put(createJSCollectionSuccess({ id: "1" } as any));
|
|
const bufferedAction = buffer.take();
|
|
|
|
expect(bufferedAction).toEqual({
|
|
type: ReduxActionTypes.BUFFERED_ACTION,
|
|
affectedJSObjects: { ids: ["1"], isAllAffected: false },
|
|
postEvalActions: [],
|
|
});
|
|
expect(buffer.isEmpty()).toBeTruthy();
|
|
// this action does not generate an affectedJSObject, So the subsequent buffered action should have default affectedJSObjects
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
buffer.put(fetchPluginFormConfigsSuccess({ id: "1" } as any));
|
|
const bufferedActionsWithDefaultAffectedJSObjects = buffer.take();
|
|
|
|
expect(bufferedActionsWithDefaultAffectedJSObjects).toEqual({
|
|
type: ReduxActionTypes.BUFFERED_ACTION,
|
|
affectedJSObjects: defaultAffectedJSObjects,
|
|
postEvalActions: [],
|
|
});
|
|
});
|
|
});
|