## Description ### Fixes - [x] https://github.com/appsmithorg/appsmith/issues/19383 - [x] https://github.com/appsmithorg/appsmith/issues/19384 - [x] https://github.com/appsmithorg/appsmith/issues/19385 - [x] https://github.com/appsmithorg/appsmith/issues/19386 - [x] https://github.com/appsmithorg/appsmith/issues/19387 - [x] https://github.com/appsmithorg/appsmith/issues/19388 - [x] https://github.com/appsmithorg/appsmith/issues/19389 - [x] https://github.com/appsmithorg/appsmith/issues/19390 - [x] https://github.com/appsmithorg/appsmith/issues/19391 - [x] https://github.com/appsmithorg/appsmith/issues/19392 - [x] https://github.com/appsmithorg/appsmith/issues/19393 - [x] https://github.com/appsmithorg/appsmith/issues/19394 - [x] https://github.com/appsmithorg/appsmith/issues/19395 - [x] https://github.com/appsmithorg/appsmith/issues/19396 - [x] https://github.com/appsmithorg/appsmith/issues/19397 - [x] https://github.com/appsmithorg/appsmith/issues/19398 - [x] https://github.com/appsmithorg/appsmith/issues/19399 - [x] https://github.com/appsmithorg/appsmith/issues/19400 - [x] https://github.com/appsmithorg/appsmith/issues/19401 - [x] https://github.com/appsmithorg/appsmith/issues/19402 - [x] https://github.com/appsmithorg/appsmith/issues/19403 - [x] https://github.com/appsmithorg/appsmith/issues/19404 - [x] https://github.com/appsmithorg/appsmith/issues/19405 - [x] https://github.com/appsmithorg/appsmith/issues/19406 - [x] https://github.com/appsmithorg/appsmith/issues/19407 - [x] https://github.com/appsmithorg/appsmith/issues/19408 - [x] https://github.com/appsmithorg/appsmith/issues/19409 Fixes # (issue) > if no issue exists, please create an issue and ask the maintainers about this first Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update ## How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. > Please also list any relevant details for your test configuration. > Delete anything that is not important - Manual - Jest - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --------- Co-authored-by: Ankita Kinger <ankita@appsmith.com> Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Co-authored-by: Tanvi Bhakta <tanvi@appsmith.com> Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com> Co-authored-by: Aman Agarwal <aman@appsmith.com> Co-authored-by: Rohit Agarwal <rohit_agarwal@live.in> Co-authored-by: Nilesh Sarupriya <nilesh@appsmith.com> Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com> Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com> Co-authored-by: Aishwarya UR <aishwarya@appsmith.com> Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local> Co-authored-by: Vijetha-Kaja <vijetha@appsmith.com> Co-authored-by: Parthvi <80334441+Parthvi12@users.noreply.github.com> Co-authored-by: Apple <nandan@thinkify.io> Co-authored-by: Saroj <43822041+sarojsarab@users.noreply.github.com> Co-authored-by: Sangeeth Sivan <74818788+berzerkeer@users.noreply.github.com> Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com> Co-authored-by: rahulramesha <rahul@appsmith.com> Co-authored-by: Aswath K <aswath.sana@gmail.com> Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com> Co-authored-by: Vijetha-Kaja <119562824+Vijetha-Kaja@users.noreply.github.com> Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
413 lines
10 KiB
TypeScript
413 lines
10 KiB
TypeScript
import type { ApiResponse } from "api/ApiResponses";
|
|
import LibraryApi from "api/LibraryAPI";
|
|
import {
|
|
createMessage,
|
|
customJSLibraryMessages,
|
|
} from "@appsmith/constants/messages";
|
|
import type { ReduxAction } from "@appsmith/constants/ReduxActionConstants";
|
|
import {
|
|
ReduxActionErrorTypes,
|
|
ReduxActionTypes,
|
|
} from "@appsmith/constants/ReduxActionConstants";
|
|
import type { ActionPattern } from "redux-saga/effects";
|
|
import {
|
|
actionChannel,
|
|
all,
|
|
call,
|
|
put,
|
|
select,
|
|
take,
|
|
takeEvery,
|
|
takeLatest,
|
|
} from "redux-saga/effects";
|
|
import { getCurrentApplicationId } from "selectors/editorSelectors";
|
|
import CodemirrorTernService from "utils/autocomplete/CodemirrorTernService";
|
|
import { EVAL_WORKER_ACTIONS } from "@appsmith/workers/Evaluation/evalWorkerActions";
|
|
import { validateResponse } from "./ErrorSagas";
|
|
import { evaluateTreeSaga, EvalWorker } from "./EvaluationsSaga";
|
|
import log from "loglevel";
|
|
import { APP_MODE } from "entities/App";
|
|
import { getAppMode } from "@appsmith/selectors/applicationSelectors";
|
|
import AnalyticsUtil from "utils/AnalyticsUtil";
|
|
import type { TJSLibrary } from "workers/common/JSLibrary";
|
|
import { getUsedActionNames } from "selectors/actionSelectors";
|
|
import AppsmithConsole from "utils/AppsmithConsole";
|
|
import { selectInstalledLibraries } from "selectors/entitiesSelector";
|
|
import { toast } from "design-system";
|
|
|
|
export function parseErrorMessage(text: string) {
|
|
return text.split(": ").slice(1).join("");
|
|
}
|
|
|
|
function* handleInstallationFailure(
|
|
url: string,
|
|
message: string,
|
|
accessor?: string[],
|
|
) {
|
|
if (accessor) {
|
|
yield call(
|
|
EvalWorker.request,
|
|
EVAL_WORKER_ACTIONS.UNINSTALL_LIBRARY,
|
|
accessor,
|
|
);
|
|
}
|
|
|
|
AppsmithConsole.error({
|
|
text: `Failed to install library script at ${url}`,
|
|
});
|
|
|
|
toast.show(message || `Failed to install library script at ${url}`, {
|
|
kind: "error",
|
|
});
|
|
const applicationid: ReturnType<typeof getCurrentApplicationId> =
|
|
yield select(getCurrentApplicationId);
|
|
yield put({
|
|
type: ReduxActionErrorTypes.INSTALL_LIBRARY_FAILED,
|
|
payload: { url, show: false },
|
|
});
|
|
AnalyticsUtil.logEvent("INSTALL_LIBRARY", {
|
|
url,
|
|
success: false,
|
|
applicationid,
|
|
});
|
|
log.error(message);
|
|
}
|
|
|
|
export function* installLibrarySaga(lib: Partial<TJSLibrary>) {
|
|
const { url } = lib;
|
|
|
|
const takenNamesMap: Record<string, true> = yield select(
|
|
getUsedActionNames,
|
|
"",
|
|
);
|
|
|
|
const installedLibraries: TJSLibrary[] = yield select(
|
|
selectInstalledLibraries,
|
|
);
|
|
|
|
const takenAccessors = ([] as string[]).concat(
|
|
...installedLibraries.map((lib) => lib.accessor),
|
|
);
|
|
|
|
const { accessor, defs, error, success } = yield call(
|
|
EvalWorker.request,
|
|
EVAL_WORKER_ACTIONS.INSTALL_LIBRARY,
|
|
{
|
|
url,
|
|
takenNamesMap,
|
|
takenAccessors,
|
|
},
|
|
);
|
|
|
|
if (!success) {
|
|
log.debug("Failed to install locally");
|
|
yield call(handleInstallationFailure, url as string, error?.message);
|
|
return;
|
|
}
|
|
|
|
const name: string = lib.name || accessor[accessor.length - 1];
|
|
const applicationId: string = yield select(getCurrentApplicationId);
|
|
|
|
const versionMatch = (url as string).match(/(?:@)(\d+\.)(\d+\.)(\d+)/);
|
|
let [version = ""] = versionMatch ? versionMatch : [];
|
|
version = version.startsWith("@") ? version.slice(1) : version;
|
|
version = version || lib?.version || "";
|
|
|
|
let stringifiedDefs = "";
|
|
|
|
try {
|
|
stringifiedDefs = JSON.stringify(defs);
|
|
} catch (e) {
|
|
stringifiedDefs = JSON.stringify({
|
|
"!name": `LIB/${accessor[accessor.length - 1]}`,
|
|
});
|
|
}
|
|
|
|
const response: ApiResponse<boolean> = yield call(
|
|
LibraryApi.addLibrary,
|
|
applicationId,
|
|
{
|
|
name,
|
|
version,
|
|
accessor,
|
|
defs: stringifiedDefs,
|
|
url,
|
|
},
|
|
);
|
|
|
|
try {
|
|
const isValidResponse: boolean = yield validateResponse(response, false);
|
|
if (!isValidResponse || !response.data) {
|
|
log.debug("Install API failed");
|
|
yield call(handleInstallationFailure, url as string, "", accessor);
|
|
return;
|
|
}
|
|
} catch (e) {
|
|
yield call(
|
|
handleInstallationFailure,
|
|
url as string,
|
|
(e as Error).message,
|
|
accessor,
|
|
);
|
|
return;
|
|
}
|
|
|
|
try {
|
|
CodemirrorTernService.updateDef(defs["!name"], defs);
|
|
AnalyticsUtil.logEvent("DEFINITIONS_GENERATION", { url, success: true });
|
|
} catch (e) {
|
|
toast.show(
|
|
createMessage(customJSLibraryMessages.AUTOCOMPLETE_FAILED, name),
|
|
{
|
|
kind: "warning",
|
|
},
|
|
);
|
|
AppsmithConsole.warning({
|
|
text: `Failed to generate code definitions for ${name}`,
|
|
});
|
|
AnalyticsUtil.logEvent("DEFINITIONS_GENERATION", { url, success: false });
|
|
log.debug("Failed to update Tern defs", e);
|
|
}
|
|
|
|
yield put({
|
|
type: ReduxActionTypes.UPDATE_LINT_GLOBALS,
|
|
payload: {
|
|
libs: [
|
|
{
|
|
name,
|
|
version,
|
|
url,
|
|
accessor,
|
|
},
|
|
],
|
|
add: true,
|
|
},
|
|
});
|
|
|
|
//TODO: Check if we could avoid this.
|
|
yield call(evaluateTreeSaga, [], false, true, true);
|
|
|
|
yield put({
|
|
type: ReduxActionTypes.INSTALL_LIBRARY_SUCCESS,
|
|
payload: {
|
|
url,
|
|
accessor,
|
|
version,
|
|
name,
|
|
},
|
|
});
|
|
|
|
toast.show(
|
|
createMessage(
|
|
customJSLibraryMessages.INSTALLATION_SUCCESSFUL,
|
|
accessor[accessor.length - 1],
|
|
),
|
|
{
|
|
kind: "success",
|
|
},
|
|
);
|
|
AnalyticsUtil.logEvent("INSTALL_LIBRARY", {
|
|
url,
|
|
namespace: accessor.join("."),
|
|
success: true,
|
|
applicationId,
|
|
});
|
|
|
|
AppsmithConsole.info({
|
|
text: `${name} installed successfully`,
|
|
});
|
|
}
|
|
|
|
function* uninstallLibrarySaga(action: ReduxAction<TJSLibrary>) {
|
|
const { accessor, name } = action.payload;
|
|
const applicationId: string = yield select(getCurrentApplicationId);
|
|
|
|
try {
|
|
const response: ApiResponse = yield call(
|
|
LibraryApi.removeLibrary,
|
|
applicationId,
|
|
action.payload,
|
|
);
|
|
|
|
const isValidResponse: boolean = yield validateResponse(response);
|
|
|
|
if (!isValidResponse) {
|
|
yield put({
|
|
type: ReduxActionErrorTypes.UNINSTALL_LIBRARY_FAILED,
|
|
payload: accessor,
|
|
});
|
|
AnalyticsUtil.logEvent("UNINSTALL_LIBRARY", {
|
|
url: action.payload.url,
|
|
success: false,
|
|
});
|
|
return;
|
|
}
|
|
|
|
yield put({
|
|
type: ReduxActionTypes.UPDATE_LINT_GLOBALS,
|
|
payload: {
|
|
libs: [action.payload],
|
|
add: false,
|
|
},
|
|
});
|
|
|
|
const { success }: { success: boolean } = yield call(
|
|
EvalWorker.request,
|
|
EVAL_WORKER_ACTIONS.UNINSTALL_LIBRARY,
|
|
accessor,
|
|
);
|
|
if (!success) {
|
|
toast.show(
|
|
createMessage(customJSLibraryMessages.UNINSTALL_FAILED, name),
|
|
{
|
|
kind: "error",
|
|
},
|
|
);
|
|
}
|
|
|
|
try {
|
|
CodemirrorTernService.removeDef(`LIB/${accessor[accessor.length - 1]}`);
|
|
} catch (e) {
|
|
log.debug(`Failed to remove definitions for ${name}`, e);
|
|
}
|
|
|
|
yield call(evaluateTreeSaga, [], false, true, true);
|
|
|
|
yield put({
|
|
type: ReduxActionTypes.UNINSTALL_LIBRARY_SUCCESS,
|
|
payload: action.payload,
|
|
});
|
|
|
|
toast.show(createMessage(customJSLibraryMessages.UNINSTALL_SUCCESS, name), {
|
|
kind: "success",
|
|
});
|
|
AnalyticsUtil.logEvent("UNINSTALL_LIBRARY", {
|
|
url: action.payload.url,
|
|
success: true,
|
|
});
|
|
} catch (e) {
|
|
toast.show(createMessage(customJSLibraryMessages.UNINSTALL_FAILED, name), {
|
|
kind: "error",
|
|
});
|
|
AnalyticsUtil.logEvent("UNINSTALL_LIBRARY", {
|
|
url: action.payload.url,
|
|
success: false,
|
|
});
|
|
}
|
|
}
|
|
|
|
function* fetchJSLibraries(action: ReduxAction<string>) {
|
|
const applicationId: string = action.payload;
|
|
const mode: APP_MODE = yield select(getAppMode);
|
|
try {
|
|
const response: ApiResponse = yield call(
|
|
LibraryApi.getLibraries,
|
|
applicationId,
|
|
mode,
|
|
);
|
|
const isValidResponse: boolean = yield validateResponse(response);
|
|
if (!isValidResponse) return;
|
|
|
|
const libraries = response.data as Array<TJSLibrary & { defs: string }>;
|
|
|
|
const { message, success }: { success: boolean; message: string } =
|
|
yield call(
|
|
EvalWorker.request,
|
|
EVAL_WORKER_ACTIONS.LOAD_LIBRARIES,
|
|
libraries.map((lib) => ({
|
|
name: lib.name,
|
|
version: lib.version,
|
|
url: lib.url,
|
|
accessor: lib.accessor,
|
|
})),
|
|
);
|
|
|
|
if (!success) {
|
|
if (mode === APP_MODE.EDIT) {
|
|
yield put({
|
|
type: ReduxActionTypes.FETCH_JS_LIBRARIES_SUCCESS,
|
|
payload: libraries.map((lib) => ({
|
|
name: lib.name,
|
|
accessor: lib.accessor,
|
|
version: lib.version,
|
|
url: lib.url,
|
|
docsURL: lib.docsURL,
|
|
})),
|
|
});
|
|
toast.show(parseErrorMessage(message), {
|
|
kind: "warning",
|
|
});
|
|
} else {
|
|
yield put({
|
|
type: ReduxActionErrorTypes.FETCH_JS_LIBRARIES_FAILED,
|
|
});
|
|
}
|
|
return;
|
|
}
|
|
|
|
if (mode === APP_MODE.EDIT) {
|
|
for (const lib of libraries) {
|
|
try {
|
|
const defs = JSON.parse(lib.defs);
|
|
CodemirrorTernService.updateDef(defs["!name"], defs);
|
|
} catch (e) {
|
|
toast.show(
|
|
createMessage(
|
|
customJSLibraryMessages.AUTOCOMPLETE_FAILED,
|
|
lib.name,
|
|
),
|
|
{
|
|
kind: "info",
|
|
},
|
|
);
|
|
}
|
|
}
|
|
yield put({
|
|
type: ReduxActionTypes.UPDATE_LINT_GLOBALS,
|
|
payload: {
|
|
libs: libraries,
|
|
},
|
|
});
|
|
}
|
|
|
|
yield put({
|
|
type: ReduxActionTypes.FETCH_JS_LIBRARIES_SUCCESS,
|
|
payload: libraries.map((lib) => ({
|
|
name: lib.name,
|
|
accessor: lib.accessor,
|
|
version: lib.version,
|
|
url: lib.url,
|
|
docsURL: lib.docsURL,
|
|
})),
|
|
});
|
|
} catch (e) {
|
|
yield put({
|
|
type: ReduxActionErrorTypes.FETCH_JS_LIBRARIES_FAILED,
|
|
});
|
|
}
|
|
}
|
|
|
|
function* startInstallationRequestChannel() {
|
|
const queueInstallChannel: ActionPattern<any> = yield actionChannel([
|
|
ReduxActionTypes.INSTALL_LIBRARY_INIT,
|
|
]);
|
|
while (true) {
|
|
const action: ReduxAction<Partial<TJSLibrary>> = yield take(
|
|
queueInstallChannel,
|
|
);
|
|
yield put({
|
|
type: ReduxActionTypes.INSTALL_LIBRARY_START,
|
|
payload: action.payload.url,
|
|
});
|
|
yield call(installLibrarySaga, action.payload);
|
|
}
|
|
}
|
|
|
|
export default function* () {
|
|
yield all([
|
|
takeEvery(ReduxActionTypes.UNINSTALL_LIBRARY_INIT, uninstallLibrarySaga),
|
|
takeLatest(ReduxActionTypes.FETCH_JS_LIBRARIES_INIT, fetchJSLibraries),
|
|
call(startInstallationRequestChannel),
|
|
]);
|
|
}
|