## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ This is a maintenance fix that removes the warnings in our CI runs to make it more readable. Refer: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8386795331> > Commit: `2b1bfe7ed505ad9ba67bfe9211d50ebabb8ea0ce` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8386795331&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated DockerHub login action across multiple workflows to version 3 for enhanced security and performance. - Updated various GitHub Actions to newer versions in different workflows for improved compatibility and performance. - Modified file path pattern in a workflow step for consistency and clarity. - Updated setup actions for Java to version 4 for better Java environment setup. - Updated setup-node version in a workflow and adjusted comments for Cypress test results. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
342 lines
17 KiB
YAML
342 lines
17 KiB
YAML
name: Client Build
|
||
|
||
on:
|
||
workflow_call:
|
||
inputs:
|
||
pr:
|
||
description: "This is the PR number in case the workflow is being called in a pull request"
|
||
required: false
|
||
type: number
|
||
skip-tests:
|
||
description: "This is a boolean value in case the workflow is being called in build deploy-preview"
|
||
required: false
|
||
type: string
|
||
default: "false"
|
||
check-test-files:
|
||
description: "This is a boolean value in case the workflow is being called in build deploy-preview"
|
||
required: false
|
||
type: string
|
||
default: "false"
|
||
branch:
|
||
description: "This is the branch to be used for the build."
|
||
required: false
|
||
type: string
|
||
ads-compliant-check:
|
||
description: "This is a boolean value in case the workflow is being called in build deploy-preview"
|
||
required: false
|
||
type: string
|
||
default: "true"
|
||
|
||
# Change the working directory for all the jobs in this workflow
|
||
defaults:
|
||
run:
|
||
working-directory: app/client
|
||
|
||
jobs:
|
||
client-build:
|
||
runs-on: ${{ vars.RUNNER_CLIENT_BUILD }}
|
||
# Only run this workflow for internally triggered events
|
||
if: |
|
||
github.event.pull_request.head.repo.full_name == github.repository ||
|
||
github.event_name == 'push' ||
|
||
github.event_name == 'workflow_dispatch' ||
|
||
github.event_name == 'repository_dispatch' ||
|
||
github.event_name == 'schedule'
|
||
defaults:
|
||
run:
|
||
working-directory: app/client
|
||
shell: bash
|
||
|
||
steps:
|
||
# The checkout steps MUST happen first because the default directory is set according to the code base.
|
||
# GitHub Action expects all future commands to be executed in the code directory. Hence, we need to check out
|
||
# the code before doing anything else.
|
||
|
||
# Check out merge commit with the base branch in case this workflow is invoked via pull request
|
||
- name: Checkout the merged commit from PR and base branch
|
||
if: inputs.pr != 0
|
||
uses: actions/checkout@v4
|
||
with:
|
||
fetch-tags: true
|
||
ref: refs/pull/${{ inputs.pr }}/merge
|
||
|
||
# Check out the specified branch in case this workflow is called by another workflow
|
||
- name: Checkout the specified branch
|
||
if: inputs.pr == 0 && inputs.branch != ''
|
||
uses: actions/checkout@v4
|
||
with:
|
||
fetch-tags: true
|
||
ref: ${{ inputs.branch }}
|
||
|
||
# Checkout the code in the current branch in case the workflow is called because of a branch push event
|
||
- name: Checkout the head commit of the branch
|
||
if: inputs.pr == 0 && inputs.branch == ''
|
||
uses: actions/checkout@v4
|
||
with:
|
||
fetch-tags: true
|
||
- name: Get changed files in the client folder
|
||
id: changed-files-specific
|
||
uses: tj-actions/changed-files@v41
|
||
with:
|
||
files: "app/client/**"
|
||
|
||
- name: Run step if any file(s) in the client folder change
|
||
if: steps.changed-files-specific.outputs.any_changed == 'true'
|
||
env:
|
||
ALL_CHANGED_FILES: ${{ steps.changed-files-specific.outputs.all_changed_files }}
|
||
run: |
|
||
echo "One or more files in the server folder has changed."
|
||
echo "List all the files that have changed: $ALL_CHANGED_FILES"
|
||
|
||
# get all the files changes in the cypress/e2e folder
|
||
- name: Get added files in cypress/e2e folder
|
||
if: inputs.pr != 0 && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
id: files
|
||
uses: umani/changed-files@v4.1.0
|
||
with:
|
||
repo-token: ${{ secrets.APPSMITH_CI_TEST_PAT }}
|
||
pattern: "app/client/cypress/e2e/.*"
|
||
pr-number: ${{ inputs.pr }}
|
||
|
||
# Check all the newly added files are in ts
|
||
- name: Check the newly added files are written in ts
|
||
if: inputs.check-test-files == 'true' && inputs.pr != 0 && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
id: check_files
|
||
run: |
|
||
files=(${{steps.files.outputs.files_created}})
|
||
non_ts_files=()
|
||
for file in "${files[@]}"; do
|
||
if [[ $file != *.ts ]]; then
|
||
non_ts_files+=("<li>$file")
|
||
fi
|
||
done
|
||
echo "non_ts_files=${non_ts_files[@]}" >> $GITHUB_OUTPUT
|
||
echo "non_ts_files_count=${#non_ts_files[@]}" >> $GITHUB_OUTPUT
|
||
|
||
# Comment in PR if test files are not written in ts and fail the workflow
|
||
- name: Comment in PR if test files are not written in ts
|
||
if: steps.check_files.outputs.non_ts_files_count != 0 && inputs.check-test-files == 'true' && inputs.pr != 0 && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
uses: peter-evans/create-or-update-comment@v3
|
||
with:
|
||
issue-number: ${{ inputs.pr }}
|
||
body: |
|
||
<b>Below new test files are written in js 🔴 </b>
|
||
<b>Expected format ts. Please fix and retrigger ok-to-test:</b>
|
||
<ol>${{ steps.check_files.outputs.non_ts_files }}</ol>
|
||
- if: steps.check_files.outputs.non_ts_files_count != 0 && inputs.check-test-files == 'true' && inputs.pr != 0 && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
run: exit 1
|
||
|
||
- name: Get all the added or changed files in client/src folder
|
||
if: inputs.ads-compliant-check == 'true' && inputs.pr != 0 && github.pull_request.base.ref == 'release' && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
id: client_files
|
||
uses: umani/changed-files@v4.1.0
|
||
with:
|
||
repo-token: ${{ secrets.APPSMITH_CI_TEST_PAT }}
|
||
pattern: "app/client/src/.*"
|
||
pr-number: ${{ inputs.pr }}
|
||
|
||
# Check all the newly added files are in ts
|
||
- name: ADS compliant check
|
||
if: inputs.ads-compliant-check == 'true' && inputs.pr != 0 && github.pull_request.base.ref == 'release' && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
id: ads_check
|
||
run: |
|
||
comment_files=""
|
||
files=(${{steps.client_files.outputs.files_created}}${{steps.client_files.outputs.files_updated}})
|
||
for file in "${files[@]}"; do
|
||
while IFS= read -r line; do
|
||
if echo "$line" | grep -q -E '(color|Color).*#|border.*#|(color|Color).*"'; then
|
||
comment_files+=("$file")
|
||
break
|
||
fi
|
||
done < ${file#app/client/}
|
||
done
|
||
unique_files=$(echo "${comment_files[@]}" | sort -u | sed '/^[[:space:]]*$/d' | sed 's/ / <li>/g')
|
||
echo "ads_non_compliant_files=$unique_files" >> $GITHUB_OUTPUT
|
||
echo "ads_non_compliant_count=${#unique_files[@]}" >> $GITHUB_OUTPUT
|
||
|
||
# Comment in PR if test files are not written in ts and fail the workflow
|
||
- name: Comment in PR if test files are not written in ts
|
||
if: steps.ads_check.outputs.ads_non_compliant_count != 0 && inputs.ads-compliant-check == 'true' && inputs.pr != 0 && github.pull_request.base.ref == 'release' && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
uses: peter-evans/create-or-update-comment@v3
|
||
with:
|
||
issue-number: ${{ inputs.pr }}
|
||
body: |
|
||
<b> 🔴 Below files are not compliant with ADS. Please fix and re-trigger ok-to-test </b>
|
||
<ol>${{steps.ads_check.outputs.ads_non_compliant_files}}</ol>
|
||
- if: steps.ads_check.outputs.ads_non_compliant_count != 0 && inputs.ads-compliant-check == 'true' && inputs.pr != 0 && github.pull_request.base.ref == 'release'
|
||
run: exit 1
|
||
|
||
- name: Install postgres-dependencies
|
||
run: |
|
||
sudo apt update -y
|
||
sudo apt install -y postgresql-client
|
||
|
||
# Create a run record exactly at the time of merge to release to
|
||
# ensure we compare run details with code at this point
|
||
- name: Create Perf Meta
|
||
if: steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'
|
||
continue-on-error: true
|
||
run: |
|
||
PGPASSWORD='${{secrets.APPSMITH_PERFORMANCE_DB_PASSWORD}}' psql -h '${{secrets.APPSMITH_PERFORMANCE_DB_HOST}}' \
|
||
-U aforce_admin -d perf-infra -c \
|
||
"INSERT INTO public.run_meta (repo, gh_run_id, gh_run_attempt, is_active)
|
||
VALUES ('${{github.repository}}', '${{github.run_id}}', '${{github.run_attempt}}', FALSE)"
|
||
|
||
# In case this is second attempt try restoring status of the prior attempt from cache
|
||
- name: Restore the previous run result
|
||
if: steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'
|
||
uses: actions/cache@v4
|
||
with:
|
||
path: |
|
||
~/run_result
|
||
key: ${{ github.run_id }}-${{ github.job }}-client
|
||
|
||
# Fetch prior run result
|
||
- name: Get the previous run result
|
||
if: steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'
|
||
id: run_result
|
||
run: cat ~/run_result 2>/dev/null || echo 'default'
|
||
|
||
# In case of prior failure run the job
|
||
- if: steps.run_result.outputs.run_result != 'success' && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
run: echo "I'm alive!" && exit 0
|
||
|
||
- name: Use Node.js
|
||
if: steps.run_result.outputs.run_result != 'success' && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
uses: actions/setup-node@v4
|
||
with:
|
||
node-version-file: app/client/package.json
|
||
|
||
# actions/setup-node@v4 doesn’t work properly with Yarn 3
|
||
# when the project lives in a subdirectory: https://github.com/actions/setup-node/issues/488
|
||
# Restoring the cache manually instead
|
||
- name: Restore Yarn cache
|
||
if: steps.run_result.outputs.run_result != 'success' && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
uses: actions/cache@v4
|
||
id: cache-dependencies
|
||
with:
|
||
path: |
|
||
app/client/.yarn/cache
|
||
app/client/node_modules/.cache/webpack/
|
||
key: v1-yarn3-${{ hashFiles('app/client/yarn.lock') }}
|
||
|
||
# Install all the dependencies
|
||
- name: Install dependencies
|
||
if: steps.run_result.outputs.run_result != 'success' && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
run: yarn install --immutable
|
||
|
||
# Type checking before starting the build
|
||
- name: Run type check
|
||
if: steps.run_result.outputs.run_result != 'success' && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
run: yarn run check-types
|
||
|
||
- name: Set the build environment based on the branch
|
||
if: steps.run_result.outputs.run_result != 'success' && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
id: vars
|
||
run: |
|
||
set +o pipefail
|
||
echo "REACT_APP_ENVIRONMENT=DEVELOPMENT" >> $GITHUB_OUTPUT
|
||
if [[ "${{github.ref}}" == "refs/heads/master" ]]; then
|
||
echo "REACT_APP_ENVIRONMENT=PRODUCTION" >> $GITHUB_OUTPUT
|
||
fi
|
||
if [[ "${{github.ref}}" == "refs/heads/release" ]]; then
|
||
echo "REACT_APP_ENVIRONMENT=STAGING" >> $GITHUB_OUTPUT
|
||
fi
|
||
|
||
# We burn React environment & the Segment analytics key into the build itself.
|
||
# This is to ensure that we don't need to configure it in each installation
|
||
- name: Create the bundle
|
||
if: steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'
|
||
run: |
|
||
if [[ "${{ github.ref }}" == "refs/heads/master" ]]; then
|
||
export REACT_APP_SEGMENT_CE_KEY="${{ secrets.APPSMITH_SEGMENT_CE_KEY }}"
|
||
else
|
||
export REACT_APP_SEGMENT_CE_KEY="${{ secrets.APPSMITH_SEGMENT_CE_KEY_RELEASE }}"
|
||
fi
|
||
REACT_APP_ENVIRONMENT=${{steps.vars.outputs.REACT_APP_ENVIRONMENT}} \
|
||
REACT_APP_FUSIONCHARTS_LICENSE_KEY=${{ secrets.APPSMITH_FUSIONCHARTS_LICENSE_KEY }} \
|
||
SENTRY_AUTH_TOKEN=${{ secrets.SENTRY_AUTH_TOKEN }} \
|
||
REACT_APP_VERSION_EDITION="Community" \
|
||
yarn build
|
||
|
||
# Saving the cache to use it in subsequent runs
|
||
- name: Save Yarn cache
|
||
uses: actions/cache/save@v4
|
||
if: steps.cache-dependencies.outputs.cache-hit != 'true' && (steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
with:
|
||
path: |
|
||
app/client/.yarn/cache
|
||
app/client/node_modules/.cache/webpack/
|
||
key: v1-yarn3-${{ hashFiles('app/client/yarn.lock') }}
|
||
|
||
# Restore the previous built bundle if present. If not push the newly built into the cache
|
||
- name: Restore the previous bundle
|
||
if: steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'
|
||
uses: actions/cache@v4
|
||
with:
|
||
path: |
|
||
app/client/build/
|
||
key: ${{ github.run_id }}-${{ github.job }}-client
|
||
|
||
- name: Pack the client build directory
|
||
if: steps.changed-files-specific.outputs.any_changed == 'true' || github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule'
|
||
run: |
|
||
tar -cvf ./build.tar -C build .
|
||
|
||
- name: Fetch client build from cache
|
||
if: steps.changed-files-specific.outputs.any_changed == 'false' && success() && github.event_name != 'push' && github.event_name != 'workflow_dispatch' && github.event_name != 'schedule'
|
||
env:
|
||
cachetoken: ${{ secrets.CACHETOKEN }}
|
||
reponame: ${{ github.event.repository.name }}
|
||
gituser: ${{ secrets.CACHE_GIT_USER }}
|
||
gituseremail: ${{ secrets.CACHE_GIT_EMAIL }}
|
||
run: |
|
||
mkdir cacherepo
|
||
cd ./cacherepo
|
||
git lfs install
|
||
git config --global user.email "$gituseremail"
|
||
git config --global user.name "$gituser"
|
||
git clone https://$cachetoken@github.com/appsmithorg/cibuildcache.git
|
||
git lfs install
|
||
if [ "$reponame" = "appsmith" ]; then export repodir="CE"; fi
|
||
if [ "$reponame" = "appsmith-ee" ]; then export repodir="EE"; fi
|
||
cd cibuildcache/$repodir/release/client
|
||
git lfs pull ./build.tar
|
||
mv ./build.tar ../../../../../build.tar
|
||
|
||
# Upload the build artifact so that it can be used by the test & deploy job in the workflow
|
||
- name: Upload react build bundle
|
||
uses: actions/upload-artifact@v3
|
||
with:
|
||
name: client-build
|
||
path: app/client/build.tar
|
||
|
||
- name: Put release build in cache
|
||
if: success() && github.ref == 'refs/heads/release' && (github.event_name == 'push' || github.event_name == 'workflow_dispatch' || github.event_name == 'schedule')
|
||
env:
|
||
cachetoken: ${{ secrets.CACHETOKEN }}
|
||
reponame: ${{ github.event.repository.name }}
|
||
gituser: ${{ secrets.CACHE_GIT_USER }}
|
||
gituseremail: ${{ secrets.CACHE_GIT_EMAIL }}
|
||
run: |
|
||
pwd
|
||
mkdir cacherepo
|
||
cd ./cacherepo
|
||
git config --global user.email "$gituseremail"
|
||
git config --global user.name "$gituser"
|
||
git clone https://$cachetoken@github.com/appsmithorg/cibuildcache.git
|
||
git lfs install
|
||
cd cibuildcache/
|
||
if [ "$reponame" = "appsmith" ]; then export repodir="CE"; fi
|
||
if [ "$reponame" = "appsmith-ee" ]; then export repodir="EE"; fi
|
||
cd $repodir/release/client
|
||
cp ../../../../../build.tar ./
|
||
git lfs track "build.tar"
|
||
git add build.tar
|
||
git commit -m "Update Latest build.tar"
|
||
git push
|
||
|
||
# Set status = success
|
||
- name: Save the status of the run
|
||
run: echo "run_result=success" >> $GITHUB_OUTPUT > ~/run_result
|