PromucFlow_constructor/contributions/CodeContributionsGuidelines.md
Nikhil Nandagopal cf650f8ad0
Feature/hacktoberfest (#841)
* Update IssuesReport.md

* Update IssuesReport.md

* Create ClientSetup.md

* Update ClientSetup.md

* Update ClientSetup.md

* Update ClientSetup.md

* Create ServerSetup.md

* Update ClientSetup.md

* Create CodeContributionsGuidelines.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CodeContributionsGuidelines.md

* Update IssuesReport.md

* Update CodeContributionsGuidelines.md

* Update CONTRIBUTING.md

* Update IssuesReport.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update ClientSetup.md

* Update ClientSetup.md

Co-authored-by: Nikhil <nikhil@users.noreply.github.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-09-30 23:23:10 +05:30

2.0 KiB

Contributing code

Before raising a pull request, ensure you have raised a corresponding issue and discussed a possible solution with a maintainer. This gives your pull request the highest chance of getting merged quickly.

🔎 Code and copy reviews

All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult GitHub Help for more information on using pull requests.

🍴 Git Workflow

We use Github Flow, so all code changes happen through pull requests.

  1. Fork the repo and create a new branch from the release branch.
  2. Branches are named as fix/fix-name or feature/feature-name
  3. Please add tests for your changes. Client-side changes require Cypress/Jest tests while server-side changes require JUnit tests.
  4. Once you are confident in your code changes, create a pull request in your fork to the release branch in the appsmithorg/appsmith base repository.
  5. If you've changed any APIs, please call this out in the pull request and ensure backward compatibility.
  6. Link the issue of the base repository in your Pull request description. Guide
  7. When you raise a pull request, we automatically run tests on our CI. Please ensure that all the tests are passing for your code change. We will not be able to accept your change if the test suite doesn't pass.

🏡 Setup for local development

🧪 Running tests

Client

  1. In order to run the Cypress integration tests, run:
  cd app/client
  yarn run test
  1. In order to run the Jest unit tests, run:
  cd app/client
  yarn run test:unit

Server

  1. Ensure that you have Redis running on your local system.

  2. Run the command to execute tests

  cd app/server
  mvn clean package