## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
84 lines
2.3 KiB
TypeScript
84 lines
2.3 KiB
TypeScript
import React from "react";
|
|
import PageLoadingBar from "pages/common/PageLoadingBar";
|
|
import { retryPromise } from "utils/AppsmithUtils";
|
|
import { connect } from "react-redux";
|
|
import type { InitEditorActionPayload } from "actions/initActions";
|
|
import { initEditorAction } from "actions/initActions";
|
|
import { getSearchQuery } from "../../utils/helpers";
|
|
import { GIT_BRANCH_QUERY_KEY } from "../../constants/routes";
|
|
import { APP_MODE } from "../../entities/App";
|
|
import type { RouteComponentProps } from "react-router";
|
|
import { ReduxActionTypes } from "ee/constants/ReduxActionConstants";
|
|
|
|
type Props = {
|
|
initEditor: (payload: InitEditorActionPayload) => void;
|
|
clearCache: () => void;
|
|
} & RouteComponentProps<{ basePageId: string }>;
|
|
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
class EditorLoader extends React.PureComponent<Props, { Page: any }> {
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
constructor(props: any) {
|
|
super(props);
|
|
|
|
this.state = {
|
|
Page: null,
|
|
};
|
|
}
|
|
|
|
initialise() {
|
|
const {
|
|
initEditor,
|
|
location: { search },
|
|
match: { params },
|
|
} = this.props;
|
|
const branch = getSearchQuery(search, GIT_BRANCH_QUERY_KEY);
|
|
|
|
const { basePageId } = params;
|
|
|
|
if (basePageId) {
|
|
initEditor({
|
|
basePageId,
|
|
branch,
|
|
mode: APP_MODE.EDIT,
|
|
});
|
|
}
|
|
}
|
|
|
|
componentDidMount() {
|
|
this.initialise();
|
|
retryPromise(
|
|
async () => import(/* webpackChunkName: "editor" */ "./index"),
|
|
).then((module) => {
|
|
this.setState({ Page: module.default });
|
|
});
|
|
}
|
|
|
|
componentWillUnmount() {
|
|
const { clearCache } = this.props;
|
|
|
|
clearCache();
|
|
}
|
|
render() {
|
|
const { Page } = this.state;
|
|
|
|
return Page ? <Page {...this.props} /> : <PageLoadingBar />;
|
|
}
|
|
}
|
|
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const mapDispatchToProps = (dispatch: any) => {
|
|
return {
|
|
initEditor: (payload: InitEditorActionPayload) =>
|
|
dispatch(initEditorAction(payload)),
|
|
clearCache: () => {
|
|
dispatch({ type: ReduxActionTypes.CLEAR_CACHE });
|
|
},
|
|
};
|
|
};
|
|
|
|
export default connect(null, mapDispatchToProps)(EditorLoader);
|