## Description Earlier we were executing the google.api script quiet early during page load for every route. We have now initiated as lazily as possible at the datasource editor component level. #### PR fixes following issue(s) Fixes #30656 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced dynamic loading of the Google API script to enhance application configuration flexibility. - **Refactor** - Removed static Google APIs JavaScript library loading from `index.html`. - Enhanced `DatasourcesSagas` with new Google API execution logic. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
34 lines
924 B
TypeScript
34 lines
924 B
TypeScript
import { isAirgapped } from "@appsmith/utils/airgapHelpers";
|
|
|
|
async function loadScript(src: string) {
|
|
return new Promise(function (resolve, reject) {
|
|
const s = document.createElement("script");
|
|
s.src = src;
|
|
s.onload = resolve;
|
|
s.onerror = reject;
|
|
s.crossOrigin = "anonymous";
|
|
s.id = "googleapis";
|
|
const headElement = document.getElementsByTagName("head")[0];
|
|
headElement && headElement.appendChild(s);
|
|
});
|
|
}
|
|
|
|
export const executeGoogleApi = async () => {
|
|
const airGapped = isAirgapped();
|
|
// if the googleAPIsLoaded is already loaded, do not load it again.
|
|
if (airGapped || (window as any).googleAPIsLoaded) {
|
|
return;
|
|
}
|
|
const gapiLoaded = () => {
|
|
(window as any).googleAPIsLoaded = true;
|
|
};
|
|
const onError = () => {
|
|
(window as any).googleAPIsLoaded = false;
|
|
};
|
|
|
|
await loadScript("https://apis.google.com/js/api.js").then(
|
|
gapiLoaded,
|
|
onError,
|
|
);
|
|
};
|