PromucFlow_constructor/deploy
Shrikant Sharat Kandula caf1d3f95c
chore: Auto-fix invalid custom domain (#29550)
Defining custom domain as `https://example.com/` is invalid.

It should be just the domain, just `example.com`. But turns out a lot of
our users have the incorrect configuration, and our previous stack of
NGINX+Certbot was able to ignore this and serve without HTTPS. This PR
brings that behaviour back.


## Test performed

Have Appsmith running on an EC2 instance, and a domain `correct.com`
with an A-record pointed to this EC2 instance.

In the instance, we run Appsmith with `APPSMITH_CUSTOM_DOMAIN` set to
`wrong.com`. Caddy will obviously fail to provision the cert, and so we
expect it to accept connections on just HTTP.

So hitting `curl -i http://correct.com` produced a 200 with the HTML
response, and not a 308 with a redirect. Before the changes from this
PR, the same curl command produced a 308 with a redirect to
`https://correct.com`, which fails with a certificate error.

Next up, we run Appsmith with `APPSMITH_CUSTOM_DOMAIN` set to
`correct.com`. Caddy will succeed in provisioning a cert, and so we
expect HTTP URLs to be redirected to HTTPS.

So hitting `curl -i http://correct.com` produces a 308 redirect to
`http://correct.com` which then works fine, since Caddy now has the cert
for the domain.
2023-12-13 13:45:04 +05:30
..
ansible fix: issue with ansible deployment (#19974) 2023-01-25 10:45:04 +05:30
aws
aws_ami fix: Change watchtower to latest (#20001) 2023-02-02 06:27:35 +05:30
digital_ocean Packer script to build AWS and DigitalOcean images (#16617) 2022-09-14 11:03:02 +05:30
docker chore: Auto-fix invalid custom domain (#29550) 2023-12-13 13:45:04 +05:30
helm fix appsmith-ce helm chart (#28523) 2023-10-31 16:57:06 +05:30
heroku chore: Replaced versioned URLs with new ones (#27798) 2023-10-05 12:07:59 +05:30
packer Packer script to build AWS and DigitalOcean images (#16617) 2022-09-14 11:03:02 +05:30