PromucFlow_constructor/app/client/src
Vemparala Surya Vamsi c8943509a0
chore: improved performance of getUnevaluatedDataTree (#37189)
## Description
Refactored getUnevaluatedDataTree selector to be more resilient to state
changes thereby reselect cache gets triggered less often. Identified an
action which was firing the selectors unnecessarily, fixed that as well.
For our customer during page load it used to take about 800ms
cumulatively, it has now dropped to about 160ms by about 80%. This is
also an impactful selector which cumulatively takes about 50,000 seconds
for all our client systems per week, hence we focussed our optimisation
here

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11658078700>
> Commit: 557172d47b2232800355e1dc78c921d9cb56c725
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11658078700&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 04 Nov 2024 06:00:06 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Bug Fixes**
- Improved state management by preventing unnecessary updates to loading
entities, enhancing app performance.

- **Refactor**
- Updated the `loadingEntitiesReducer` to include an equality check for
loading entities before state updates.
- Enhanced date handling capabilities in the DatePicker widget tests and
commands.
- Restructured the `DataTreeFactory` class for improved modularity and
clarity in data tree creation.
- Simplified selector functions for better readability and
maintainability in data tree selectors.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-11-04 16:03:03 +05:30
..
actions chore: Add Rename context menu (#37116) 2024-10-31 17:25:04 +05:30
api chore: Distributed tracing for client (#37101) 2024-10-29 11:25:43 +05:30
assets chore: Update JS Editor Run designs (#36998) 2024-10-23 06:47:20 +00:00
ce chore: improved performance of getUnevaluatedDataTree (#37189) 2024-11-04 16:03:03 +05:30
components chore: Add Rename context menu (#37116) 2024-10-31 17:25:04 +05:30
constants chore: Split library side pane for adding package control section (#36926) 2024-10-22 10:48:03 +05:30
Datasource/components chore: reconnect ds detached from datasource editor part 1 (#35907) 2024-09-02 11:26:34 +05:30
ee chore: Split library side pane for adding package control section (#36926) 2024-10-22 10:48:03 +05:30
enterprise fix: change appsmith alias (#35349) 2024-08-06 17:52:22 +03:00
entities chore: improved performance of getUnevaluatedDataTree (#37189) 2024-11-04 16:03:03 +05:30
globalStyles fix: Sync EE items into CE (#34373) 2024-06-24 09:36:38 +00:00
icons chore:delete unused files (#36368) 2024-09-19 16:01:03 +03:00
IDE chore: Add Rename context menu (#37116) 2024-10-31 17:25:04 +05:30
layoutSystems chore: chat widget polish fixes (#37124) 2024-10-29 16:21:54 +05:30
mockResponses ci: Add lint check to the build step (#21442) 2023-03-20 22:50:44 +05:30
mocks chore: delete unused code (#36461) 2024-09-23 13:52:00 +03:00
modules/ui-builder/ui/wds chore: chat widget polish fixes (#37124) 2024-10-29 16:21:54 +05:30
navigation fix: API Body format focus retention (#37150) 2024-11-01 11:24:49 +05:30
pages chore: decouple editor components (#37102) 2024-11-04 15:32:30 +05:30
PluginActionEditor fix: API Body format focus retention (#37150) 2024-11-01 11:24:49 +05:30
plugins/Linting chore: add telemetry for current linter (#36417) 2024-09-20 11:59:08 +08:00
polyfills chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
reducers chore: improved performance of getUnevaluatedDataTree (#37189) 2024-11-04 16:03:03 +05:30
reflow chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
sagas chore: improved performance of getUnevaluatedDataTree (#37189) 2024-11-04 16:03:03 +05:30
selectors chore: improved performance of getUnevaluatedDataTree (#37189) 2024-11-04 16:03:03 +05:30
templates
theme chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
UITelemetry chore: Distributed tracing for client (#37101) 2024-10-29 11:25:43 +05:30
usagePulse chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
utils chore: Editable name refactor (#37069) 2024-10-28 15:02:58 +05:30
WidgetProvider chore: chore: add SVGR to appsmith-icon package, add processing for custom icons, update date-fns (#37115) 2024-10-28 14:55:42 +03:00
WidgetQueryGenerators chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
widgets fix(#16584): filterTableData source of truth (#36849) 2024-10-30 17:33:01 +05:30
workers fix: resolve redundant JSObject action saving (#36958) 2024-10-24 11:27:41 +05:30
App.css
AppErrorBoundry.tsx chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
config.d.ts fix: change appsmith alias (#35349) 2024-08-06 17:52:22 +03:00
Globals.d.ts fix: Sync EE items into CE (#34373) 2024-06-24 09:36:38 +00:00
index.css chore: Remove google fonts imported from googleapis (#35392) 2024-08-07 08:49:04 +05:30
index.tsx chore: heartbeat code removed (#36837) 2024-10-15 13:31:22 +05:30
LandingScreen.tsx chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
preload-route-chunks.ts chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
react-app-env.d.ts
RouteChangeListener.tsx chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
serviceWorker.ts chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
store.ts chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00
wdyr.ts chore: add blank line eslint rule (#36369) 2024-09-18 19:35:28 +03:00