PromucFlow_constructor/app/client/src/components/editorComponents
arunvjn d1f1a19b66
fix: UI issues with code editor (#23332)
## Description
https://github.com/appsmithorg/appsmith/pull/22652 introduced new styles
to code in Appsmith. Along with it was some unintentional changes.
Bundle optimization
[PR](https://github.com/appsmithorg/appsmith/pull/21667) introduced,
CodeEditorFallback component which incorrectly renders borders and
causes UI to flicker. It also broke styles of lint message popover. This
PR fixes these issues.

Code changes
- Added 6px padding to code editor lines
- Use class variables instead of ref
- Removed border for JSEditor's CodeEditorFallback component
- Fixes lint message style
>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
https://www.notion.so/appsmith/Visual-changes-to-code-in-Appsmith-8bb530c60ee844e5b44adec039bf9280#d99e8450f022439f845b5a0d7deb1d3f
>
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Bug fix (non-breaking change which fixes an issue)
>
>
>
## Testing
>
#### How Has This Been Tested?
- [x] Manual
>
>
#### Test Plan
Visual checks to test for changes as per
[this](https://www.notion.so/appsmith/Error-tooltip-for-data-fields-on-property-pane-Needs-design-810cdc489c3e4168a0b1b348730ac98c?utm_content=810cdc48-9c3e-4168-a0b1-b348730ac98c&utm_campaign=TGA9SH07N&n=slack&n=slack_link_unfurl&pvs=6)
Notion doc
>
#### Issues raised during DP testing
None
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: Ravi Kumar Prasad <ravi@appsmith.com>
2023-05-17 10:32:42 +05:30
..
ActionCreator fix: show evaluated value for action selector fields (#23099) 2023-05-16 22:29:11 +05:30
ActionRightPane feat: util to serve images locally or via remote url (#22080) 2023-04-10 12:32:31 +05:30
CodeEditor fix: UI issues with code editor (#23332) 2023-05-17 10:32:42 +05:30
Debugger chore: Bottom bar code split (#23323) 2023-05-16 14:37:53 +07:00
form feat: Autocompletion hints in sql editor (#22827) 2023-05-12 11:26:53 +05:30
GlobalSearch chore: Action create option order: Maintain parity with EE repo (#23162) 2023-05-11 14:53:16 +05:30
HighlightedCode chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
LazyCodeEditor fix: UI issues with code editor (#23332) 2023-05-17 10:32:42 +05:30
LightningMenu chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WidgetNameComponent feat: Add widget responsiveness and conversion algorithm (#21386) 2023-04-07 09:51:35 -04:00
WidgetQueryGeneratorForm chore: Removing feature flag for app level invites (#22650) 2023-04-26 12:48:16 +05:30
ActionNameEditor.tsx feat: util to serve images locally or via remote url (#22080) 2023-04-10 12:32:31 +05:30
ApiResponseView.tsx fix: UI issues with code editor (#23332) 2023-05-17 10:32:42 +05:30
AutoResizeTextArea.test.tsx feat: multi-line input and auto-resize textarea (#19141) 2023-01-17 18:46:35 +05:30
AutoResizeTextArea.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
BetaCard.tsx
Button.tsx feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
Checkbox.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
CloseEditor.tsx chore: Add new navigation scenarios for route change event (#21682) 2023-03-30 11:03:29 +05:30
ContextDropdown.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
Divider.tsx
DraggableComponent.test.tsx feat: Improved App Navigation (#19312) 2023-03-23 17:11:58 +05:30
DraggableComponent.tsx feat: Improved App Navigation (#19312) 2023-03-23 17:11:58 +05:30
DragLayerComponent.test.tsx chore: Remove collaboration pointers from the Editor (#19660) 2023-03-15 22:10:06 +05:30
DragLayerComponent.tsx feat: Auto height instant update (#19082) 2023-02-03 11:17:40 +05:30
DropdownComponent.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
DropTargetComponent.tsx feat: Expand auto height implementation to handle auto height use cases. (#22974) 2023-05-11 10:15:14 +05:30
DropTargetUtils.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
EditableText.tsx feat: Renamed design system package (#19854) 2023-01-23 09:20:47 +05:30
EditorContextProvider.test.tsx feat: Expand auto height implementation to handle auto height use cases. (#22974) 2023-05-11 10:15:14 +05:30
EditorContextProvider.tsx feat: Expand auto height implementation to handle auto height use cases. (#22974) 2023-05-11 10:15:14 +05:30
EntityBottomTabs.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
EntityNameComponent.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
ErrorBoundry.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
ErrorTooltip.tsx feat: Automatic height updates for widgets based on contents (Auto Height) (#18341) 2022-11-23 15:18:23 +05:30
Form.tsx
FormLabel.tsx
FormRow.tsx
HelperTooltip.tsx
InputComponent.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
JSResponseView.tsx fix: Open state of bottom bar (#23077) 2023-05-12 11:17:26 +05:30
LetterIcon.tsx
LoadingOverlayScreen.tsx
NavBarItem.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
PageLoader.tsx
PaneWrapper.tsx
PropertyPaneSidebar.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
ReadOnlyEditor.tsx fix: UI issues with code editor (#23332) 2023-05-17 10:32:42 +05:30
RequestView.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
ResizableComponent.tsx chore: Removing feature flag for app level invites (#22650) 2023-04-26 12:48:16 +05:30
ResizableUtils.test.ts feat: Automatic height updates for widgets based on contents (Auto Height) (#18341) 2022-11-23 15:18:23 +05:30
ResizableUtils.ts feat: Add widget responsiveness and conversion algorithm (#21386) 2023-04-07 09:51:35 -04:00
ResizeStyledComponents.tsx feat: Add widget responsiveness and conversion algorithm (#21386) 2023-04-07 09:51:35 -04:00
SelectComponent.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
Sidebar.tsx feat: signposting stickiness (#22088) 2023-05-02 15:22:05 +05:30
SnipeableComponent.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
Spinner.tsx
StoreAsDatasource.tsx feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
Tooltip.tsx
utils.test.ts
utils.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WidgetComponentBoundary.tsx fix: clickable containers in the List widget (#21987) 2023-04-14 14:55:44 +01:00