PromucFlow_constructor/app/client/src
Hetu Nandu c2dbebf9b7
fix: Do not set widget ancestry if selection happens via canvas (#22069)
## Description

Implemented in #21317. A problem arose where if a widget that exists
inside a tabs widget is setting the default value of the tab in order to
navigate change the tab, it would fail to switch it because the selected
widget logic takes over.

> Improve selected widget visibility by skipping feature when selection
happens via a canvas click

Fixes #22070


Media



https://user-images.githubusercontent.com/12022471/229714138-55f89cda-3c27-4953-91c0-46f5a9834adf.mov




## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-10 12:55:14 +05:30
..
actions fix: Do not set widget ancestry if selection happens via canvas (#22069) 2023-04-10 12:55:14 +05:30
api feat: util to serve images locally or via remote url (#22080) 2023-04-10 12:32:31 +05:30
assets feat: Action selector (#21582) 2023-04-06 22:19:12 +05:30
ce fix: Do not set widget ancestry if selection happens via canvas (#22069) 2023-04-10 12:55:14 +05:30
components fix: Do not set widget ancestry if selection happens via canvas (#22069) 2023-04-10 12:55:14 +05:30
constants feat: util to serve images locally or via remote url (#22080) 2023-04-10 12:32:31 +05:30
ee feat: util to serve images locally or via remote url (#22080) 2023-04-10 12:32:31 +05:30
enterprise chore: Format files to match prettier rules and exclude third-party files (#21586) 2023-03-20 19:04:31 +05:30
entities feat: Added file id mapping in datasource config (#21699) 2023-04-04 13:43:49 +05:30
globalStyles chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
icons chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
mockComponentProps
mockResponses ci: Add lint check to the build step (#21442) 2023-03-20 22:50:44 +05:30
mocks chore: integrate msw to browser to mock api requests (#15965) 2022-08-17 12:01:55 +05:30
navigation fix: Do not set widget ancestry if selection happens via canvas (#22069) 2023-04-10 12:55:14 +05:30
normalizers chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
pages feat: util to serve images locally or via remote url (#22080) 2023-04-10 12:32:31 +05:30
polyfills chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
reducers fix: Do not set widget ancestry if selection happens via canvas (#22069) 2023-04-10 12:55:14 +05:30
reflow chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
resizable feat: Add widget responsiveness and conversion algorithm (#21386) 2023-04-07 09:51:35 -04:00
sagas fix: Do not set widget ancestry if selection happens via canvas (#22069) 2023-04-10 12:55:14 +05:30
selectors fix: Do not set widget ancestry if selection happens via canvas (#22069) 2023-04-10 12:55:14 +05:30
templates
theme chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
transformers chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
usagePulse fix: fix usage pulse fallback (#21735) 2023-04-06 17:51:58 +05:30
utils fix: Do not set widget ancestry if selection happens via canvas (#22069) 2023-04-10 12:55:14 +05:30
widgets feat: util to serve images locally or via remote url (#22080) 2023-04-10 12:32:31 +05:30
workers fix: Changes to fix ee jest test (#22188) 2023-04-10 11:13:31 +05:30
.gitignore
App.css
AppErrorBoundry.tsx
config.d.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
Globals.d.ts feat: Auto layout appsmith editor and mobile responsiveness (#21151) 2023-03-04 12:55:54 +05:30
index.css feat: Action selector (#21582) 2023-04-06 22:19:12 +05:30
index.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
LandingScreen.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
react-app-env.d.ts
RouteBuilder.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
RouteChangeListener.tsx chore: Add new navigation scenarios for route change event (#21682) 2023-03-30 11:03:29 +05:30
RouteParamsMiddleware.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
serviceWorker.js fix: Log ChunkLoadError on Sentry only after 3rd failure (#18196) 2022-11-18 09:33:23 +00:00
store.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
wdyr.ts