## Description - Add encoding for Api key secret value before storing it as query param to avoid incorrect parsing. - Remove hardcoded "api_key" check to mask headers. - Used standard URL parsing APIs instead of custom - Added unit test to cover the case Fixes https://github.com/appsmithorg/appsmith/issues/33742 flaws in the implementation [here](https://github.com/appsmithorg/appsmith/pull/33528) ## Automation /test datasource ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/9256269257> > Commit: 602b0f599ff17ac7530b25336eae6a0523c90977 > Workflow: `PR Automation test suite` > Tags: `@tag.Datasource` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No |
||
|---|---|---|
| .. | ||
| main | ||
| test/java/com/external/plugins | ||