PromucFlow_constructor/app/client/cypress/support/Pages
Rahul Barwal c096bb5e5b
test: Failing cypress tests due to removal of empty canvas prompts (#34037)
## Description
This PR fixes impact of
https://github.com/appsmithorg/appsmith/pull/33993

Refactors visual regression tests to use PageList for page generation;
remove obsolete empty canvas spec and related selectors.
* Removed unncessary:
`cypress/e2e/Regression/ClientSide/OtherUIFeatures/EmptyCanvas_spec.js`
* Fixes
`cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js`

**RCA:**
The [original PR](https://github.com/appsmithorg/appsmith/pull/33993)
catered to removal of empty canvas prompts and visual tests were not run
leading to subsequent failures in the CI for EmptyCanvas_spec &
AppPageLayout_spec.

This PR caters to failing visual tests, while running `@tag.Visual` we
noticed that other (unrelated) visual specs started failing. These new
failures fail in local as well.
Whereas they were not failing in TBP or `@tag.All` runs and `@tag.All`
succeeded for this PR as well.

Fixes https://github.com/appsmithorg/appsmith/issues/33874
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9413838227>
> Commit: b6d7f6012e0f2c3f3e030ad280354cc3d22f57ad
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9413838227&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->
















## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Updated method call for adding a new page in visual regression tests
to improve code clarity and maintainability.

- **Chores**
  - Removed unused locators and declarations to clean up the codebase.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2024-06-07 15:24:07 +05:30
..
Anvil feat: Preliminary set of test cases and test utils for Anvil DnD and Space distribution. (#33827) 2024-05-30 12:46:56 +05:30
AppSettings test: Cypress | Replace static waits from Helpers + Flaky fixes (#29856) 2024-01-05 11:42:03 +05:30
IDE test: Updating leftpane class in cypress to fix pageaccess_spec on EE (#33844) 2024-05-30 16:46:43 +05:30
AdminSettings.ts chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862) 2024-03-21 15:37:13 +05:30
AggregateHelper.ts test: PartialExport_Widgets_spec - updated test validation logic (#33371) 2024-05-21 18:40:02 +05:30
ApiPage.ts chore: remove cypress hardcoded strings and waits (#33513) 2024-05-16 13:38:43 +05:30
AssertHelper.ts test: Cypress | Downgrade Cypress to 13.5.1 (#31011) 2024-02-09 13:33:30 +05:30
AutoLayout.ts fix: missing methods in gitexecutorceimpl (#32614) 2024-04-12 06:21:01 +05:30
Canvas.ts chore: cypress test for canvas view mode (#32354) 2024-04-03 14:52:09 +05:30
CommunityTemplates.ts fix: default port numbers for the datasources (#32901) 2024-04-30 13:15:11 +05:30
DataSources.ts feat: Preliminary set of test cases and test utils for Anvil DnD and Space distribution. (#33827) 2024-05-30 12:46:56 +05:30
DebuggerHelper.ts feat: Collapsible Bottom View (#33441) 2024-05-22 19:43:07 +05:30
DeployModeHelper.ts test: Cypress | Replacing some external api's with TED + Flaky fix (#31118) 2024-02-23 13:18:01 +05:30
EditorNavigation.ts fix: action selector create flow (#32326) 2024-04-05 11:28:47 +05:30
EntityExplorer.ts feat: New tab ui changes (#33228) 2024-05-15 19:15:49 +05:30
FakerHelper.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
GitSync.ts chore: unified way of writing messages in cypress (#33659) 2024-05-27 15:34:45 +02:00
GSheetHelper.ts test: Gsheet Automation (#25255) 2023-07-26 18:56:24 +05:30
HomePage.ts test: Failing cypress tests due to removal of empty canvas prompts (#34037) 2024-06-07 15:24:07 +05:30
InviteModal.ts test: Cypress | SetWidget property validations + CI Stabilize (#28626) 2023-11-06 15:18:00 +05:30
JSEditor.ts chore: remove cypress hardcoded strings and waits (#33513) 2024-05-16 13:38:43 +05:30
LibraryInstaller.ts chore: App Sidebar testing (#28479) 2023-11-15 08:01:12 +05:30
MultipleEnvironments.ts chore: Multiple Env code split for 1-click (#27275) 2023-09-29 16:16:24 +05:30
Onboarding.ts chore: removed onboarding flags ab_create_new_apps_enabled , ab_start_with_data_default_enabled (#31384) 2024-03-15 11:13:14 +05:30
PageList.ts test: GitSyncedApps_spec - multiple IA changes (#33257) 2024-05-10 15:34:40 +05:30
PartialImportExport.ts chore: unified way of writing messages in cypress (#33659) 2024-05-27 15:34:45 +02:00
PeekOverlay.ts feat: peek overlay nested properties + perf improvements (#23414) 2023-05-26 17:12:10 +05:30
PropertyPane.ts fix: number slider + category slider color spec fails (#32935) 2024-04-29 11:31:46 +05:30
Table.ts fix: default port numbers for the datasources (#32901) 2024-04-30 13:15:11 +05:30
Tabs.ts test: added tests for Tabs (#27765) 2023-10-05 09:34:41 +05:30
Templates.ts chore: Add spec for create new app from template (#31311) 2024-02-28 14:42:35 +05:30
WDSWidgets.ts fix: Anvil toggleable widgets not working when native callbacks are used for AnvilFlexComponent (#31125) 2024-02-15 11:00:57 +05:30