## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
202 lines
5.5 KiB
TypeScript
202 lines
5.5 KiB
TypeScript
import React from "react";
|
|
import type { ControlProps } from "./BaseControl";
|
|
import BaseControl from "./BaseControl";
|
|
import { generateReactKey } from "utils/generators";
|
|
import orderBy from "lodash/orderBy";
|
|
import isString from "lodash/isString";
|
|
import isUndefined from "lodash/isUndefined";
|
|
import { DraggableListControl } from "pages/Editor/PropertyPane/DraggableListControl";
|
|
import { DraggableListCard } from "components/propertyControls/DraggableListCard";
|
|
import { Button } from "@appsmith/ads";
|
|
|
|
interface State {
|
|
focusedIndex: number | null;
|
|
}
|
|
|
|
class MenuItemsControl extends BaseControl<ControlProps, State> {
|
|
constructor(props: ControlProps) {
|
|
super(props);
|
|
|
|
this.state = {
|
|
focusedIndex: null,
|
|
};
|
|
}
|
|
|
|
componentDidUpdate(prevProps: ControlProps): void {
|
|
//on adding a new column last column should get focused
|
|
if (
|
|
prevProps.propertyValue &&
|
|
this.props.propertyValue &&
|
|
Object.keys(prevProps.propertyValue).length + 1 ===
|
|
Object.keys(this.props.propertyValue).length
|
|
) {
|
|
this.updateFocus(Object.keys(this.props.propertyValue).length - 1, true);
|
|
}
|
|
}
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
updateItems = (items: Array<Record<string, any>>) => {
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const menuItems = items.reduce((obj: any, each: any, index) => {
|
|
obj[each.id] = {
|
|
...each,
|
|
index,
|
|
};
|
|
|
|
return obj;
|
|
}, {});
|
|
|
|
this.updateProperty(this.props.propertyName, menuItems);
|
|
};
|
|
|
|
getMenuItems = () => {
|
|
const menuItems: Array<{
|
|
id: string;
|
|
label: string;
|
|
isDisabled: boolean;
|
|
isVisible: boolean;
|
|
widgetId: string;
|
|
}> =
|
|
isString(this.props.propertyValue) ||
|
|
isUndefined(this.props.propertyValue)
|
|
? []
|
|
: Object.values(this.props.propertyValue);
|
|
|
|
return orderBy(menuItems, ["index"], ["asc"]);
|
|
};
|
|
|
|
onEdit = (index: number) => {
|
|
const menuItems = this.getMenuItems();
|
|
const targetMenuItem = menuItems[index];
|
|
|
|
this.props.openNextPanel({
|
|
index,
|
|
...targetMenuItem,
|
|
propPaneId: this.props.widgetProperties.widgetId,
|
|
});
|
|
};
|
|
|
|
render() {
|
|
return (
|
|
<div className="flex flex-col gap-1">
|
|
<DraggableListControl
|
|
deleteOption={this.deleteOption}
|
|
fixedHeight={370}
|
|
focusedIndex={this.state.focusedIndex}
|
|
itemHeight={45}
|
|
items={this.getMenuItems()}
|
|
onEdit={this.onEdit}
|
|
propertyPath={this.props.dataTreePath}
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
renderComponent={(props: any) =>
|
|
DraggableListCard({
|
|
...props,
|
|
isDelete: true,
|
|
placeholder: "Menu item label",
|
|
})
|
|
}
|
|
toggleVisibility={this.toggleVisibility}
|
|
updateFocus={this.updateFocus}
|
|
updateItems={this.updateItems}
|
|
updateOption={this.updateOption}
|
|
/>
|
|
|
|
<Button
|
|
className="self-end t--add-menu-item-btn"
|
|
kind="tertiary"
|
|
onClick={this.addOption}
|
|
startIcon="plus"
|
|
>
|
|
Add new menu item
|
|
</Button>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
toggleVisibility = (index: number) => {
|
|
const menuItems = this.getMenuItems();
|
|
const isVisible = menuItems[index].isVisible === true ? false : true;
|
|
const updatedMenuItems = menuItems.map((item, itemIndex) => {
|
|
if (index === itemIndex) {
|
|
return {
|
|
...item,
|
|
isVisible: isVisible,
|
|
};
|
|
}
|
|
|
|
return item;
|
|
});
|
|
|
|
this.updateProperty(this.props.propertyName, updatedMenuItems);
|
|
};
|
|
|
|
deleteOption = (index: number) => {
|
|
const menuItemsArray = this.getMenuItems();
|
|
|
|
if (menuItemsArray.length === 1) return;
|
|
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const updatedArray = menuItemsArray.filter((eachItem: any, i: number) => {
|
|
return i !== index;
|
|
});
|
|
const updatedObj = updatedArray.reduce(
|
|
// TODO: Fix this the next time the file is edited
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(obj: any, each: any, index: number) => {
|
|
obj[each.id] = {
|
|
...each,
|
|
index,
|
|
};
|
|
|
|
return obj;
|
|
},
|
|
{},
|
|
);
|
|
|
|
this.updateProperty(this.props.propertyName, updatedObj);
|
|
};
|
|
|
|
updateOption = (index: number, updatedLabel: string) => {
|
|
const menuItemsArray = this.getMenuItems();
|
|
const itemId = menuItemsArray[index].id;
|
|
|
|
this.updateProperty(
|
|
`${this.props.propertyName}.${itemId}.label`,
|
|
updatedLabel,
|
|
);
|
|
};
|
|
|
|
addOption = () => {
|
|
let menuItems = this.props.propertyValue || [];
|
|
const menuItemsArray = this.getMenuItems();
|
|
const newMenuItemId = generateReactKey({ prefix: "menuItem" });
|
|
|
|
menuItems = {
|
|
...menuItems,
|
|
[newMenuItemId]: {
|
|
id: newMenuItemId,
|
|
index: menuItemsArray.length,
|
|
label: "Menu Item",
|
|
widgetId: generateReactKey(),
|
|
isDisabled: false,
|
|
isVisible: true,
|
|
},
|
|
};
|
|
|
|
this.updateProperty(this.props.propertyName, menuItems);
|
|
};
|
|
|
|
updateFocus = (index: number, isFocused: boolean) => {
|
|
this.setState({ focusedIndex: isFocused ? index : null });
|
|
};
|
|
|
|
static getControlType() {
|
|
return "MENU_ITEMS";
|
|
}
|
|
}
|
|
|
|
export default MenuItemsControl;
|