## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>
302 lines
10 KiB
TypeScript
302 lines
10 KiB
TypeScript
import React from "react";
|
|
import "@testing-library/jest-dom";
|
|
import {
|
|
render,
|
|
screen,
|
|
waitFor,
|
|
waitForElementToBeRemoved,
|
|
} from "@testing-library/react";
|
|
import IconSelectControl from "./IconSelectControl";
|
|
import userEvent from "@testing-library/user-event";
|
|
import { noop } from "lodash";
|
|
import { EditorTheme } from "components/editorComponents/CodeEditor/EditorConfig";
|
|
|
|
const requiredParams = {
|
|
evaluatedValue: undefined,
|
|
deleteProperties: noop,
|
|
widgetProperties: undefined,
|
|
parentPropertyName: "",
|
|
parentPropertyValue: undefined,
|
|
additionalDynamicData: {},
|
|
label: "",
|
|
openNextPanel: noop,
|
|
onPropertyChange: noop,
|
|
theme: EditorTheme.LIGHT,
|
|
propertyName: "iconName",
|
|
controlType: "",
|
|
isBindProperty: false,
|
|
isTriggerProperty: false,
|
|
};
|
|
|
|
const waitForParamsForSearchFocus = {
|
|
timeout: 3000,
|
|
};
|
|
|
|
describe("<IconSelectControl /> - Keyboard navigation", () => {
|
|
const getTestComponent = (
|
|
onPropertyChange: (
|
|
propertyName: string,
|
|
propertyValue: string,
|
|
isUpdatedViaKeyboard?: boolean,
|
|
) => void = noop,
|
|
) => (
|
|
<IconSelectControl
|
|
{...requiredParams}
|
|
onPropertyChange={onPropertyChange}
|
|
/>
|
|
);
|
|
|
|
it("Pressing tab should focus the component", async () => {
|
|
render(getTestComponent());
|
|
await userEvent.tab();
|
|
expect(screen.getByRole("button")).toHaveFocus();
|
|
});
|
|
|
|
it.each(["{Enter}", " ", "{ArrowDown}", "{ArrowUp}"])(
|
|
"Pressing '%s' should open the icon selector",
|
|
async (key) => {
|
|
render(getTestComponent());
|
|
await userEvent.tab();
|
|
expect(screen.queryByRole("list")).toBeNull();
|
|
await userEvent.keyboard(key);
|
|
expect(screen.getByRole("list")).toBeInTheDocument();
|
|
|
|
// Makes sure search bar is having focus
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
},
|
|
);
|
|
|
|
it("Pressing '{Escape}' should close the icon selector", async () => {
|
|
render(getTestComponent());
|
|
await userEvent.tab();
|
|
expect(screen.queryByRole("list")).toBeNull();
|
|
await userEvent.keyboard("{Enter}");
|
|
expect(screen.getByRole("list")).toBeInTheDocument();
|
|
await userEvent.keyboard("{Escape}");
|
|
await waitForElementToBeRemoved(screen.queryByRole("list"));
|
|
});
|
|
|
|
it("Pressing '{ArrowDown}' while search is in focus should remove the focus", async () => {
|
|
render(getTestComponent());
|
|
await userEvent.tab();
|
|
await userEvent.keyboard("{Enter}");
|
|
expect(screen.getByRole("list")).toBeInTheDocument();
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
expect(screen.getByRole("textbox")).not.toHaveFocus();
|
|
});
|
|
|
|
it("Pressing '{Shift} + {ArrowUp}' while search is not in focus should focus search box", async () => {
|
|
render(getTestComponent());
|
|
await userEvent.tab();
|
|
await userEvent.keyboard("{Enter}");
|
|
expect(screen.getByRole("list")).toBeInTheDocument();
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
expect(screen.getByRole("textbox")).not.toHaveFocus();
|
|
await userEvent.keyboard("{Shift}{ArrowUp}");
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
});
|
|
|
|
/*
|
|
Icon Arrangement
|
|
|
|
(none) add add-column-left add-column-right
|
|
add-row-bottom add-row-top add-to-artifact add-to-folder
|
|
airplane align-center align-justify align-left
|
|
*/
|
|
it("Pressing '{ArrowDown}' should navigate the icon selection downwards", async () => {
|
|
render(getTestComponent());
|
|
await userEvent.tab();
|
|
await userEvent.keyboard("{Enter}");
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
// used to shift the focus from search
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
});
|
|
|
|
it("Pressing '{ArrowUp}' should navigate the icon selection upwards", async () => {
|
|
render(getTestComponent());
|
|
await userEvent.tab();
|
|
await userEvent.keyboard("{Enter}");
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
// used to shift the focus from search
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
|
|
await userEvent.keyboard("{ArrowUp}");
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
});
|
|
|
|
it("Pressing '{ArrowRight}' should navigate the icon selection towards right", async () => {
|
|
render(getTestComponent());
|
|
await userEvent.tab();
|
|
await userEvent.keyboard("{Enter}");
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
// used to shift the focus from search
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
|
|
await userEvent.keyboard("{ArrowRight}");
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
});
|
|
|
|
it("Pressing '{ArrowLeft}' should navigate the icon selection towards left", async () => {
|
|
render(getTestComponent());
|
|
await userEvent.tab();
|
|
await userEvent.keyboard("{Enter}");
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
// used to shift the focus from search
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
|
|
await userEvent.keyboard("{ArrowRight}");
|
|
await userEvent.keyboard("{ArrowRight}");
|
|
await userEvent.keyboard("{ArrowRight}");
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
|
|
await userEvent.keyboard("{ArrowLeft}");
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
});
|
|
|
|
it("Pressing '{Enter}' or ' ' should select the icon", async () => {
|
|
const handleOnSelect = jest.fn();
|
|
|
|
render(getTestComponent(handleOnSelect));
|
|
await userEvent.tab();
|
|
expect(screen.getByRole("button")?.textContent).toEqual("(none)caret-down");
|
|
await userEvent.keyboard("{Enter}");
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
// used to shift the focus from search
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
await userEvent.keyboard("{ArrowRight}");
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
await userEvent.keyboard(" ");
|
|
expect(handleOnSelect).toHaveBeenCalledTimes(1);
|
|
expect(handleOnSelect.mock.calls[0]).toMatchSnapshot();
|
|
await waitForElementToBeRemoved(screen.queryByRole("list"));
|
|
|
|
await userEvent.keyboard("{Enter}");
|
|
expect(screen.getByRole("list")).toBeInTheDocument();
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
await userEvent.keyboard("{ArrowDown}");
|
|
await userEvent.keyboard("{ArrowRight}");
|
|
await userEvent.keyboard(" ");
|
|
expect(handleOnSelect).toHaveBeenCalledTimes(2);
|
|
expect(handleOnSelect.mock.calls[1]).toMatchSnapshot();
|
|
});
|
|
});
|
|
|
|
const config = { ...requiredParams };
|
|
|
|
describe("IconSelectControl.canDisplayValue", () => {
|
|
it("Should return true when a proper icon name is passed", () => {
|
|
expect(IconSelectControl.canDisplayValueInUI(config, "add")).toEqual(true);
|
|
expect(IconSelectControl.canDisplayValueInUI(config, "airplane")).toEqual(
|
|
true,
|
|
);
|
|
});
|
|
|
|
it("Should return false when a non-alowed icon value is passed", () => {
|
|
expect(IconSelectControl.canDisplayValueInUI(config, "macbook")).toEqual(
|
|
false,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("<IconSelectControl /> - (none) icon", () => {
|
|
const getTestComponent = (hideNoneIcon?: boolean) => (
|
|
<IconSelectControl {...requiredParams} hideNoneIcon={hideNoneIcon} />
|
|
);
|
|
|
|
it("Should display (none) icon when hideNoneIcon property is false/undefined", async () => {
|
|
render(getTestComponent());
|
|
await userEvent.tab();
|
|
expect(screen.getByRole("button")?.textContent).toEqual("(none)caret-down");
|
|
await userEvent.keyboard("{Enter}");
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
|
|
// Check if the (none) icon is in the list
|
|
expect(screen.getByText("(none)", { selector: "div" })).toBeInTheDocument();
|
|
});
|
|
|
|
it("Should not display (none) icon when hideNoneIcon property is true", async () => {
|
|
render(getTestComponent(true));
|
|
await userEvent.tab();
|
|
expect(screen.getByRole("button")?.textContent).toEqual("(none)caret-down");
|
|
await userEvent.keyboard("{Enter}");
|
|
await waitFor(() => {
|
|
expect(screen.getByRole("textbox")).toHaveFocus();
|
|
}, waitForParamsForSearchFocus);
|
|
expect(
|
|
document.querySelector("a.bp3-active")?.children[0].classList,
|
|
).toMatchSnapshot();
|
|
|
|
// Check if the (none) icon is in the list
|
|
expect(screen.queryByText("(none)", { selector: "div" })).toBeNull();
|
|
});
|
|
});
|