PromucFlow_constructor/app/client/cypress
Abhinav Jha 74fcf269af
fix: widget borders does not reflect widget height (#23694)
## Description

#### Reported issue
If a widget - not a container like widget - has a minimum height of 4
rows, and the auto height is enabled for the widget, the widget borders
signify a much smaller height. Example - checkbox widget.

#### Results of RCA
This was happening because, we set `height: auto` for all widgets, when
it should have been done only for container like widgets. The
`height:auto` in the resizable library, allowed the library to show the
widget borders completely hugging the contents of the widget, when it
should have been restricted to a minimum of 4 rows (40px). This is
because, in the platform, the minimum height any widget can have is 4
rows (40px) in Fixed mode (not auto layout mode)


#### Solution:
We exclude widgets which do not have `isCanvas` property set to `true`
from setting the `autoHeight` flag. This allows the library to set the
provided height instead of hugging contents.

#### PR fixes following issue(s)
Fixes #23690 

#### Type of change
- Bug fix (non-breaking change which fixes an issue)
## Testing
#### How Has This Been Tested?
- [x] Manual
- [x] Cypress
2023-06-28 14:11:45 +05:30
..
e2e fix: widget borders does not reflect widget height (#23694) 2023-06-28 14:11:45 +05:30
fixtures fix: widget borders does not reflect widget height (#23694) 2023-06-28 14:11:45 +05:30
locators feat: signposting update (#24389) 2023-06-22 18:35:01 +05:30
manual_TestSuite test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
patches
plugins feat: ci changes & cypress tests with cypress tags (#22989) 2023-05-12 00:15:06 +05:30
snapshots feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
support fix: adding theme and settings to git status messages (#24045) 2023-06-28 10:03:19 +05:30
.eslintrc.json chore: add eslint rules for skipped tests (#24164) 2023-06-07 11:37:46 +03:00
apply-patches.js chore: move local dependency to packages (#23395) 2023-05-22 15:55:46 +03:00
cypress-docker-compose.yml ci: Add lint check to the build step (#21442) 2023-03-20 22:50:44 +05:30
index.ts test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
init-mssql-dump-for-test.sql test: Cypress - Automated basic tests for MsSQL DS (#21446) 2023-03-16 23:58:32 +05:30
init-mysql-dump-for-test.sql feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
init-pg-dump-for-test.sql
limited-tests.txt test: Auto Layout uncovered test cases (#23626) 2023-05-29 14:28:02 +05:30
package.json test: Cypress | Cy 12 upgrade + Flaky fixes (#23852) 2023-06-15 18:51:11 +05:30
setup-test-ci.sh ci: run fat container docker inside perf tests and update setup-perf-test workflow to use localhost for accessing dev environment (#20280) 2023-02-07 15:56:41 +05:30
setup-test.sh test: Cypress migration to TED GITEA (#18799) 2023-02-15 01:12:45 +05:30
test.sh feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
tsconfig.json chore: move local dependency to packages (#23395) 2023-05-22 15:55:46 +03:00
xataadd.sh
xatadel.sh