* reference replacement widget in the deprecation warning message * updated import path for messages * adding test case for validating deprecated widget COnfig
124 lines
4.3 KiB
TypeScript
124 lines
4.3 KiB
TypeScript
import {
|
|
PropertyPaneConfig,
|
|
PropertyPaneControlConfig,
|
|
ValidationConfig,
|
|
} from "constants/PropertyControlConstants";
|
|
import { ValidationTypes } from "constants/WidgetValidation";
|
|
import WidgetFactory from "utils/WidgetFactory";
|
|
import { ALL_WIDGETS_AND_CONFIG, registerWidgets } from "./WidgetRegistry";
|
|
|
|
function validatePropertyPaneConfig(config: PropertyPaneConfig[]) {
|
|
for (const sectionOrControlConfig of config) {
|
|
if (sectionOrControlConfig.children) {
|
|
for (const propertyControlConfig of sectionOrControlConfig.children) {
|
|
const propertyControlValidation = validatePropertyControl(
|
|
propertyControlConfig,
|
|
);
|
|
if (propertyControlValidation !== true)
|
|
return propertyControlValidation;
|
|
}
|
|
}
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
function validatePropertyControl(config: PropertyPaneConfig): boolean | string {
|
|
const _config = config as PropertyPaneControlConfig;
|
|
const controls = ["INPUT_TEXT"];
|
|
|
|
if (
|
|
(_config.isJSConvertible || controls.includes(_config.controlType)) &&
|
|
!_config.isTriggerProperty
|
|
) {
|
|
if (!_config.isBindProperty)
|
|
return `${
|
|
_config.propertyName
|
|
}: isBindProperty should be true if isJSConvertible is true or when control type is [${controls.join(
|
|
" | ",
|
|
)}]`;
|
|
if (!_config.validation)
|
|
return `${
|
|
_config.propertyName
|
|
}: validation should be defined if isJSConvertible is true or when control type is [${controls.join(
|
|
" | ",
|
|
)}]`;
|
|
}
|
|
|
|
if (_config.validation !== undefined) {
|
|
const res = validateValidationStructure(_config.validation);
|
|
if (res !== true) return `${_config.propertyName}: ${res}`;
|
|
}
|
|
if (_config.children) {
|
|
for (const child of _config.children) {
|
|
const res = validatePropertyControl(child);
|
|
if (res !== true) return `${_config.propertyName}.${res}`;
|
|
}
|
|
}
|
|
if (_config.panelConfig) {
|
|
const res = validatePropertyPaneConfig(_config.panelConfig.children);
|
|
if (res !== true) return `${_config.propertyName}.${res}`;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
function validateValidationStructure(
|
|
config: ValidationConfig,
|
|
): boolean | string {
|
|
if (
|
|
config.type === ValidationTypes.FUNCTION &&
|
|
config.params &&
|
|
config.params.fn
|
|
) {
|
|
if (!config.params.expected)
|
|
return `For a ${ValidationTypes.FUNCTION} type validation, expected type and example are mandatory`;
|
|
}
|
|
return true;
|
|
}
|
|
const isNotFloat = (n: any) => {
|
|
return Number(n) === n && n % 1 === 0;
|
|
};
|
|
describe("Tests all widget's propertyPane config", () => {
|
|
beforeAll(() => {
|
|
registerWidgets();
|
|
});
|
|
ALL_WIDGETS_AND_CONFIG.forEach((widgetAndConfig) => {
|
|
const [widget, config]: any = widgetAndConfig;
|
|
it(`Checks ${widget.getWidgetType()}'s propertyPaneConfig`, () => {
|
|
const propertyPaneConfig = widget.getPropertyPaneConfig();
|
|
const validatedPropertyPaneConfig = validatePropertyPaneConfig(
|
|
propertyPaneConfig,
|
|
);
|
|
expect(validatedPropertyPaneConfig).toStrictEqual(true);
|
|
});
|
|
it(`Check if ${widget.getWidgetType()}'s dimensions are always integers`, () => {
|
|
expect(isNotFloat(config.defaults.rows)).toBe(true);
|
|
expect(isNotFloat(config.defaults.columns)).toBe(true);
|
|
});
|
|
if (config.isDeprecated && config.replacement !== undefined) {
|
|
it(`Check if ${widget.getWidgetType()}'s deprecation config has a proper replacement Widget`, () => {
|
|
const widgetType = widget.getWidgetType();
|
|
const replacementWidgetType = config.replacement;
|
|
const replacementWidgetConfig = WidgetFactory.widgetConfigMap.get(
|
|
replacementWidgetType,
|
|
);
|
|
if (replacementWidgetConfig === undefined) {
|
|
fail(
|
|
`${widgetType}'s replacement widget ${replacementWidgetType} does not resolve to an actual widget Config`,
|
|
);
|
|
}
|
|
if (replacementWidgetConfig?.isDeprecated) {
|
|
fail(
|
|
`${widgetType}'s replacement widget ${replacementWidgetType} itself is deprecated. Cannot have a deprecated widget as a replacement for another deprecated widget`,
|
|
);
|
|
}
|
|
if (replacementWidgetConfig?.hideCard) {
|
|
fail(
|
|
`${widgetType}'s replacement widget ${replacementWidgetType} should be available in the entity Explorer`,
|
|
);
|
|
}
|
|
});
|
|
}
|
|
});
|
|
});
|