## Description To add debugger error for import path for module instance on EE, this PR enables code to be extended on EE #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated import paths and references for `ENTITY_TYPE` to `EntityTypeValue` across various components and utilities for improved code consistency. - Reorganized import statements related to `AppsmithConsole` utilities and constants to enhance code maintainability. - Adjusted usage of enums and types, specifically for entity and platform error handling, to align with updated import paths. - **New Features** - Introduced utility functions for handling entity types and platform errors in AppsmithConsole, including new constants and error retrieval functions. - Added a new enum value `MISSING_MODULE` to better categorize log types in debugging scenarios. - **Bug Fixes** - Implemented changes to error logging and handling mechanisms, including the addition of new case handling for `LOG_TYPE.MISSING_MODULE` in debugger logs, to improve the debugging experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
66 lines
2.2 KiB
TypeScript
66 lines
2.2 KiB
TypeScript
import { Severity } from "entities/AppsmithConsole";
|
|
import LOG_TYPE from "entities/AppsmithConsole/logtype";
|
|
import type { DataTree } from "entities/DataTree/dataTreeTypes";
|
|
import { isEmpty } from "lodash";
|
|
import AppsmithConsole from "utils/AppsmithConsole";
|
|
import { getEntityNameAndPropertyPath } from "@appsmith/workers/Evaluation/evaluationUtils";
|
|
import type { LintErrorsStore } from "reducers/lintingReducers/lintErrorsReducers";
|
|
import isLintErrorLoggingEnabledForEntity from "@appsmith/plugins/Linting/utils/isLintErrorLoggingEnabledForEntity";
|
|
import getEntityUniqueIdForLogs from "@appsmith/plugins/Linting/utils/getEntityUniqueIdForLogs";
|
|
import type { ENTITY_TYPE } from "@appsmith/entities/AppsmithConsole/utils";
|
|
|
|
// We currently only log lint errors in JSObjects
|
|
export function* logLatestLintPropertyErrors({
|
|
dataTree,
|
|
errors,
|
|
}: {
|
|
errors: LintErrorsStore;
|
|
dataTree: DataTree;
|
|
}) {
|
|
const errorsToAdd = [];
|
|
const errorsToRemove = [];
|
|
|
|
for (const path of Object.keys(errors)) {
|
|
const { entityName, propertyPath } = getEntityNameAndPropertyPath(path);
|
|
const entity = dataTree[entityName];
|
|
// only log lint errors in JSObjects
|
|
if (!isLintErrorLoggingEnabledForEntity(entity)) continue;
|
|
// only log lint errors (not warnings)
|
|
const lintErrorsInPath = errors[path].filter(
|
|
(error) => error.severity === Severity.ERROR,
|
|
);
|
|
const lintErrorMessagesInPath = lintErrorsInPath.map((error) => ({
|
|
type: error.errorType,
|
|
message: error.errorMessage,
|
|
lineNumber: error.line,
|
|
character: error.ch,
|
|
}));
|
|
const uniqueId = getEntityUniqueIdForLogs(entity);
|
|
|
|
const debuggerKey = uniqueId + propertyPath + "-lint";
|
|
|
|
if (isEmpty(lintErrorsInPath)) {
|
|
errorsToRemove.push({ id: debuggerKey });
|
|
continue;
|
|
}
|
|
|
|
errorsToAdd.push({
|
|
payload: {
|
|
id: debuggerKey,
|
|
logType: LOG_TYPE.LINT_ERROR,
|
|
text: "LINT ERROR",
|
|
messages: lintErrorMessagesInPath,
|
|
source: {
|
|
id: uniqueId,
|
|
name: entityName,
|
|
type: entity.ENTITY_TYPE as ENTITY_TYPE,
|
|
propertyPath,
|
|
},
|
|
},
|
|
});
|
|
}
|
|
|
|
AppsmithConsole.addErrors(errorsToAdd);
|
|
AppsmithConsole.deleteErrors(errorsToRemove);
|
|
}
|