PromucFlow_constructor/app/client/src/widgets/TableWidget/widget/propertyUtils.ts
Pawan Kumar 809a633306
feat: App Theming (#9714)
* fix style bugs

* fix select styles

* test: fix font size issue for cypress tests

* incorporate ashit feedback

* test: addresed review comments for cypress tests

* add analytics events

* height issue in view mode

* incorporate code review feedbacks

* incorporate code review feedbacks

* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations

* feat: Makes shadow and radius controls keyboard accessible (#11547)

* makes shadow and radius controls keyboard accessible

* removes unused imports

* moves options out of render method

* fix: changed the misnomer background property name to the relevant property name

* fix: border radius issue for the map widget

* address qa bugs

* address qa bugs

* fix ux of theming pane when widget is selected

* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget

* fix: added delete icon in the delete theme modal

* address qa bugs

* change checkbox column size in config

* add js convertible to button color

* remove unused imports

* test: fixed jest tests

* fix primary color typo

* fix: migrations for the theming

* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.

* test: updated Dsl migration UT

* address qa bugs

* address qa bugs

* fix: address qa comments

* address qa bugs

* fix:
* migration issue;
* unit test cases;

* fix rating widget scroll issue

* fix youtube video border radius bug

* fix select widget

* fix select widgets styles

* address qa bugs

* merge conflicts

* makes the reset button keyboard accessible (#12134)

* -resolved merge conflicts

* address qa bugs

* fix: labelTextSize migration fixes

* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests

* fix button group widget

* remove unused imports

* fix: fixed the text size migration for the table widget

* refactor: addressed review comments for the table widget theming migration

* fix button group widget

* add init calls for view mode

* json form init theme changes

* fix: added migration for boxShadow, borderRadius and textSizes for table widget

* fix broken fields

* test: fixed unit tests

* wip

* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration

* feat: init json form migration theming

* json form primaryColor -> accentColor

* update table widget

* update table widget

* object field label styling

* fix: migration related to the JSON form

* fix: fixed labelTextSize migration for JSON form nested widgets

* property control nested stylesheet lookup

* JSONForm label styles form array items

* show label for checkbox field array item

* fix button group widget

* wip

* refactor: addressed table widget review comments

* refactor: addressed ashit review comments;
* added childStylesheet for widgets

* feat: Keyboard navigable Color Picker control (#11797)

* Makes ColorPicker keyboard accessible

* seperate out keyboard and mouse interactions

* fix issue with not focusing back to input

* Adds test for Color picker

* chore: added comment for the boxShadow property

* fix:
* added unit test cases for the widget and property utils
* resolved warning messages

* wip

* theme config update

* fix merge conflicts

* refactor: moved theming migration inside the migrations folder

* fix qa bugs

* fix jest test

* fix: unit test cases

* fix table column creation logic

* refactor: addressed review comments for migrations

* fix: Overriding margin and padding for custom render in the dropdown component (#12875)

* * fix for custom render padding and margin in ADS dropdown

* * fix for removing padding from normal render options

* refactor: moved the boxShadow condition to the variable

* fix qa bugs

* fix: migration QA callouts for audio recorder widget

* refactor: added updated comments for boxShadow migration for table widget

* fix theme binfings for JSONForm fields under Object

* fix table widget theming bug

* fix: addressed code review comments

* fix: unit test cases

* fix: qa migration callouts

* fix table widget theming bug

* fix JSONForm currency input dropdown not submit form

* Added new tests - AppThemingSpec

* fix qa bugs

* fix unit test

* fix JSONForm cellBorderWidth to have default value post migration

* fix unit test

* fix qa bugs

* remove unused imports

* fix qa bugs

* fix JSONForm input height issue

* fix qa bugs

* Updating Theming spec

* * dropdown color fixes (#13249)

* fix caching issue
;

* Fixed Theming tests

* fix tests

* fix tab widget tests

* fix: json form children level migration issue

* fix table widget tests

* Updated test

* updated tests

* updated test

* updated tests

* updated tests

* updated pageload

* fix cypress tests

* remove cypress created files

* fix color picker issues

* Failure fixes

* Fixed some more tests

* fix: cypress test failures

* fix tests

* remove consoles

* fix table tests

* fix qa bugs

* updating snapshots for AppPageLayout_spec as per new UI

* fix rating widget bug

* fix qa bugs

* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports

* update constract check algo

* fix color contrast issue

* fix: cypress failure test cases

* update font sizes labels

* fix regression bugs

* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow

* fix: default labelTextSize issue for the Input and Select families

* fix regression bugs

* fix regression bugs

* PassingParams spec - added wait time

* fix: font family default value issue on JS toggle

* fix js toggle issue in text widget

* fix tests

* fix tests

* fix tests

* fix cypress tests

* fix regression bugs

* fix regression bugs

* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget

* fix: failing unit test cases

* fix theming spec

* fix cypress tests

* test: fixed failed cypress test

* incorporate ashit feedback

* fix cypress tests

* fix: addressed review comments

* comment out table cypress test

* fix merge conflicts

* comment out color picker tests

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30

484 lines
14 KiB
TypeScript

import { Alignment } from "@blueprintjs/core";
import { ColumnProperties } from "../component/Constants";
import { TableWidgetProps } from "../constants";
import { Colors } from "constants/Colors";
import { get } from "lodash";
import {
combineDynamicBindings,
getDynamicBindings,
} from "utils/DynamicBindingUtils";
import { IconNames } from "@blueprintjs/icons";
export enum ColumnTypes {
TEXT = "text",
URL = "url",
NUMBER = "number",
IMAGE = "image",
VIDEO = "video",
DATE = "date",
BUTTON = "button",
ICON_BUTTON = "iconButton",
MENU_BUTTON = "menuButton",
}
export function defaultSelectedRowValidation(
value: unknown,
props: TableWidgetProps,
_: any,
) {
if (props) {
if (props.multiRowSelection) {
if (_.isString(value)) {
const trimmed = (value as string).trim();
try {
const parsedArray = JSON.parse(trimmed);
if (Array.isArray(parsedArray)) {
const sanitized = parsedArray.filter((entry) => {
return (
Number.isInteger(parseInt(entry, 10)) &&
parseInt(entry, 10) > -1
);
});
return { isValid: true, parsed: sanitized };
} else {
throw Error("Not a stringified array");
}
} catch (e) {
// If cannot be parsed as an array
const arrayEntries = trimmed.split(",");
const result: number[] = [];
arrayEntries.forEach((entry: string) => {
if (
Number.isInteger(parseInt(entry, 10)) &&
parseInt(entry, 10) > -1
) {
if (!_.isNil(entry)) result.push(parseInt(entry, 10));
}
});
return { isValid: true, parsed: result };
}
}
if (Array.isArray(value)) {
const sanitized = value.filter((entry) => {
return (
Number.isInteger(parseInt(entry, 10)) && parseInt(entry, 10) > -1
);
});
return { isValid: true, parsed: sanitized };
}
if (Number.isInteger(value) && (value as number) > -1) {
return { isValid: true, parsed: [value] };
}
return {
isValid: false,
parsed: [],
message: `This value does not match type: number[]`,
};
} else {
try {
const _value: string = value as string;
if (_value === "") {
return {
isValid: true,
parsed: undefined,
};
}
if (Number.isInteger(parseInt(_value, 10)) && parseInt(_value, 10) > -1)
return { isValid: true, parsed: parseInt(_value, 10) };
return {
isValid: true,
parsed: -1,
};
} catch (e) {
return {
isValid: true,
parsed: -1,
};
}
}
}
return {
isValid: true,
parsed: value,
};
}
export function totalRecordsCountValidation(
value: unknown,
props: TableWidgetProps,
_?: any,
) {
if (_.isNil(value) || value === "") {
return {
isValid: true,
parsed: 0,
message: "",
};
}
if (!Number.isFinite(value) && !_.isString(value)) {
return {
isValid: false,
parsed: 0,
message: "This value must be a number",
};
}
if (_.isString(value) && !/^\d+\.?\d*$/.test(value as string)) {
return {
isValid: false,
parsed: 0,
message: "This value must be a number",
};
}
return {
isValid: true,
parsed: Number(value),
message: "",
};
}
export function uniqueColumnNameValidation(
value: unknown,
props: TableWidgetProps,
_?: any,
) {
const tableColumns = _.map(value, "label");
const duplicates = tableColumns.filter(
(val: string, index: number, arr: string[]) => arr.indexOf(val) !== index,
);
const hasError = !!duplicates.length;
if (value && hasError) {
return {
isValid: false,
parsed: value,
messages: ["Column names should be unique."],
};
}
return {
isValid: true,
parsed: value,
messages: [],
};
}
// A hook to update all column styles when global table styles are updated
export const updateColumnStyles = (
props: TableWidgetProps,
propertyPath: string,
propertyValue: any,
): Array<{ propertyPath: string; propertyValue: any }> | undefined => {
const { primaryColumns, derivedColumns = {} } = props;
const propertiesToUpdate: Array<{
propertyPath: string;
propertyValue: any;
}> = [];
const tokens = propertyPath.split("."); // horizontalAlignment/textStyle
const currentStyleName = tokens[0];
// TODO: Figure out how propertyPaths will work when a nested property control is updating another property
if (primaryColumns && currentStyleName) {
// The style being updated currently
// for each primary column
Object.values(primaryColumns).map((column: ColumnProperties) => {
// Current column property path
const propertyPath = `primaryColumns.${column.id}.${currentStyleName}`;
// Is current column a derived column
const isDerived = primaryColumns[column.id].isDerived;
// If it is a derived column and it exists in derivedColumns
if (isDerived && derivedColumns[column.id]) {
propertiesToUpdate.push({
propertyPath: `derivedColumns.${column.id}.${currentStyleName}`,
propertyValue: propertyValue,
});
}
// Is this a dynamic binding property?
const notADynamicBinding =
!props.dynamicBindingPathList ||
props.dynamicBindingPathList.findIndex(
(item) => item.key === propertyPath,
) === -1;
if (notADynamicBinding) {
propertiesToUpdate.push({
propertyPath: `primaryColumns.${column.id}.${currentStyleName}`,
propertyValue: propertyValue,
});
}
});
if (propertiesToUpdate.length > 0) return propertiesToUpdate;
}
return;
};
// Select default Icon Name if column type is Icon Button
export function updateIconNameHook(
props: TableWidgetProps,
propertyPath: string,
propertyValue: string,
) {
const property = getBasePropertyPath(propertyPath);
let propertiesToUpdate = [{ propertyPath, propertyValue }];
const updateDerivedColumnsHookArr = updateDerivedColumnsHook(
props,
propertyPath,
propertyValue,
);
if (updateDerivedColumnsHookArr) {
propertiesToUpdate = [
...updateDerivedColumnsHookArr,
...propertiesToUpdate,
];
}
if (propertyValue === "iconButton") {
propertiesToUpdate.push({
propertyPath: `${property}.iconName`,
propertyValue: IconNames.ADD,
});
} else {
propertiesToUpdate.push({
propertyPath: `${property}.iconName`,
propertyValue: "",
});
}
return propertiesToUpdate;
}
// Select default Icon Alignment when an icon is chosen
export function updateIconAlignmentHook(
props: TableWidgetProps,
propertyPath: string,
propertyValue: string,
) {
const property = getBasePropertyPath(propertyPath);
const iconAlign = get(props, `${property}.iconAlign`, "");
let propertiesToUpdate = [{ propertyPath, propertyValue }];
const updateDerivedColumnsHookArr = updateDerivedColumnsHook(
props,
propertyPath,
propertyValue,
);
if (updateDerivedColumnsHookArr) {
propertiesToUpdate = [
...updateDerivedColumnsHookArr,
...propertiesToUpdate,
];
}
if (iconAlign) {
propertiesToUpdate.push({
propertyPath: "iconAlign",
propertyValue: Alignment.LEFT,
});
}
return propertiesToUpdate;
}
// A hook for handling property updates when the primaryColumns
// has changed and it is supposed to update the derivedColumns
// For example, when we add a new column or update a derived column's name
// The propertyPath will be of the type `primaryColumns.columnId`
// Handling BindingProperty of derived columns
export const updateDerivedColumnsHook = (
props: TableWidgetProps,
propertyPath: string,
propertyValue: any,
): Array<{ propertyPath: string; propertyValue: any }> | undefined => {
let propertiesToUpdate: Array<{
propertyPath: string;
propertyValue: any;
}> = [];
if (props && propertyValue) {
// If we're adding a column, we need to add it to the `derivedColumns` property as well
if (/^primaryColumns\.\w+$/.test(propertyPath)) {
const newId = propertyValue.id;
if (newId) {
// sets default value for some properties
propertyValue.labelColor = Colors.WHITE;
propertiesToUpdate = [
{
propertyPath: `derivedColumns.${newId}`,
propertyValue,
},
];
}
const oldColumnOrder = props.columnOrder || [];
const newColumnOrder = [...oldColumnOrder, propertyValue.id];
propertiesToUpdate.push({
propertyPath: "columnOrder",
propertyValue: newColumnOrder,
});
}
// If we're updating a columns' name, we need to update the `derivedColumns` property as well.
const regex = /^primaryColumns\.(\w+)\.(.*)$/;
if (regex.test(propertyPath)) {
const matches = propertyPath.match(regex);
if (matches && matches.length === 3) {
// updated to use column keys
const columnId = matches[1];
const columnProperty = matches[2];
const primaryColumn = props.primaryColumns[columnId];
const isDerived = primaryColumn ? primaryColumn.isDerived : false;
const { derivedColumns = {} } = props;
if (isDerived && derivedColumns && derivedColumns[columnId]) {
propertiesToUpdate = [
{
propertyPath: `derivedColumns.${columnId}.${columnProperty}`,
propertyValue: propertyValue,
},
];
}
updateThemeStylesheetsInColumns(
props,
propertyValue,
columnId,
columnProperty,
propertiesToUpdate,
);
}
}
if (propertiesToUpdate.length > 0) return propertiesToUpdate;
}
return;
};
/**
* updates theme stylesheets
*
* @param props
* @param propertyPath
* @param propertyValue
*/
function updateThemeStylesheetsInColumns(
props: TableWidgetProps,
propertyValue: any,
columnId: string,
columnProperty: string,
propertiesToUpdate: Array<{ propertyPath: string; propertyValue: any }>,
) {
if (columnProperty === "columnType") {
const oldColumnType = props.columnType;
const newColumnType = propertyValue;
const propertiesToRemove = Object.keys(
props.childStylesheet[oldColumnType] || {},
);
const propertiesToAdd = Object.keys(
props.childStylesheet[newColumnType] || {},
);
propertiesToRemove.forEach((propertyKey) => {
propertiesToUpdate.push({
propertyPath: `derivedColumns.${columnId}.${propertyKey}`,
propertyValue: undefined,
});
propertiesToUpdate.push({
propertyPath: `primaryColumns.${columnId}.${propertyKey}`,
propertyValue: undefined,
});
});
propertiesToAdd.forEach((propertyKey) => {
const { jsSnippets, stringSegments } = getDynamicBindings(
props.childStylesheet[newColumnType][propertyKey],
);
const js = combineDynamicBindings(jsSnippets, stringSegments);
propertiesToUpdate.push({
propertyPath: `derivedColumns.${columnId}.${propertyKey}`,
propertyValue: `{{${props.widgetName}.sanitizedTableData.map((currentRow) => ( ${js}))}}`,
});
propertiesToUpdate.push({
propertyPath: `primaryColumns.${columnId}.${propertyKey}`,
propertyValue: `{{${props.widgetName}.sanitizedTableData.map((currentRow) => ( ${js}))}}`,
});
});
}
}
// Gets the base property path excluding the current property.
// For example, for `primaryColumns[5].computedValue` it will return
// `primaryColumns[5]`
export const getBasePropertyPath = (
propertyPath: string,
): string | undefined => {
try {
const propertyPathRegex = /^(.*)\.\w+$/g;
const matches = [...propertyPath.matchAll(propertyPathRegex)][0];
if (matches && Array.isArray(matches) && matches.length === 2) {
return matches[1];
}
return;
} catch (e) {
return;
}
};
// Hide column which are not included in the array params
export const hideByColumnType = (
props: TableWidgetProps,
propertyPath: string,
columnTypes: ColumnTypes[],
shouldUsePropertyPath?: boolean,
) => {
const baseProperty = shouldUsePropertyPath
? propertyPath
: getBasePropertyPath(propertyPath);
const columnType = get(props, `${baseProperty}.columnType`, "");
return !columnTypes.includes(columnType);
};
/**
* A function for updateHook to remove the boxShadowColor property post migration.
* @param props
* @param propertyPath
* @param propertyValue
*/
export const removeBoxShadowColorProp = (
props: TableWidgetProps,
propertyPath: string,
) => {
const boxShadowColorPath = replacePropertyName(
propertyPath,
"boxShadowColor",
);
return [
{
propertyPath: boxShadowColorPath,
propertyValue: undefined,
},
];
};
/**
* This function will replace the property present at the end of the propertyPath with the targetPropertyName.
* e.g.
* propertyPath = primaryColumns.action.boxShadow
* Running this function will give the new propertyPath like below:
* propertyPath = primaryColumns.action.boxShadowColor
*
* @param propertyPath The property path inside a widget
* @param targetPropertyName Target property name
* @returns New property path with target property name at the end.
*/
export const replacePropertyName = (
propertyPath: string,
targetPropertyName: string,
) => {
const path = propertyPath.split(".");
path.pop();
return `${path.join(".")}.${targetPropertyName}`;
};