Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
b7c06d6c60
PromucFlow_constructor/app/server
History
sneha122 b7c06d6c60
fix: added configurable connection pool support for mssql (#38818) 
## Description
With current implementation, MSSQL is configured with HikariCP to have
maximum pool size of 10. But this means that if multiple concurrent
users are accessing multiple queries of the same datasource at the same
time, some of the queries might time out due to max pool size of 10. We
have encountered this issue in
https://theappsmith.slack.com/archives/C0341RERY4R/p1736150680663059.
Where 40-50 concurrent users are simultaneously making 20-30 queries to
MSSQL database.


This PR makes this connection pool size configurable from admin settings
for MSSQL as well.


Fixes #https://github.com/appsmithorg/appsmith-ee/issues/5928
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12925650660>
> Commit: ebda9364200b4df19c86b8ec4e68a95d6180f10c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12925650660&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 23 Jan 2025 11:18:35 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
	- Enhanced connection pool configuration for MSSQL plugin
	- Added support for dynamically setting maximum connection pool size

- **Improvements**
	- Increased flexibility in database connection management
	- Implemented configurable connection pool settings

- **Tests**
	- Added mock configuration for testing connection pool settings

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2025-02-01 00:36:19 +05:30
..
.run feat: Databricks plugin (#29746) 2023-12-26 10:04:09 +05:30
appsmith-git chore: Remove deprecated organization from code (#38878) 2025-01-29 12:16:51 +05:30
appsmith-interfaces chore: add etag caching in consolidated api for application view mode (#38873) 2025-01-30 13:54:34 +05:30
appsmith-plugins fix: added configurable connection pool support for mssql (#38818) 2025-02-01 00:36:19 +05:30
appsmith-server chore: convert consolidated api etag to a weak one (#38939) 2025-01-31 16:35:20 +05:30
envs test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
mongo-seed
reactive-caching chore: Upgrading spring to 3.3.3 to resolve vulnerable dependencies (#36266) 2024-10-01 22:12:56 +05:30
scripts chore: Revert "chore: delete redundant files" (#35022) 2024-07-18 16:18:10 +05:30
.gitignore chore: Removed failed tests file from git (#29602) 2023-12-14 13:02:36 +05:30
build.sh test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
buildpack-run.sh
pom.xml chore: Added capability of running ITs on maven (#38354) 2024-12-25 02:08:49 +05:30
Procfile
README.md
system.properties

README.md

Appsmith Server

This is the server-side repository for the Appsmith framework.

For details on setting up your development machine, please refer to this Setup Guide.