b79b160d2f
## Description TLDR: Refines TableWidgetV2 cell editability logic to disable editing when infinite scroll is enabled. <ins>Problem</ins> When people toggled infinite scroll of ON and then moved it back to ON, we were forcibly enabling editing for all columns which was wrong product behavior. <ins>Root cause</ins> The utilities were putting the additables to true in DSL. And editability logic missed a check for the infinite scroll setting, causing cells to remain editable even when infinite scroll was active. <ins>Solution</ins> This PR handles the integration of infinite scroll support into TableWidgetV2 by updating header and cell components to respect the infiniteScrollEnabled prop. Editability is now disabled when infinite scroll is active, ensuring consistent and predictable user experience. Fixes #`Issue Number` _or_ Fixes https://github.com/appsmithorg/appsmith-ee/issues/8144 > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/17998257804> > Commit: 4d0ff9c41d97c55a94a3d261b962faef492f453a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=17998257804&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table` > Spec: > <hr>Thu, 25 Sep 2025 06:15:12 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Laveena Enid <laveena@appsmith.com> Co-authored-by: Aparna Ramachandran <101863839+btsgh@users.noreply.github.com> Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com> Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com> Co-authored-by: Nidhi <nidhi@appsmith.com> Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com> Co-authored-by: “sneha122” <“sneha@appsmith.com”> Co-authored-by: Nidhi <nidhi.nair93@gmail.com> Co-authored-by: Ankita Kinger <ankita@appsmith.com> Co-authored-by: Rudraprasad Das <rudra@appsmith.com> Co-authored-by: Trisha Anand <trisha@appsmith.com> Co-authored-by: Trisha Anand <trisha1990@gmail.com> Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com> Co-authored-by: Hetu Nandu <hetu@appsmith.com> Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com> Co-authored-by: Albin <albin@appsmith.com> Co-authored-by: Manish Kumar <107841575+sondermanish@users.noreply.github.com> Co-authored-by: Pawan Kumar <pawan@appsmith.com> Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com> Co-authored-by: Diljit <diljit@appsmith.com> Co-authored-by: jacquesikot <jacquesikot@gmail.com> Co-authored-by: Goutham Pratapa <goutham@appsmith.com> Co-authored-by: Wyatt Walter <wyattwalter@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Laveena Enid <109572422+laveena-en@users.noreply.github.com> Co-authored-by: Abhinav Jha <abhinav@appsmith.com> |
||
|---|---|---|
| .. | ||
| .husky | ||
| .yarn | ||
| config | ||
| cypress | ||
| docker/templates | ||
| generators | ||
| packages | ||
| public | ||
| scripts | ||
| src | ||
| test | ||
| typings | ||
| .babelrc | ||
| .dockerignore | ||
| .editorconfig | ||
| .eslintrc.base.json | ||
| .eslintrc.js | ||
| .fork-ts-checkerrc | ||
| .gitignore | ||
| .lintstagedrc.json | ||
| .nvmrc | ||
| .prettierignore | ||
| .prettierrc | ||
| .sentryclirc | ||
| .yarnrc.yml | ||
| build.sh | ||
| cypress_ci_custom.config.ts | ||
| cypress_ci_hosted.config.ts | ||
| cypress_ci.config.ts | ||
| cypress-add-tags.js | ||
| cypress.config.ts | ||
| download-assets.js | ||
| jest.config.js | ||
| knip.json | ||
| package.json | ||
| README.md | ||
| README.old.md | ||
| start-caddy.sh | ||
| start-https.sh | ||
| tailwind.config.js | ||
| tsconfig.json | ||
| tsconfig.path.json | ||
| vercel.json | ||
| yarn.lock | ||
Appsmith Client
This project was bootstrapped with Create React App.
For details on setting up your development machine, please refer to the Setup Guide