## Description
This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.
As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes
This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)
### Why is this needed?
This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.
However, just using `import type` in the current codebase will give you
this:
<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">
That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.
### Why enforce `import type`?
Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)
I’m doing this because I believe `import type` improves DX and makes
refactorings easier.
Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)
```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
It’s pretty hard, right?
What about now?
```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```
Now, it’s clear that only `lodash` will be bundled.
This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.
This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.
## Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## How Has This Been Tested?
This was tested to not break the build.
### Test Plan
> Add Testsmith test cases links that relate to this PR
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
---------
Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
310 lines
7.9 KiB
TypeScript
310 lines
7.9 KiB
TypeScript
import { get } from "lodash";
|
|
import type { ReduxAction } from "@appsmith/constants/ReduxActionConstants";
|
|
import {
|
|
ReduxActionTypes,
|
|
ReduxActionErrorTypes,
|
|
} from "@appsmith/constants/ReduxActionConstants";
|
|
import log from "loglevel";
|
|
import history from "utils/history";
|
|
import type { ApiResponse } from "api/ApiResponses";
|
|
import { Toaster, Variant } from "design-system-old";
|
|
import { flushErrors } from "actions/errorActions";
|
|
import { AUTH_LOGIN_URL } from "constants/routes";
|
|
import type { User } from "constants/userConstants";
|
|
import {
|
|
ERROR_CODES,
|
|
SERVER_ERROR_CODES,
|
|
} from "@appsmith/constants/ApiConstants";
|
|
import { getSafeCrash } from "selectors/errorSelectors";
|
|
import { getCurrentUser } from "selectors/usersSelectors";
|
|
import { ANONYMOUS_USERNAME } from "constants/userConstants";
|
|
import { put, takeLatest, call, select } from "redux-saga/effects";
|
|
import {
|
|
ERROR_401,
|
|
ERROR_403,
|
|
ERROR_500,
|
|
ERROR_0,
|
|
DEFAULT_ERROR_MESSAGE,
|
|
createMessage,
|
|
} from "@appsmith/constants/messages";
|
|
import store from "store";
|
|
|
|
import * as Sentry from "@sentry/react";
|
|
import { axiosConnectionAbortedCode } from "api/ApiUtils";
|
|
import { getLoginUrl } from "@appsmith/utils/adminSettingsHelpers";
|
|
|
|
/**
|
|
* making with error message with action name
|
|
*
|
|
* @param action
|
|
*/
|
|
export const getDefaultActionError = (action: string) =>
|
|
`Incurred an error when ${action}`;
|
|
|
|
export function* callAPI(apiCall: any, requestPayload: any) {
|
|
try {
|
|
const response: ApiResponse = yield call(apiCall, requestPayload);
|
|
return response;
|
|
} catch (error) {
|
|
return error;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* transform server errors to client error codes
|
|
*
|
|
* @param code
|
|
* @param resourceType
|
|
*/
|
|
const getErrorMessage = (code: number, resourceType = "") => {
|
|
switch (code) {
|
|
case 401:
|
|
return createMessage(ERROR_401);
|
|
case 500:
|
|
return createMessage(ERROR_500);
|
|
case 403:
|
|
return createMessage(() =>
|
|
ERROR_403(resourceType, getCurrentUser(store.getState())?.email || ""),
|
|
);
|
|
case 0:
|
|
return createMessage(ERROR_0);
|
|
}
|
|
};
|
|
|
|
export class IncorrectBindingError extends Error {}
|
|
|
|
/**
|
|
* validates if response does have any errors
|
|
* @throws {Error}
|
|
* @param response
|
|
* @param show
|
|
* @param logToSentry
|
|
*/
|
|
export function* validateResponse(
|
|
response: ApiResponse | any,
|
|
show = true,
|
|
logToSentry = false,
|
|
) {
|
|
if (!response) {
|
|
throw Error("");
|
|
}
|
|
|
|
// letting `apiFailureResponseInterceptor` handle it this case
|
|
if (response?.code === axiosConnectionAbortedCode) {
|
|
return false;
|
|
}
|
|
|
|
if (!response.responseMeta && !response.status) {
|
|
throw Error(getErrorMessage(0));
|
|
}
|
|
if (!response.responseMeta && response.status) {
|
|
throw Error(getErrorMessage(response.status, response.resourceType));
|
|
}
|
|
if (response.responseMeta.success) {
|
|
return true;
|
|
}
|
|
if (
|
|
SERVER_ERROR_CODES.INCORRECT_BINDING_LIST_OF_WIDGET.includes(
|
|
response.responseMeta.error.code,
|
|
)
|
|
) {
|
|
throw new IncorrectBindingError(response.responseMeta.error.message);
|
|
}
|
|
|
|
yield put({
|
|
type: ReduxActionErrorTypes.API_ERROR,
|
|
payload: {
|
|
error: response.responseMeta.error,
|
|
logToSentry,
|
|
show,
|
|
},
|
|
});
|
|
throw Error(response.responseMeta.error.message);
|
|
}
|
|
|
|
export function getResponseErrorMessage(response: ApiResponse) {
|
|
return response.responseMeta.error
|
|
? response.responseMeta.error.message
|
|
: undefined;
|
|
}
|
|
|
|
type ErrorPayloadType = {
|
|
code?: number | string;
|
|
message?: string;
|
|
crash?: boolean;
|
|
};
|
|
const ActionErrorDisplayMap: {
|
|
[key: string]: (error: ErrorPayloadType) => string;
|
|
} = {
|
|
[ReduxActionErrorTypes.API_ERROR]: (error) =>
|
|
get(error, "message", createMessage(DEFAULT_ERROR_MESSAGE)),
|
|
[ReduxActionErrorTypes.FETCH_PAGE_ERROR]: () =>
|
|
getDefaultActionError("fetching the page"),
|
|
[ReduxActionErrorTypes.SAVE_PAGE_ERROR]: () =>
|
|
getDefaultActionError("saving the page"),
|
|
};
|
|
|
|
const getErrorMessageFromActionType = (
|
|
type: string,
|
|
error: ErrorPayloadType,
|
|
): string => {
|
|
const actionErrorMessage = get(error, "message");
|
|
if (actionErrorMessage === undefined) {
|
|
if (type in ActionErrorDisplayMap) {
|
|
return ActionErrorDisplayMap[type](error);
|
|
}
|
|
return createMessage(DEFAULT_ERROR_MESSAGE);
|
|
}
|
|
return actionErrorMessage;
|
|
};
|
|
|
|
enum ErrorEffectTypes {
|
|
SHOW_ALERT = "SHOW_ALERT",
|
|
SAFE_CRASH = "SAFE_CRASH",
|
|
LOG_ERROR = "LOG_ERROR",
|
|
LOG_TO_SENTRY = "LOG_TO_SENTRY",
|
|
}
|
|
|
|
export interface ErrorActionPayload {
|
|
error: ErrorPayloadType;
|
|
show?: boolean;
|
|
crash?: boolean;
|
|
logToSentry?: boolean;
|
|
}
|
|
|
|
export function* errorSaga(errorAction: ReduxAction<ErrorActionPayload>) {
|
|
const effects = [ErrorEffectTypes.LOG_ERROR];
|
|
const { payload, type } = errorAction;
|
|
const { error, logToSentry, show = true } = payload || {};
|
|
const message = getErrorMessageFromActionType(type, error);
|
|
|
|
if (show) {
|
|
effects.push(ErrorEffectTypes.SHOW_ALERT);
|
|
}
|
|
|
|
if (error && error.crash) {
|
|
effects.push(ErrorEffectTypes.SAFE_CRASH);
|
|
}
|
|
|
|
if (error && logToSentry) {
|
|
effects.push(ErrorEffectTypes.LOG_TO_SENTRY);
|
|
}
|
|
|
|
for (const effect of effects) {
|
|
switch (effect) {
|
|
case ErrorEffectTypes.LOG_ERROR: {
|
|
logErrorSaga(errorAction);
|
|
break;
|
|
}
|
|
case ErrorEffectTypes.SHOW_ALERT: {
|
|
showAlertAboutError(message);
|
|
break;
|
|
}
|
|
case ErrorEffectTypes.SAFE_CRASH: {
|
|
yield call(crashAppSaga, error);
|
|
break;
|
|
}
|
|
case ErrorEffectTypes.LOG_TO_SENTRY: {
|
|
yield call(Sentry.captureException, error);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
yield put({
|
|
type: ReduxActionTypes.REPORT_ERROR,
|
|
payload: {
|
|
source: errorAction.type,
|
|
message,
|
|
},
|
|
});
|
|
}
|
|
|
|
function logErrorSaga(action: ReduxAction<{ error: ErrorPayloadType }>) {
|
|
log.debug(`Error in action ${action.type}`);
|
|
if (action.payload) log.error(action.payload.error);
|
|
}
|
|
|
|
function showAlertAboutError(message: string) {
|
|
Toaster.show({ text: message, variant: Variant.danger });
|
|
}
|
|
|
|
function* crashAppSaga(error: ErrorPayloadType) {
|
|
yield put({
|
|
type: ReduxActionTypes.SAFE_CRASH_APPSMITH,
|
|
payload: error,
|
|
});
|
|
}
|
|
|
|
/**
|
|
* this saga do some logic before actually setting safeCrash to true
|
|
*/
|
|
function* safeCrashSagaRequest(action: ReduxAction<{ code?: string }>) {
|
|
const user: User | undefined = yield select(getCurrentUser);
|
|
const code = get(action, "payload.code");
|
|
|
|
// if user is not logged and the error is "PAGE_NOT_FOUND",
|
|
// redirecting user to login page with redirecTo param
|
|
if (
|
|
get(user, "email") === ANONYMOUS_USERNAME &&
|
|
code === ERROR_CODES.PAGE_NOT_FOUND
|
|
) {
|
|
const queryParams = new URLSearchParams(window.location.search);
|
|
const embedQueryParam = queryParams.get("embed");
|
|
const ssoTriggerQueryParam = queryParams.get("ssoTrigger");
|
|
const ssoLoginUrl =
|
|
embedQueryParam === "true" && ssoTriggerQueryParam
|
|
? getLoginUrl(ssoTriggerQueryParam || "")
|
|
: null;
|
|
if (ssoLoginUrl) {
|
|
window.location.href = `${ssoLoginUrl}?redirectUrl=${encodeURIComponent(
|
|
window.location.href,
|
|
)}`;
|
|
} else {
|
|
window.location.href = `${AUTH_LOGIN_URL}?redirectUrl=${encodeURIComponent(
|
|
window.location.href,
|
|
)}`;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
// if there is no action to be done, just calling the safe crash action
|
|
yield put({
|
|
type: ReduxActionTypes.SAFE_CRASH_APPSMITH,
|
|
payload: {
|
|
code,
|
|
},
|
|
});
|
|
}
|
|
|
|
/**
|
|
* flush errors and redirect users to a url
|
|
*
|
|
* @param action
|
|
*/
|
|
export function* flushErrorsAndRedirectSaga(
|
|
action: ReduxAction<{ url?: string }>,
|
|
) {
|
|
const safeCrash: boolean = yield select(getSafeCrash);
|
|
|
|
if (safeCrash) {
|
|
yield put(flushErrors());
|
|
}
|
|
if (!action.payload.url) return;
|
|
|
|
history.push(action.payload.url);
|
|
}
|
|
|
|
export default function* errorSagas() {
|
|
yield takeLatest(Object.values(ReduxActionErrorTypes), errorSaga);
|
|
yield takeLatest(
|
|
ReduxActionTypes.FLUSH_AND_REDIRECT,
|
|
flushErrorsAndRedirectSaga,
|
|
);
|
|
yield takeLatest(
|
|
ReduxActionTypes.SAFE_CRASH_APPSMITH_REQUEST,
|
|
safeCrashSagaRequest,
|
|
);
|
|
}
|