Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
b3342187b8
PromucFlow_constructor/app/client/src/utils
History
Aman Agarwal b3342187b8
fix: google sheet datasource is incorrectly marked as unauthorised by reconnect modal logic. (#23888) 
## Description
This PR constitues
- The "reconnect" modal logic was modified to use the
"isDatasourceAuthorizedForQueryCreation" function in the
"editorContextUtils.ts" file to verify the authorization state of the
Google Sheets plugin.
- Added a functionality to determine whether or not the plugin is Google
Sheets.

#### PR fixes following issue(s)
Fixes #23881
Fixes #23861
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: manish kumar <manish@appsmith.com>
Co-authored-by: Ayush Pahwa <ayushpahwa96@gmail.com>
2023-06-01 12:57:15 +05:30
..
autocomplete chore: Clean up unused and completed feature flags (#23062) 2023-05-25 10:58:41 +05:30
autoHeight chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
autoLayout fix: conversion of app with pages imported from templates and adjust height for blank container (#23404) 2023-05-25 17:50:08 +05:30
CallbackHandler chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
DSLConversions fix: widget columns to have integers after conversion to fixed layout and redirect to home page while restoring if the page does not exist in the restored snapshot (#23144) 2023-05-14 22:40:20 +05:30
editor
FilterInternalProperties feat: peek overlay nested properties + perf improvements (#23414) 2023-05-26 17:12:10 +05:30
formControl fix: Update connection mode DropDown by Segmented Control (#23730) 2023-05-29 16:45:52 +05:30
hooks chore: Revert Multi pane scale (#23909) 2023-05-31 18:36:34 +05:30
migrations fix: Add current index property to min max fields (#22556) 2023-05-05 19:25:10 +05:30
NavigationSelector feat: peek overlay nested properties + perf improvements (#23414) 2023-05-26 17:12:10 +05:30
ProductRamps feat: in-app ramps for "invite user to an application" and "custom roles" (#23588) 2023-05-30 10:59:01 +05:30
validation feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
AnalyticsUtil.tsx chore: intercom trigger added for gsheets auth failure (#23664) 2023-05-30 17:19:35 +05:30
ApiPaneUtils.test.ts
ApiPaneUtils.tsx
AppsmithConsole.ts feat: Error Navigation (#21753) 2023-04-10 18:29:14 +05:30
AppsmithUtils.test.ts fix: Include port number while constructing blob url in camera widget and plugin action execution (#22458) 2023-04-19 23:59:56 +05:30
AppsmithUtils.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
AppUtils.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
bootIntercom.ts fix: send empty license key to intercom for CE (#23149) 2023-05-15 16:48:34 +05:30
boxHelpers.test.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
boxHelpers.ts
BrandingUtils.ts feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
canvasStructureHelpers.test.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
canvasStructureHelpers.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
configTree.ts fix: Prevent evalTree and configTree from being undefined (#23374) 2023-05-22 07:17:23 +01:00
DatasourceSagaUtils.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
dayJsUtils.ts fix: Layout Conversion bugs for auto Layout (#22565) 2023-05-03 04:26:52 +00:00
DSLMigration.test.ts fix: Add current index property to min max fields (#22556) 2023-05-05 19:25:10 +05:30
DSLMigrations.ts fix: Add current index property to min max fields (#22556) 2023-05-05 19:25:10 +05:30
DSLMigrationsUtils.test.ts fix: Add current index property to min max fields (#22556) 2023-05-05 19:25:10 +05:30
DynamicBindingUtils.test.ts fix: combineDynamicBindings function (#22600) 2023-04-26 23:58:17 +05:30
DynamicBindingUtils.ts fix: api url dynamic bindings (#23696) 2023-05-26 15:43:18 +05:30
editorContextUtils.ts fix: google sheet datasource is incorrectly marked as unauthorised by reconnect modal logic. (#23888) 2023-06-01 12:57:15 +05:30
formhelpers.test.ts
formhelpers.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
GenerateCrudUtil.ts
generators.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
getCodeMirrorNamespace.ts feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
getPathAndValueFromActionDiffObject.ts
getQueryParamsObject.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
helpers.test.ts fix: Update list of global worker identifiers (#23440) 2023-05-22 11:52:25 +05:30
helpers.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
history.ts fix: Do not set widget ancestry if selection happens via canvas (#22069) 2023-04-10 12:55:14 +05:30
JSPaneUtils.test.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
JSPaneUtils.tsx feat: Action selector (#21582) 2023-04-06 22:19:12 +05:30
klona.test.ts
layoutPropertiesUtils.ts feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
lazyLottie.ts feat: Bundle optimization and first load improvements (#21667) 2023-05-11 10:56:03 +05:30
localStorage.test.ts
localStorage.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
MessageUtil.ts fix: access outer scope variables inside callbacks (#20168) 2023-02-12 00:03:20 +05:30
metaWidgetState.ts feat: util to serve images locally or via remote url (#22080) 2023-04-10 12:32:31 +05:30
PerformanceTracker.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
PropertyControlFactory.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
PropertyControlRegistry.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
ReducerUtils.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
reflowHookUtils.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
replayHelpers.test.js chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
replayHelpers.tsx feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
storage.ts feat: onboarding flow revamp for first time admin users: ce (#23581) 2023-05-25 23:51:56 +05:30
SuccessfulBindingsMap.ts fix: ENTITY_BINDING_SUCCESS event added which is fired whenever there is a successful binding created by the user. (#21227) 2023-03-24 15:45:11 +05:30
testDSLs.ts feat: [epic] appsmith design system version 2 deduplication (#22030) 2023-05-20 00:07:06 +05:30
testPropertyPaneConfig.test.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
treeUtils.ts
TypeHelpers.ts fix: fixed broken file downloads for urls containing "(" or ")" (#21752) 2023-04-03 23:23:10 +05:30
URLUtils.ts
UseComposeRef.ts
WidgetBlueprintUtils.ts feat: Add widget responsiveness and conversion algorithm (#21386) 2023-04-07 09:51:35 -04:00
widgetEvalUtils.ts fix: Improving performance of JS evaluations by splitting the data tree (#21547) 2023-03-20 16:34:02 +05:30
WidgetFactory.tsx chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
WidgetFactoryHelpers.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WidgetFeatures.test.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WidgetFeatures.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WidgetLoadingStateUtils.test.ts fix: Improving performance of JS evaluations by splitting the data tree (#21547) 2023-03-20 16:34:02 +05:30
WidgetLoadingStateUtils.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WidgetMigrationUtils.test.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WidgetMigrationUtils.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WidgetPropsUtils.test.tsx feat: util to serve images locally or via remote url (#22080) 2023-04-10 12:32:31 +05:30
WidgetPropsUtils.tsx feat: Expand auto height implementation to handle auto height use cases. (#22974) 2023-05-11 10:15:14 +05:30
WidgetQueryGeneratorRegistry.test.ts chore: [one click binding] Create a registry to maintain the list of the widget query generators (#21764) 2023-03-28 20:03:29 +05:30
WidgetQueryGeneratorRegistry.ts chore: [one click binding] Property pane control to generate query for a widget (#22172) 2023-04-13 16:39:24 +05:30
WidgetRegisterHelpers.tsx chore: Move autocomplete suggestions from entityDefinitions to individual widget components (#21818) 2023-04-14 11:57:49 +05:30
WidgetRegistry.tsx chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
widgetRenderUtils.test.ts fix: Improving performance of JS evaluations by splitting the data tree (#21547) 2023-03-20 16:34:02 +05:30
widgetRenderUtils.tsx fix: Improving performance of JS evaluations by splitting the data tree (#21547) 2023-03-20 16:34:02 +05:30
WidgetSizeUtils.test.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WidgetSizeUtils.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30
WorkerUtil.test.ts chore: corrections for eslint and prettier (#21543) 2023-03-17 19:50:51 +05:30
WorkerUtil.ts chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 2023-03-16 17:11:47 +05:30