PromucFlow_constructor/app/client/src/utils/WidgetFeatures.ts
Abhinav Jha 34b7a841b7
fix: Enable auto height by default for JSONForm widget (#18932)
## Description
- JSONForm by default now has auto height enabled
- Changed the CSS for the messages in JSONForm to a fixed height. This
way, the JSONForm widget doesn't change height until the default form
schema is first loaded.
- Made sure to leave the behaviour in fixed mode uneffected.

Fixes #18931

Media



https://user-images.githubusercontent.com/103687/207424195-47712381-2dd2-4aa2-a8b2-6fe159557482.mov



## Type of change
- New feature (non-breaking change which adds functionality)


## How Has This Been Tested?
- Manual
- Cypress PENDING


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [PENDING] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [PENDING] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [NA] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-23 17:05:27 +05:30

351 lines
10 KiB
TypeScript

import { ReduxActionTypes } from "@appsmith/constants/ReduxActionConstants";
import {
PropertyPaneConfig,
PropertyPaneControlConfig,
} from "constants/PropertyControlConstants";
import {
GridDefaults,
WidgetHeightLimits,
WidgetType,
} from "constants/WidgetConstants";
import { WidgetProps } from "widgets/BaseWidget";
import { WidgetConfiguration } from "widgets/constants";
export enum RegisteredWidgetFeatures {
DYNAMIC_HEIGHT = "dynamicHeight",
}
interface WidgetFeatureConfig {
active: boolean;
defaultValue?: DynamicHeight;
sectionIndex: number;
}
export type WidgetFeatures = Record<
RegisteredWidgetFeatures,
WidgetFeatureConfig
>;
export enum DynamicHeight {
AUTO_HEIGHT = "AUTO_HEIGHT",
FIXED = "FIXED",
AUTO_HEIGHT_WITH_LIMITS = "AUTO_HEIGHT_WITH_LIMITS",
}
/* This contains all properties which will be added
to a widget, automatically, by the Appsmith platform
Each feature, is a unique key, whose value is an object
with the list of properties to be added to a widget along
with their default values
Note: These are added to the widget configs during registration
*/
export const WidgetFeatureProps: Record<
RegisteredWidgetFeatures,
Record<string, unknown>
> = {
[RegisteredWidgetFeatures.DYNAMIC_HEIGHT]: {
minDynamicHeight: WidgetHeightLimits.MIN_HEIGHT_IN_ROWS,
maxDynamicHeight: WidgetHeightLimits.MAX_HEIGHT_IN_ROWS,
dynamicHeight: DynamicHeight.FIXED,
},
};
export const WidgetFeaturePropertyEnhancements: Record<
RegisteredWidgetFeatures,
(config: WidgetConfiguration) => Record<string, unknown>
> = {
[RegisteredWidgetFeatures.DYNAMIC_HEIGHT]: (config: WidgetConfiguration) => {
const newProperties: Partial<WidgetProps> = {};
newProperties.dynamicHeight =
config.features?.dynamicHeight?.defaultValue || DynamicHeight.AUTO_HEIGHT;
if (config.isCanvas) {
newProperties.dynamicHeight = DynamicHeight.AUTO_HEIGHT;
newProperties.minDynamicHeight =
config.defaults.minDynamicHeight ||
WidgetHeightLimits.MIN_CANVAS_HEIGHT_IN_ROWS;
newProperties.maxDynamicHeight =
config.defaults.maxDynamicHeight ||
WidgetHeightLimits.MAX_HEIGHT_IN_ROWS;
newProperties.shouldScrollContents = true;
} else {
newProperties.minDynamicHeight =
config.defaults.minDynamicHeight ||
WidgetHeightLimits.MIN_HEIGHT_IN_ROWS;
newProperties.maxDynamicHeight =
config.defaults.maxDynamicHeight ||
WidgetHeightLimits.MAX_HEIGHT_IN_ROWS;
}
if (config.defaults.overflow) newProperties.overflow = "NONE";
return newProperties;
},
};
function findAndUpdatePropertyPaneControlConfig(
config: PropertyPaneConfig[],
propertyPaneUpdates: Record<string, Record<string, unknown>>,
): PropertyPaneConfig[] {
return config.map((sectionConfig: PropertyPaneConfig) => {
if (
Array.isArray(sectionConfig.children) &&
sectionConfig.children.length > 0
) {
Object.keys(propertyPaneUpdates).forEach((propertyName: string) => {
const controlConfigIndex:
| number
| undefined = sectionConfig.children?.findIndex(
(controlConfig: PropertyPaneConfig) =>
(controlConfig as PropertyPaneControlConfig).propertyName ===
propertyName,
);
if (
controlConfigIndex !== undefined &&
controlConfigIndex > -1 &&
sectionConfig.children
) {
sectionConfig.children[controlConfigIndex] = {
...sectionConfig.children[controlConfigIndex],
...propertyPaneUpdates[propertyName],
};
}
});
}
return sectionConfig;
});
}
export const WidgetFeaturePropertyPaneEnhancements: Record<
RegisteredWidgetFeatures,
(
config: PropertyPaneConfig[],
widgetType?: WidgetType,
) => PropertyPaneConfig[]
> = {
[RegisteredWidgetFeatures.DYNAMIC_HEIGHT]: (
config: PropertyPaneConfig[],
widgetType?: WidgetType,
) => {
function hideWhenDynamicHeightIsEnabled(props: WidgetProps) {
return (
props.dynamicHeight === DynamicHeight.AUTO_HEIGHT_WITH_LIMITS ||
props.dynamicHeight === DynamicHeight.AUTO_HEIGHT
);
}
let update = findAndUpdatePropertyPaneControlConfig(config, {
shouldScrollContents: {
hidden: hideWhenDynamicHeightIsEnabled,
dependencies: ["dynamicHeight"],
},
scrollContents: {
hidden: hideWhenDynamicHeightIsEnabled,
dependencies: ["dynamicHeight"],
},
fixedFooter: {
hidden: hideWhenDynamicHeightIsEnabled,
dependencies: ["dynamicHeight"],
},
overflow: {
hidden: hideWhenDynamicHeightIsEnabled,
dependencies: ["dynamicHeight"],
},
});
if (widgetType === "MODAL_WIDGET") {
update = findAndUpdatePropertyPaneControlConfig(update, {
dynamicHeight: {
options: [
{
label: "Auto Height",
value: DynamicHeight.AUTO_HEIGHT,
},
{
label: "Fixed",
value: DynamicHeight.FIXED,
},
],
},
});
}
return update;
},
};
/* Hide the min height and max height properties using this function
as the `hidden` hook in the property pane configuration
This function checks if the `dynamicHeight` property is enabled
and returns true if disabled, and false if enabled.
*/
export function hideDynamicHeightPropertyControl(props: WidgetProps) {
return props.dynamicHeight !== DynamicHeight.AUTO_HEIGHT_WITH_LIMITS;
}
// TODO (abhinav): ADD_UNIT_TESTS
function updateMinMaxDynamicHeight(
props: WidgetProps,
propertyName: string,
propertyValue: unknown,
) {
const updates = [
{
propertyPath: propertyName,
propertyValue: propertyValue,
},
];
if (propertyValue === DynamicHeight.AUTO_HEIGHT_WITH_LIMITS) {
const minDynamicHeight = parseInt(props.minDynamicHeight, 10);
if (
isNaN(minDynamicHeight) ||
minDynamicHeight < WidgetHeightLimits.MIN_HEIGHT_IN_ROWS
) {
updates.push({
propertyPath: "minDynamicHeight",
propertyValue: WidgetHeightLimits.MIN_HEIGHT_IN_ROWS,
});
}
const maxDynamicHeight = parseInt(props.maxDynamicHeight, 10);
if (
isNaN(maxDynamicHeight) ||
maxDynamicHeight === WidgetHeightLimits.MAX_HEIGHT_IN_ROWS ||
maxDynamicHeight <= WidgetHeightLimits.MIN_HEIGHT_IN_ROWS
) {
updates.push({
propertyPath: "maxDynamicHeight",
propertyValue:
props.bottomRow - props.topRow + GridDefaults.CANVAS_EXTENSION_OFFSET,
});
}
// Case where maxDynamicHeight is zero
if (isNaN(maxDynamicHeight) || maxDynamicHeight === 0) {
updates.push({
propertyPath: "maxDynamicHeight",
propertyValue: props.bottomRow - props.topRow,
});
}
} else if (propertyValue === DynamicHeight.AUTO_HEIGHT) {
const minHeightInRows = props.isCanvas
? WidgetHeightLimits.MIN_CANVAS_HEIGHT_IN_ROWS
: WidgetHeightLimits.MIN_HEIGHT_IN_ROWS;
updates.push(
{
propertyPath: "minDynamicHeight",
propertyValue: minHeightInRows,
},
{
propertyPath: "maxDynamicHeight",
propertyValue: WidgetHeightLimits.MAX_HEIGHT_IN_ROWS,
},
);
}
if (propertyValue === DynamicHeight.FIXED) {
updates.push({
propertyPath: "originalBottomRow",
propertyValue: undefined,
});
updates.push({
propertyPath: "originalTopRow",
propertyValue: undefined,
});
}
// The following are updates which apply to specific widgets.
if (
propertyValue === DynamicHeight.AUTO_HEIGHT ||
propertyValue === DynamicHeight.AUTO_HEIGHT_WITH_LIMITS
) {
if (props.dynamicHeight === DynamicHeight.FIXED) {
updates.push({
propertyPath: "originalBottomRow",
propertyValue: props.bottomRow,
});
updates.push({
propertyPath: "originalTopRow",
propertyValue: props.topRow,
});
}
if (!props.shouldScrollContents) {
updates.push({
propertyPath: "shouldScrollContents",
propertyValue: true,
});
}
if (props.overflow !== undefined) {
updates.push({
propertyPath: "overflow",
propertyValue: "NONE",
});
}
if (props.scrollContents === true) {
updates.push({
propertyPath: "scrollContents",
propertyValue: false,
});
}
if (props.fixedFooter === true) {
updates.push({
propertyPath: "fixedFooter",
propertyValue: false,
});
}
}
return updates;
}
// TODO FEATURE:(abhinav) Add validations to these properties
const CONTAINER_SCROLL_HELPER_TEXT =
"This widget shows an internal scroll when you add widgets in edit mode. It'll resize after you've added widgets. The scroll won't exist in view mode.";
export const PropertyPaneConfigTemplates: Record<
RegisteredWidgetFeatures,
PropertyPaneConfig[]
> = {
[RegisteredWidgetFeatures.DYNAMIC_HEIGHT]: [
{
helpText:
"Auto Height: Configure the way the widget height reacts to content changes.",
propertyName: "dynamicHeight",
label: "Height",
controlType: "DROP_DOWN",
isBindProperty: false,
isTriggerProperty: false,
dependencies: [
"shouldScrollContents",
"maxDynamicHeight",
"minDynamicHeight",
"bottomRow",
"topRow",
"overflow",
"dynamicHeight",
"isCanvas",
],
updateHook: updateMinMaxDynamicHeight,
helperText: (props: WidgetProps) => {
return props.isCanvas &&
props.dynamicHeight === DynamicHeight.AUTO_HEIGHT
? CONTAINER_SCROLL_HELPER_TEXT
: "";
},
options: [
{
label: "Auto Height",
value: DynamicHeight.AUTO_HEIGHT,
},
{
label: "Auto Height with limits",
value: DynamicHeight.AUTO_HEIGHT_WITH_LIMITS,
},
{
label: "Fixed",
value: DynamicHeight.FIXED,
},
],
postUpdateAction: ReduxActionTypes.CHECK_CONTAINERS_FOR_AUTO_HEIGHT,
},
],
};