b08d100185
## Description > Datasource Controller's getTokenRequestUrl() is currently bounded to Pages. > This is a code split to support generation of token request url for other contexts like modules and workflows. #### PR fixes following issue(s) Fixes [[Bug]: Authenticated API & Authenticated graphQL API with OAuth2 throws 404 error in workflows](https://github.com/appsmithorg/appsmith/issues/31554) #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? - [x] JUnit Existing test cases should pass. - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated OAuth2 authorization process to use context-specific parameters for enhanced flexibility and security. - **Refactor** - Modified `getTokenRequestUrl` and `getAuthorizationCodeURLForGenericOAuth2` methods to accept `contextType` and `contextId`, improving the OAuth2 flow. - Adjusted logging and method parameters across various classes for consistency with new OAuth2 process. - **Tests** - Updated test cases to reflect changes in method parameter orders and OAuth2 authorization enhancements. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| src | ||
| auth-notes | ||
| pom.xml | ||