Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
a8c50cfb37
PromucFlow_constructor/app/client/cypress/support/Objects/mySqlData.ts
Ivan Akulov 424d2f6965
chore: upgrade to prettier v2 + enforce import types (#21013)Co-authored-by: Satish Gandham <hello@satishgandham.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> 
## Description

This PR upgrades Prettier to v2 + enforces TypeScript’s [`import
type`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export)
syntax where applicable. It’s submitted as a separate PR so we can merge
it easily.

As a part of this PR, we reformat the codebase heavily:
- add `import type` everywhere where it’s required, and
- re-format the code to account for Prettier 2’s breaking changes:
https://prettier.io/blog/2020/03/21/2.0.0.html#breaking-changes

This PR is submitted against `release` to make sure all new code by team
members will adhere to new formatting standards, and we’ll have fewer
conflicts when merging `bundle-optimizations` into `release`. (I’ll
merge `release` back into `bundle-optimizations` once this PR is
merged.)

### Why is this needed?

This PR is needed because, for the Lodash optimization from
7cbb12af88,
we need to use `import type`. Otherwise, `babel-plugin-lodash` complains
that `LoDashStatic` is not a lodash function.

However, just using `import type` in the current codebase will give you
this:

<img width="962" alt="Screenshot 2023-03-08 at 17 45 59"
src="https://user-images.githubusercontent.com/2953267/223775744-407afa0c-e8b9-44a1-90f9-b879348da57f.png">

That’s because Prettier 1 can’t parse `import type` at all. To parse it,
we need to upgrade to Prettier 2.

### Why enforce `import type`?

Apart from just enabling `import type` support, this PR enforces
specifying `import type` everywhere it’s needed. (Developers will get
immediate TypeScript and ESLint errors when they forget to do so.)

I’m doing this because I believe `import type` improves DX and makes
refactorings easier.

Let’s say you had a few imports like below. Can you tell which of these
imports will increase the bundle size? (Tip: it’s not all of them!)

```ts
// app/client/src/workers/Linting/utils.ts
import { Position } from "codemirror";
import { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

It’s pretty hard, right?

What about now?

```ts
// app/client/src/workers/Linting/utils.ts
import type { Position } from "codemirror";
import type { LintError as JSHintError, LintOptions } from "jshint";
import { get, isEmpty, isNumber, keys, last, set } from "lodash";
```

Now, it’s clear that only `lodash` will be bundled.

This helps developers to see which imports are problematic, but it
_also_ helps with refactorings. Now, if you want to see where
`codemirror` is bundled, you can just grep for `import \{.*\} from
"codemirror"` – and you won’t get any type-only imports.

This also helps (some) bundlers. Upon transpiling, TypeScript erases
type-only imports completely. In some environment (not ours), this makes
the bundle smaller, as the bundler doesn’t need to bundle type-only
imports anymore.

## Type of change

- Chore (housekeeping or task changes that don't impact user perception)


## How Has This Been Tested?

This was tested to not break the build.

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Satish Gandham <hello@satishgandham.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
2023-03-16 17:11:47 +05:30

244 lines
5.7 KiB
TypeScript
Raw Blame History

const mySqlData = {
tableName: "mysqlDTs",
inputFieldName: [
"Stinyint_column",
"Utinyint_column",
"Ssmallint_column",
"Usmallint_column",
"Smediumint_column",
"Umediumint_column",
"Sint_column",
"Uint_column",
"Bigint_column",
"Float_column",
"Double_column",
"Decimal_column",
"Datetime_column",
"Timestamp_column",
"Date_column",
"Time_column",
"Year_column",
"Varchar_column",
"Char_column",
"Enum_column",
"Json_column",
],
input: [
[
"-128",
"0",
"-32768",
"0",
"-8388608",
"0",
"-2147483648",
"0",
"123456",
"123.45",
"123.45",
"123.45",
"2012-12-31 11:30:45",
"2012/12/31 11:30:45",
"20121231",
"838:59:59",
"1901",
"a",
"a",
"a",
'{"abc": "123"}',
],
[
"0",
"255",
"0",
"65535",
"0",
"16777215",
"0",
"4294967295",
"456789",
"123.456",
"123.456",
"123.456",
"2012-12-31 11:30:45",
"2012/12/31 11:30:45",
"2012-12-31",
"0:00:00",
"2155",
"abcdefghijklmnopqrst",
"abcdefghij",
"b",
"{}",
],
[
"127",
"0",
"32767",
"0",
"8388607",
"0",
"2147483647",
"0",
"123456789",
"123.451",
"123.451",
"123.451",
"2012/12/31 11:30:45",
"20121231113045",
"2012/12/31",
"-838:59:59",
"1901'",
"12345678912345",
"012345",
"c",
"[1, 2, 3, 4]",
],
[
"0",
"0",
"0",
"0",
"0",
"0",
"0123",
"0",
"0",
"0",
"0",
"0",
"20121231113045",
"121231113045",
"121231",
"11:12",
"2155",
"true",
"false",
"c",
"[]",
],
[
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"20121231113045",
"121231113045",
"121231",
"1112",
"2022",
"null",
"NulL",
"c",
'["a",true,0,12.34]',
],
[
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"0",
"20121231113045",
"121231113045",
"121231",
"12",
"2022",
"",
"abc",
"c",
"{}",
],
],
falseResult: [
[-129, 128],
[-1, 256],
[-32769, 32768],
[-1, 65536],
[-8388609, 8388608],
[-1, 16777216],
[-2147483649, 2147483648],
[-1, 4294967296],
[],
[123456789.45],
["a"],
[123456789.45],
["2012/12/31 11:30:451"],
["2012/12/311 11:30:45"],
["2012-123-31"],
["22:591:59"],
["190123"],
["abcdefghijklmnopqrstu"],
["abcdefghijk"],
["d"],
[],
],
result: [
["1", "2", "3", "4", "5"],
["-128", "0", "127"],
["0", "255"],
["-32768", "0", "32767"],
["0", "65535"],
["-8388608", "0", "8388607"],
["0", "16777215"],
["-2147483648", "0", "2147483647", "123"],
["0", "4294967295"],
["123456", "456789", "123456789"],
["123.45", "123.46", "123.45"],
["123.45", "123.456", "123.451"],
["123.45", "123.46", "123.45"],
[
"2012-12-31T11:30:45Z",
"2012-12-31T11:30:45Z",
"2012-12-31T11:30:45Z",
"2012-12-31T11:30:45Z",
"2012-12-31T11:30:45Z",
],
[
"2012-12-31T11:30:45Z",
"2012-12-31T11:30:45Z",
"2012-12-31T11:30:45Z",
"2012-12-31T11:30:45Z",
],
["2012-12-31", "2012-12-31", "2012-12-31", "2012-12-31"],
["22:59:59", "00:00:00", "01:00:01", "11:12:00", "00:11:12", "00:00:12"],
["1901", "2155", "1901", "2155"],
["a", "abcdefghijklmnopqrst", "12345678912345", "true", "null"],
["a", "abcdefghij", "012345", "false", "NulL"],
["a", "b", "c"],
["false", "true"],
[{ abc: "123" }, {}, [1, 2, 3, 4], [], ["a", true, 0, 12.34]],
],
query: {
createTable: `CREATE TABLE mysqlDTs (serialId SERIAL not null primary key, stinyint_column TINYINT, utinyint_column TINYINT UNSIGNED,
ssmallint_column SMALLINT, usmallint_column SMALLINT UNSIGNED, smediumint_column MEDIUMINT, umediumint_column MEDIUMINT UNSIGNED,
sint_column INT, uint_column INT UNSIGNED, bigint_column BIGINT, float_column FLOAT( 10, 2 ), double_column DOUBLE, decimal_column DECIMAL( 10, 2 ),
datetime_column DATETIME, timestamp_column TIMESTAMP, date_column DATE, time_column TIME, year_column YEAR, varchar_column VARCHAR( 20 ),
char_column CHAR( 10 ), enum_column ENUM( 'a', 'b', 'c' ), bool_column BOOL, json_column JSON);`,
insertRecord: `INSERT INTO mysqlDTs (stinyint_column, utinyint_column, ssmallint_column, usmallint_column, smediumint_column, umediumint_column,
sint_column, uint_column, bigint_column, float_column, double_column, decimal_column, datetime_column, timestamp_column,
date_column, time_column, year_column, varchar_column, char_column, enum_column, bool_column, json_column )
VALUES
({{InsertStinyint.text}}, {{InsertUtinyint.text}}, {{InsertSsmallint.text}}, {{InsertUsmallint.text}}, {{InsertSmediumint.text}},
{{InsertUmediumint.text}}, {{InsertSint.text}}, {{InsertUint.text}}, {{InsertBigint.text}}, {{InsertFloat.text}}, {{InsertDouble.text}},
{{InsertDecimal.text}}, {{InsertDatetime.text}}, {{InsertTimestamp.text}}, {{InsertDate.text}}, {{InsertTime.text}},
{{InsertYear.text}}, {{InsertVarchar.text ? InsertVarchar.text : null}}, {{InsertChar.text}}, {{InsertEnum.text}}, {{InsertBoolean.isSwitchedOn}}, {{InputJson.text}});`,
dropTable: `drop table mysqlDTs`,
},
};
export default mySqlData;
Reference in New Issue View Git Blame Copy Permalink