PromucFlow_constructor/app/client/src/components/propertyControls/IconSelectControl.test.tsx
Valera Melnikov d7cd02a45d
fix: add testing library eslint rules (#31028)
Added recommended rules for testing library

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added `data-testid` attributes across various components for improved
test identification.

- **Tests**
- Enhanced test cases with asynchronous handling (`async`/`await`) for
more reliable user interaction simulations.
- Transitioned to using `getByTestId` instead of `queryByTestId` for
better assertion reliability in tests.
- Added `await` before the `userEvent.click(el)` statement in the
ChartWidget test file.
- Updated the destructured variable names from `queryByTestId` to
`getByTestId` in the DividerWidget test file for improved clarity.
- Added an import for `screen` from "@testing-library/react" and updated
element querying in the TabsWidget test file.

- **Chores**
- Updated ESLint configurations to include testing-library plugins and
rules, improving code quality and consistency in test files.
- Removed unnecessary `cleanup` function calls after tests, following
best practices for test cleanup.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-02-12 18:59:10 +03:00

300 lines
10 KiB
TypeScript

import React from "react";
import "@testing-library/jest-dom";
import {
render,
screen,
waitFor,
waitForElementToBeRemoved,
} from "@testing-library/react";
import IconSelectControl from "./IconSelectControl";
import userEvent from "@testing-library/user-event";
import { noop } from "lodash";
import { EditorTheme } from "components/editorComponents/CodeEditor/EditorConfig";
const requiredParams = {
evaluatedValue: undefined,
deleteProperties: noop,
widgetProperties: undefined,
parentPropertyName: "",
parentPropertyValue: undefined,
additionalDynamicData: {},
label: "",
openNextPanel: noop,
onPropertyChange: noop,
theme: EditorTheme.LIGHT,
propertyName: "iconName",
controlType: "",
isBindProperty: false,
isTriggerProperty: false,
};
const waitForParamsForSearchFocus = {
timeout: 3000,
};
describe("<IconSelectControl /> - Keyboard navigation", () => {
const getTestComponent = (
onPropertyChange: (
propertyName: string,
propertyValue: string,
isUpdatedViaKeyboard?: boolean,
) => void = noop,
) => (
<IconSelectControl
{...requiredParams}
onPropertyChange={onPropertyChange}
/>
);
it("Pressing tab should focus the component", async () => {
render(getTestComponent());
await userEvent.tab();
expect(screen.getByRole("button")).toHaveFocus();
});
it.each(["{Enter}", " ", "{ArrowDown}", "{ArrowUp}"])(
"Pressing '%s' should open the icon selector",
async (key) => {
render(getTestComponent());
await userEvent.tab();
expect(screen.queryByRole("list")).toBeNull();
await userEvent.keyboard(key);
expect(screen.getByRole("list")).toBeInTheDocument();
// Makes sure search bar is having focus
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
},
);
it("Pressing '{Escape}' should close the icon selector", async () => {
render(getTestComponent());
await userEvent.tab();
expect(screen.queryByRole("list")).toBeNull();
await userEvent.keyboard("{Enter}");
expect(screen.getByRole("list")).toBeInTheDocument();
await userEvent.keyboard("{Escape}");
await waitForElementToBeRemoved(screen.queryByRole("list"));
});
it("Pressing '{ArrowDown}' while search is in focus should remove the focus", async () => {
render(getTestComponent());
await userEvent.tab();
await userEvent.keyboard("{Enter}");
expect(screen.getByRole("list")).toBeInTheDocument();
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
await userEvent.keyboard("{ArrowDown}");
expect(screen.getByRole("textbox")).not.toHaveFocus();
});
it("Pressing '{Shift} + {ArrowUp}' while search is not in focus should focus search box", async () => {
render(getTestComponent());
await userEvent.tab();
await userEvent.keyboard("{Enter}");
expect(screen.getByRole("list")).toBeInTheDocument();
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
await userEvent.keyboard("{ArrowDown}");
expect(screen.getByRole("textbox")).not.toHaveFocus();
await userEvent.keyboard("{Shift}{ArrowUp}");
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
});
/*
Icon Arrangement
(none) add add-column-left add-column-right
add-row-bottom add-row-top add-to-artifact add-to-folder
airplane align-center align-justify align-left
*/
it("Pressing '{ArrowDown}' should navigate the icon selection downwards", async () => {
render(getTestComponent());
await userEvent.tab();
await userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
// used to shift the focus from search
await userEvent.keyboard("{ArrowDown}");
await userEvent.keyboard("{ArrowDown}");
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
});
it("Pressing '{ArrowUp}' should navigate the icon selection upwards", async () => {
render(getTestComponent());
await userEvent.tab();
await userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
// used to shift the focus from search
await userEvent.keyboard("{ArrowDown}");
await userEvent.keyboard("{ArrowDown}");
await userEvent.keyboard("{ArrowDown}");
await userEvent.keyboard("{ArrowDown}");
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
await userEvent.keyboard("{ArrowUp}");
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
});
it("Pressing '{ArrowRight}' should navigate the icon selection towards right", async () => {
render(getTestComponent());
await userEvent.tab();
await userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
// used to shift the focus from search
await userEvent.keyboard("{ArrowDown}");
await userEvent.keyboard("{ArrowRight}");
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
});
it("Pressing '{ArrowLeft}' should navigate the icon selection towards left", async () => {
render(getTestComponent());
await userEvent.tab();
await userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
// used to shift the focus from search
await userEvent.keyboard("{ArrowDown}");
await userEvent.keyboard("{ArrowRight}");
await userEvent.keyboard("{ArrowRight}");
await userEvent.keyboard("{ArrowRight}");
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
await userEvent.keyboard("{ArrowLeft}");
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
});
it("Pressing '{Enter}' or ' ' should select the icon", async () => {
const handleOnSelect = jest.fn();
render(getTestComponent(handleOnSelect));
await userEvent.tab();
expect(screen.getByRole("button")?.textContent).toEqual("(none)caret-down");
await userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
// used to shift the focus from search
await userEvent.keyboard("{ArrowDown}");
await userEvent.keyboard("{ArrowDown}");
await userEvent.keyboard("{ArrowRight}");
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
await userEvent.keyboard(" ");
expect(handleOnSelect).toHaveBeenCalledTimes(1);
expect(handleOnSelect.mock.calls[0]).toMatchSnapshot();
await waitForElementToBeRemoved(screen.queryByRole("list"));
await userEvent.keyboard("{Enter}");
expect(screen.getByRole("list")).toBeInTheDocument();
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
await userEvent.keyboard("{ArrowDown}");
await userEvent.keyboard("{ArrowRight}");
await userEvent.keyboard(" ");
expect(handleOnSelect).toHaveBeenCalledTimes(2);
expect(handleOnSelect.mock.calls[1]).toMatchSnapshot();
});
});
const config = { ...requiredParams };
describe("IconSelectControl.canDisplayValue", () => {
it("Should return true when a proper icon name is passed", () => {
expect(IconSelectControl.canDisplayValueInUI(config, "add")).toEqual(true);
expect(IconSelectControl.canDisplayValueInUI(config, "airplane")).toEqual(
true,
);
});
it("Should return false when a non-alowed icon value is passed", () => {
expect(IconSelectControl.canDisplayValueInUI(config, "macbook")).toEqual(
false,
);
});
});
describe("<IconSelectControl /> - (none) icon", () => {
const getTestComponent = (hideNoneIcon?: boolean) => (
<IconSelectControl {...requiredParams} hideNoneIcon={hideNoneIcon} />
);
it("Should display (none) icon when hideNoneIcon property is false/undefined", async () => {
render(getTestComponent());
await userEvent.tab();
expect(screen.getByRole("button")?.textContent).toEqual("(none)caret-down");
await userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
// Check if the (none) icon is in the list
expect(screen.getByText("(none)", { selector: "div" })).toBeInTheDocument();
});
it("Should not display (none) icon when hideNoneIcon property is true", async () => {
render(getTestComponent(true));
await userEvent.tab();
expect(screen.getByRole("button")?.textContent).toEqual("(none)caret-down");
await userEvent.keyboard("{Enter}");
await waitFor(() => {
expect(screen.getByRole("textbox")).toHaveFocus();
}, waitForParamsForSearchFocus);
expect(
document.querySelector("a.bp3-active")?.children[0].classList,
).toMatchSnapshot();
// Check if the (none) icon is in the list
expect(screen.queryByText("(none)", { selector: "div" })).toBeNull();
});
});