## Description
Fixes miscellaneous feedback in the one-click binding feature.
- Order of queries - show select queries on top and order by last
executed query
- Converting from JS to dropdown should be possible for the following
cases
- {{Query.data}}
- Improve query names to be generated using the data table or collection
we use
- undefined table data value should show an error on the property pane
- Download option should be disabled when table is generated using one
click binding
- Remove the insert binding option from the dropdown
#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/24605
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
130 lines
3.5 KiB
TypeScript
130 lines
3.5 KiB
TypeScript
import {
|
|
areArraysEqual,
|
|
createBlobUrl,
|
|
DataType,
|
|
getCamelCaseString,
|
|
getDatatype,
|
|
parseBlobUrl,
|
|
} from "utils/AppsmithUtils";
|
|
import { isURL } from "./TypeHelpers";
|
|
|
|
describe("getCamelCaseString", () => {
|
|
it("Should return a string in camelCase", () => {
|
|
const inputs = ["abcd", "ab12cd", "开关", "😃 😃 😃"];
|
|
const expected = ["abcd", "ab12Cd", "", ""];
|
|
|
|
inputs.forEach((input, index) => {
|
|
const result = getCamelCaseString(input);
|
|
expect(result).toStrictEqual(expected[index]);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("test areArraysEqual", () => {
|
|
it("test areArraysEqual method", () => {
|
|
const OGArray = ["test1", "test2", "test3"];
|
|
|
|
let testArray: string[] = [];
|
|
expect(areArraysEqual(OGArray, testArray)).toBe(false);
|
|
|
|
testArray = ["test1", "test3"];
|
|
expect(areArraysEqual(OGArray, testArray)).toBe(false);
|
|
|
|
testArray = ["test1", "test2", "test3"];
|
|
expect(areArraysEqual(OGArray, testArray)).toBe(true);
|
|
|
|
testArray = ["test1", "test3", "test2"];
|
|
expect(areArraysEqual(OGArray, testArray)).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("isURL", () => {
|
|
test("returns true for valid URLs", () => {
|
|
expect(isURL("http://example.com")).toBe(true);
|
|
expect(isURL("https://www.google.com/search?q=javascript")).toBe(true);
|
|
expect(isURL("https://en.wikipedia.org/wiki/Regular_expression")).toBe(
|
|
true,
|
|
);
|
|
expect(
|
|
isURL("https://www.example.com/path(withparentheses)/file.html"),
|
|
).toBe(true);
|
|
expect(
|
|
isURL("https://www.example.com/path[withparentheses]/file_(1)[2].html"),
|
|
).toBe(true);
|
|
});
|
|
|
|
test("returns false for invalid URLs", () => {
|
|
expect(isURL("http://localhost:3000")).toBe(false);
|
|
expect(isURL("not a URL")).toBe(false);
|
|
expect(isURL("ftp:/example.com")).toBe(false);
|
|
expect(isURL("http://example.")).toBe(false);
|
|
expect(isURL("http://localhost:port")).toBe(false);
|
|
expect(isURL("notAURL")).toBe(false);
|
|
expect(isURL("httpsnotAURL")).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("createBlobUrl", () => {
|
|
beforeEach(() => {
|
|
URL.createObjectURL = jest
|
|
.fn()
|
|
.mockReturnValue(`blob:${window.location.origin}/123-123-123-123-123`);
|
|
});
|
|
|
|
it("should test that it created correct blob URL", () => {
|
|
expect(createBlobUrl(new Blob(), "base64")).toMatch(
|
|
/blob:[a-z0-9-]*\?type=base64/,
|
|
);
|
|
|
|
expect(createBlobUrl(new Blob(), "raw")).toMatch(
|
|
/blob:[a-z0-9-]*\?type=raw/,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("parseBlobUrl", () => {
|
|
it("should test that it created correct blob URL", () => {
|
|
expect(parseBlobUrl("blob:123-123?type=base")).toEqual([
|
|
`blob:${window.location.origin}/123-123`,
|
|
"base",
|
|
]);
|
|
|
|
expect(parseBlobUrl("blob:123-123?type=raw")).toEqual([
|
|
`blob:${window.location.origin}/123-123`,
|
|
"raw",
|
|
]);
|
|
});
|
|
});
|
|
|
|
describe("getDatatype - should test the datatypes", () => {
|
|
it("1. String", () => {
|
|
expect(getDatatype("test")).toBe(DataType.STRING);
|
|
});
|
|
|
|
it("2. Number", () => {
|
|
[1, NaN].forEach((d) => {
|
|
expect(getDatatype(d)).toBe(DataType.NUMBER);
|
|
});
|
|
});
|
|
|
|
it("3. Boolean", () => {
|
|
[true, false].forEach((d) => {
|
|
expect(getDatatype(d)).toBe(DataType.BOOLEAN);
|
|
});
|
|
});
|
|
|
|
it("4. Object", () => {
|
|
expect(getDatatype({})).toBe(DataType.OBJECT);
|
|
});
|
|
|
|
it("5. Array", () => {
|
|
expect(getDatatype([])).toBe(DataType.ARRAY);
|
|
});
|
|
|
|
it("6. Rest of the types", () => {
|
|
expect(getDatatype(null)).toBe(DataType.NULL);
|
|
|
|
expect(getDatatype(undefined)).toBe(DataType.UNDEFINED);
|
|
});
|
|
});
|