## Description Evaluation split changes for EE. 1. RequiresLinting function has moved to common place - on EE extra checks will be added 2. DataTreeFactory - getActionsForCurrentPage changed to getCurrentActions -- which will be modified on EE to acomodate package actions 3. same as above for getJSCollectionsForCurrentPage --> changed to getCurrentJSCollections #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > > #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
108 lines
3.1 KiB
TypeScript
108 lines
3.1 KiB
TypeScript
import React, { useMemo } from "react";
|
|
import type { RouteComponentProps } from "react-router-dom";
|
|
import { Link, withRouter } from "react-router-dom";
|
|
import { useSelector } from "react-redux";
|
|
import { getIsFetchingPage } from "selectors/appViewSelectors";
|
|
import styled from "styled-components";
|
|
import type { AppViewerRouteParams } from "constants/routes";
|
|
import { theme } from "constants/DefaultTheme";
|
|
import { Icon, NonIdealState, Spinner } from "@blueprintjs/core";
|
|
import Centered from "components/designSystems/appsmith/CenteredWrapper";
|
|
import AppPage from "./AppPage";
|
|
import { getCanvasWidth, getCurrentPageName } from "selectors/editorSelectors";
|
|
import RequestConfirmationModal from "pages/Editor/RequestConfirmationModal";
|
|
import { getCurrentApplication } from "@appsmith/selectors/applicationSelectors";
|
|
import {
|
|
isPermitted,
|
|
PERMISSION_TYPE,
|
|
} from "@appsmith/utils/permissionHelpers";
|
|
import { builderURL } from "RouteBuilder";
|
|
import { getCanvasWidgetsStructure } from "@appsmith/selectors/entitiesSelector";
|
|
import equal from "fast-deep-equal/es6";
|
|
|
|
const Section = styled.section`
|
|
height: 100%;
|
|
width: 100%;
|
|
margin: 0 auto;
|
|
position: relative;
|
|
overflow-x: auto;
|
|
overflow-y: auto;
|
|
`;
|
|
|
|
type AppViewerPageContainerProps = RouteComponentProps<AppViewerRouteParams>;
|
|
|
|
function AppViewerPageContainer(props: AppViewerPageContainerProps) {
|
|
const currentPageName = useSelector(getCurrentPageName);
|
|
const widgetsStructure = useSelector(getCanvasWidgetsStructure, equal);
|
|
const canvasWidth = useSelector(getCanvasWidth);
|
|
const isFetchingPage = useSelector(getIsFetchingPage);
|
|
const currentApplication = useSelector(getCurrentApplication);
|
|
const { match } = props;
|
|
|
|
// get appsmith editr link
|
|
const appsmithEditorLink = useMemo(() => {
|
|
if (
|
|
currentApplication?.userPermissions &&
|
|
isPermitted(
|
|
currentApplication?.userPermissions,
|
|
PERMISSION_TYPE.MANAGE_APPLICATION,
|
|
)
|
|
) {
|
|
return (
|
|
<p>
|
|
Please add widgets to this page in the
|
|
<Link
|
|
to={builderURL({
|
|
pageId: props.match.params.pageId as string,
|
|
})}
|
|
>
|
|
Appsmith Editor
|
|
</Link>
|
|
</p>
|
|
);
|
|
}
|
|
}, [currentApplication?.userPermissions]);
|
|
|
|
const pageNotFound = (
|
|
<Centered>
|
|
<NonIdealState
|
|
description={appsmithEditorLink}
|
|
icon={
|
|
<Icon
|
|
color={theme.colors.primaryOld}
|
|
icon="page-layout"
|
|
iconSize={theme.fontSizes[9]}
|
|
/>
|
|
}
|
|
title="This page seems to be blank"
|
|
/>
|
|
</Centered>
|
|
);
|
|
|
|
const pageLoading = (
|
|
<Centered>
|
|
<Spinner />
|
|
</Centered>
|
|
);
|
|
|
|
if (isFetchingPage) return pageLoading;
|
|
|
|
if (!(widgetsStructure.children && widgetsStructure.children.length > 0))
|
|
return pageNotFound;
|
|
|
|
return (
|
|
<Section>
|
|
<AppPage
|
|
appName={currentApplication?.name}
|
|
canvasWidth={canvasWidth}
|
|
pageId={match.params.pageId}
|
|
pageName={currentPageName}
|
|
widgetsStructure={widgetsStructure}
|
|
/>
|
|
<RequestConfirmationModal />
|
|
</Section>
|
|
);
|
|
}
|
|
|
|
export default withRouter(AppViewerPageContainer);
|