Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
9d9524c5bc
PromucFlow_constructor/app/server
History
Naveen Goud cbd7ccc4ec
fix: updated the regex expression to correctly identify the table nam… (#35361) 
**Description**

When the user tries to add a postgres datasource and add any query, if
the table name has hyphens in it, then quotes get assigned to first word
after the schema and the dot. For example, public."counter"-with-db
The quotes should be applied to the whole table name. For example:
public."counter-with-db"

Fixes https://github.com/appsmithorg/appsmith/issues/10631
Fixes https://github.com/appsmithorg/appsmith/issues/30692

**changes in PR:**

1.updated the regec expression to idetify the table name properly with
table name consists of hypens.

2.added a test case for this scenario.

**snapshots:**
before:

![Screenshot from 2024-07-30
17-15-27](https://github.com/user-attachments/assets/98f969da-4cf1-4367-be29-1f3465179a9d)

After:

![Screenshot from 2024-08-01
10-46-53](https://github.com/user-attachments/assets/29411eb7-77af-4a10-9988-a0c076043945)


Hi @ajinkyakulkarni @rohan-arthur @Nikhil-Nandagopal ,Please review this
PR.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced handling of table names in the Postgres plugin to support a
wider variety of characters, including hyphens and special characters.
- Introduced multiple new database tables for improved testing coverage.

- **Bug Fixes**
- Adjusted table name processing to correctly format names containing a
broader range of characters.

- **Tests**
- Added new tests to verify the structure and integrity of tables with
various naming conventions.
	- Expanded existing tests to accommodate additional table structures.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-27 16:21:12 +05:30
..
.run feat: Databricks plugin (#29746) 2023-12-26 10:04:09 +05:30
appsmith-git chore: added prettier spotless plugin for json files (#35447) 2024-08-08 09:16:03 +05:30
appsmith-interfaces chore: Add metrics to pages sub-components (#35723) 2024-08-21 16:30:05 +06:00
appsmith-plugins fix: updated the regex expression to correctly identify the table nam… (#35361) 2024-08-27 16:21:12 +05:30
appsmith-server fix: moved js filter to mongoDB (#35826) 2024-08-23 14:58:32 +05:30
envs test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
mongo-seed
reactive-caching chore: Introduce changes to minimize git footprint (#32595) 2024-04-16 21:34:24 +05:30
scripts chore: Revert "chore: delete redundant files" (#35022) 2024-07-18 16:18:10 +05:30
.gitignore chore: Removed failed tests file from git (#29602) 2023-12-14 13:02:36 +05:30
build.sh test: Enable server tests for the PRs with base PG branch (#33429) 2024-05-22 15:55:20 +05:30
buildpack-run.sh
pom.xml chore: added prettier spotless plugin for json files (#35447) 2024-08-08 09:16:03 +05:30
Procfile
README.md
system.properties

README.md

Appsmith Server

This is the server-side repository for the Appsmith framework.

For details on setting up your development machine, please refer to this Setup Guide.