94e4b8515e
## Description >TL;DR: Added suffix retry if name clashes on creating an application. ## Issue: When multiple users are trying to create an app on a common organization, the changes for newly added app is not real-time hence there's a conflict on app name causing an error. This error asks user to contact Appsmith support, but a simple page refresh loads the new app. Issue: #7401 ## Solution: Added suffix retry if name clashes on creating an application. With this change, the above issue will not happen and in case of name conflict new application will be created with a suffix added in the name. E.g UntitledApplication 1 (1). ## Changes: 1. Added retry suffix method in the ApplicationServiceCEImpl for name clash only. 2. Renamed createDefault method to createDefaultApplication for better readability. 3. Removed AppsmithError and AppsmithErrorCode. Not required with current change. 4. Updated cloneApplicationDocument method in ExamplesWorkspaceClonerCEImpl to directly call createDefaultApplication with contains suffix retry logic. 5. Removed same retry suffix method which is used in ExamplesWorkspaceClonerCEImpl. Not required. 6. Updated test case for this change. Fixes #7401 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Manual : Tested by using backend api. - JUnit ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test |
||
|---|---|---|
| .. | ||
| .run | ||
| appsmith-git | ||
| appsmith-interfaces | ||
| appsmith-plugins | ||
| appsmith-server | ||
| envs | ||
| mongo-seed | ||
| reactive-caching | ||
| scripts | ||
| .gitignore | ||
| build.sh | ||
| buildpack-run.sh | ||
| docker-compose.yml | ||
| Dockerfile | ||
| entrypoint.sh | ||
| pom.xml | ||
| Procfile | ||
| README.md | ||
| system.properties | ||
Appsmith Server
This is the server-side repository for the Appsmith framework.
For details on setting up your development machine, please refer to this Setup Guide.