PromucFlow_constructor/app/client/cypress/fixtures
Rahul Barwal 6c8d4a9a66
fix: Fixes currentRow calculation logic in table(property pane) (#35390)
## Description

<ins>Problem</ins>
`currentRow` variable which is availabe in property pane of col settings
- is not getting correct value during runtime if the table is sorted or
filtered.

<ins>Root cause</ins> 
* We are considering `processedTableData` to get the `currentRow`.
* This property is not updated during filtering and sorting, another
property `filteredTableData` is updated instead.
* We CANNOT use `filteredTableData` as it depends on `primaryColumns`
property which we intend to update as well - this is leading to cyclic
dependency during evaluations.

<ins>Solution</ins>
Since the problem is related to edit cases and given the constraints
around using `filteredTableData` directly, we fixed the problem by
adding a new property to `editableCellValue` object called
`__originalIndex__`.
* This property stores the index of the row being edited in
`processedTableData`
* On top of this change, the PR adds a migration for updating the
current row binding in TableWidgetV2, ensuring accurate current row
calculation and improving the functionality of the widget.
* We also added unit test for migration changes.
* Additionally, This pull request refactors the DSLs for TableWidgetV2
migration test cases to update the DSLs to separate folder, drastically
reducing the file size to its core logic, improving the readability of
the code.
 * We also updated relevant test cases to account for this change.

[Testing
plan](https://www.notion.so/appsmith/Issue-34346-currentRow-doesn-t-work-correctly-when-the-table-is-filtered-449225ae822c485493036599c2b19487)
[Counter part EE
pr](https://github.com/appsmithorg/appsmith-ee/pull/4879)

Fixes #34346
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10451549845>
> Commit: d1d65c6898c223bf3f6dfbfe93b8e8de214fcc7d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10451549845&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 19 Aug 2024 11:15:04 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [x] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Updated DSL migration process to support version 90, enhancing
compatibility and robustness.
- Introduced new migration logic for table widget data bindings,
improving inline editing capabilities.
- Enhanced validation logic for editable cells in table widgets,
allowing for more dynamic data handling.
- Added a method to discard edits in specific table cells, improving
user interaction.
- Introduced a new message constant for required fields, enhancing user
feedback.

- **Bug Fixes**
- Improved validation checks for table cells based on updated indices
and values.

- **Tests**
- Added comprehensive tests to validate migration functions related to
Table Widget, ensuring all aspects function correctly post-update.
- Enhanced test specifications for improved validation logic and
coverage in table widget functionalities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: sneha122 <sneha@appsmith.com>
2024-08-20 13:31:45 +05:30
..
Bugs
Datatypes feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
Files
ImportApps
Listv2 feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
PartialImportExport chore: Remove unused new from JSON exports/responses (#34652) 2024-07-10 10:59:55 +05:30
Table test: Updated file name for remove duplicate (#34821) 2024-07-12 10:07:17 +05:30
Templates
Videos
AAAFlowerVase.jpeg
AAAGlobeChristmas.jpeg
addWidgetTable-mock.json
alignmentWithDynamicHeightDsl.json
AllWidgetsDsl.json
anvilAppTheming.json chore: add tests for app theming (#34839) 2024-07-22 22:08:48 +03:00
anvilButtonWidget.json chore: add tests for app theming (#34839) 2024-07-22 22:08:48 +03:00
anvilCheckboxGroupWidget.json chore: cypress snapshot types (#34722) 2024-07-09 12:06:59 +03:00
anvilCheckboxWidget.json chore: cypress snapshot types (#34722) 2024-07-09 12:06:59 +03:00
anvilCurrencyInputWidget.json test: Fix Anvil DSLs used for testing (#34569) 2024-06-28 11:14:51 +05:30
anvilHeadingWidget.json chore: cypress snapshot types (#34722) 2024-07-09 12:06:59 +03:00
anvilIconButtonWidget.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
anvilInlineButtonWidget.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
anvilInputWidget.json test: Fix Anvil DSLs used for testing (#34569) 2024-06-28 11:14:51 +05:30
anvilParagraphWidget.json chore: cypress snapshot types (#34722) 2024-07-09 12:06:59 +03:00
anvilPhoneInputWidget.json test: Fix Anvil DSLs used for testing (#34569) 2024-06-28 11:14:51 +05:30
anvilRadioGroupWidget.json chore: cypress snapshot types (#34722) 2024-07-09 12:06:59 +03:00
anvilStatsWidget.json chore: cypress snapshot types (#34722) 2024-07-09 12:06:59 +03:00
anvilSwitchGroupWidget.json chore: cypress snapshot types (#34722) 2024-07-09 12:06:59 +03:00
anvilSwitchWidget.json chore: cypress snapshot types (#34722) 2024-07-09 12:06:59 +03:00
anvilTableWidget.json chore: cypress snapshot types (#34722) 2024-07-09 12:06:59 +03:00
anvilToolbarButtonWidget.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
anvilZoneSectionWidget.json chore: cypress snapshot types (#34722) 2024-07-09 12:06:59 +03:00
apiParallelDsl.json
apiTableDsl.json
appNavigationTestingApp.json
appNavigationTestingAppWithLongPageNamesAndTitle.json
Appsmith.gif
appsmithlogo.png
audioWidgetDsl.json
autocomp.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
autoHeightContentAlignmentDSL.json
autoHeightInvisibleWidgetsDSL.json
autoHeightOverlapDSL.json
autoLayoutAutoHeight.json
autoLayoutContainerWidgetDsl.json
autoLayoutCopyPaste.json
autoLayoutReflow.json
AutoLayoutTableWidgetDsl.json
AutolayoutWidgetsDsl.json
base64imagedsl.json
basicDsl.json
basicNumberDataTableDsl.json
basicTabledsl.json
buttonApiDsl.json
buttondsl.json
ButtonGroup_MenuButton_Width_dsl.json
buttonGroupDsl.json
buttonLintErrorDsl.json
buttonRecaptchaDsl.json
CameraDsl.json
CanvasResizeDsl.json
categorySliderWidgetDsl.json
chartCustomDataDsl.json
chartCustomSankeyDataDsl.json
ChartDsl.json
ChartLoadingDsl.json
ChartTextDsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
chartUpdatedDsl.json
checkboxgroupDsl.json
CMSdsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
commondsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
CommunityIssuesExport.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
ConcreteHouse.jpg
containerdsl.json
ContainerWithOtherWidgetsDsl.json
ContextSwitching.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
conversionDslWithDynamicBindings.json
conversionFrAutoLayoutDsl.json
CurrencyInputDynamic.json
CurrencyInputIssueExport.json
customWidget.json
datasources.json chore: Update Postgres port for TED in CI (#34430) 2024-06-25 10:35:15 +05:30
datepicker_switchDsl.json
datePicker2dsl.json
datePickerdsl.json
datePickerV2Updated_dsl.json
debuggerDependencyDsl.json
debuggerTableDsl.json
defaultFilterText.json
defaultMetadataDsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
defaultMetaDsl.json
defaultTableDsl.json
defaultTableV2Dsl.json
DeleteGitRepos.json
deprecatedWidgets.json
disabledWidgetsDsl.json
displayWidgetDsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
DividerDsl.json
DocumentViewerDsl.json
dropDownWidget_reset_check_dsl.json
dynamicHeightCanvasResizeDsl.json
dynamicHeightContainerCheckboxdsl.json
dynamicHeightContainerdsl.json
dynamicHeightContainerScrolldsl.json
DynamicHeightDefaultHeightdsl.json
dynamicHeightFormSwitchdsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
dynamicHeightListDsl.json
DynamicHeightListTextDsl.json
DynamicHeightModalDsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
dynamicHeightStatboxdsl.json
dynamicHeigthContainerFixedDsl.json
dynamicTabWidgetdsl.json
editorContextdsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
emptyDSL.json test: Really empty DSL (#34510) 2024-06-26 20:01:30 +05:30
EmptyListWidget.json
exampleEncodedDocs.js
executeAction.json
executionParamsDsl.json
explorerHiddenWidgets.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
exported-app.json
exportedApp.json
filepickerDsl.json
filePickerTableDSL.json
filePickerV2_reset_check_dsl.json
filePickerV2WidgetReskinDsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
fontData.json
forkedApp.json
forkNonSignedInUser.json
formChangeDSL.json
formDataDsl.json
formdsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
formdsl1.json chore: Upgrade TinyMCE (#35399) 2024-08-08 20:08:09 +05:30
formHasChangesDsl.json
formInputTableDsl.json
formInputTableV2Dsl.json
formResetDsl.json
formSelectDsl.json
formSelectTreeselectDsl.json
formSwitchDsl.json
formWidgetdsl.json
formWidgetWithInputValCheckDsl.json
formWithInputdsl.json
formWithRTEDsl.json
formWithtabdsl.json
gitImport.json
googleSource.json
iconButtonWidgetsDsl.json
IframeDsl.json test: updated tests by replacing external APIs (#32718) 2024-04-18 19:01:46 +05:30
IframeOnSrcDocChange.json test: updated tests by replacing external APIs (#32718) 2024-04-18 19:01:46 +05:30
ImageHugWidgetDsl.json
ImportAppAllAccess.json
ImportAppReadAccess.json
ImportAppReadWriteAccess.json
ImportAppSelectedAccess.json
inputBindingdsl.json
inputdsl.json
inputMaxCharDsl.json
inputWidgetMobileDsl.json
InputWidgetV2InsideListDSL.json
Invalid_binding_dsl.json
invisibleWidgetdsl.json
Js_toggle_dsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
JSApiOnLoadDsl.json
jsFunctionTriggerDsl.json
JSObjectMutationTestApp.json
JsObjecWithGitdsl.json
JSObjOnLoadApp.json
jsonFormDslWithoutSchema.json
jsonFormDslWithSchema.json
jsonFormDslWithSchemaAndWithoutSourceData.json
jsonFormDynamicHeightDsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
jsonFormInModalDsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
jsonFormUnicodeDSLWithoutSourceData.json
jsonTextDsl.json
largeJSONData.json
layoutdsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
lazyRender.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
library_export.json
listdsl.json
listRegression2Dsl.json
listRegression3Dsl.json
listRegressionDsl.json
listV2AudioVideoDsl.json
listV2ButtonsDsl.json
listV2NestedDsl.json
listv2PaginationDsl.json
ListVulnerabilityDSL.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
listwidgetData.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
listwidgetdsl.json
listWidgetLintDsl.json
ListWidgetWithDataAndButtonDSL.json
longCanvasDsl.json
mainContainerOverflow.json
MapChartDsl.json
Mapdsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
menuButtonDsl.json
mobileresponisvenessDsl.json
mobileresponsiveness_multipleDsl.json
mobileViewScrollDsl.json
ModalDsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
modalOnTableFilterPaneDsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
modalScroll.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
modalWidgetBGcolorDSL.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
modalWidgetTestApp.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
mongo_GET_Actions.json
mongo_GET_selectTableDropdown.json
mongo_POST_Actions.json
mongo_PUT_replaceLayoutWithCRUD.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
mongoAppdsl.json
multiPartFormDataDsl.json
multipleContainerdsl.json
MultipleInput.json
MultipleWidgetDsl.json
multiSelectDsl.json
multiSelectedRowUpdationDsl.json
multiSelectedRowUpdationTableV2Dsl.json
multiTreeSelectDsl.json
mySQL_GET_Actions.json
mySQL_GET_selectTableDropdown.json
mySQL_POST_Execute.json
mySQL_PUT_replaceLayoutWithCRUD.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
navigateToInputDsl.json
navigateTotabledsl.json
newFormDsl.json
noiseDsl.json
numberSliderWidgetDsl.json
omnibarDsl.json
one_postgres.json
onPageLoadActionsDsl.json
PageLoadDsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
paramsDsl.json
patchjson.txt
PgAdmindsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
PhoneInputDynamic.json
plugins.json
postInviteStub.json
postjson.txt
previewMode.json
promisesBtnDsl.json
promisesBtnImgDsl.json
promisesBtnListDsl.json
promisesStoreValueDsl.json
PropertyPaneSlashMenuBindings.json fix: slash menu command show all available queries and datasources fixed (#33076) 2024-05-08 11:43:09 +05:30
publishedModeToastToggleDsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
putjson.txt
qr.mjpeg
radioGroup_int_value_dsl.json
rangeSliderWidgetDsl.json
replay.json
REPO.ts
resetPassword.json
resetWidgetDSL.json
ResizeListDsl.json
richTextEditorDsl.json
rundsl.json
sample-pdf-file.pdf
Sample.tsv
SampleAppIDETest.json chore: Add Editor Pane segments context switch tests (#32224) 2024-03-29 11:48:59 +05:30
SampleXLS.xls
saveAction.json
Select_table_dsl.json
SelectDslWithEmptyOptions.json
selectMultiSelectTreeSelectWidgetDsl.json
selectWidgetDsl.json
SimpleBinding.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
slashcommandDsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
SMTPTestdsl.json
snippetDsl.json
snippetErrordsl.json
snippingTableDsl.json
StatboxDsl.json
SwitchGroupWidgetDsl.json
swtchTableDsl.json
swtchTableV2Dsl.json
tabdsl.json
tabInputDsl.json
tableAndChart.json
tableAndTextDsl.json
TableClientSearch.json
TableFilterImportApp.json
tableInputDsl.json
TableMigrationAppExported.json
TableMigrationDsl.json
tableNewDsl.json
tableNewDslWithPagination.json
tableResizedColumnsDsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
tableTextPaginationDsl.json
tablev1NewDsl.json
tableV2AndTextDsl.json
TableV2ClientSearch.json
tableV2ColumnOrderDsl.json
tableV2NewDsl.json
tableV2NewDslWithPagination.json fix: Fixes currentRow calculation logic in table(property pane) (#35390) 2024-08-20 13:31:45 +05:30
tableV2ResizedColumnsDsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
tableV2TextPaginationDsl.json
tableV2WidgetCondnFormatDsl.json
tableV2WidgetDsl.json
tableV2WithTextWidgetDsl.json
tableV2WithUrlColumnDsl.json
tableWidgetCondnFormatDsl.json
TableWidgetDatawithEmptyKeys.json
tableWidgetDsl.json
tableWithNumberColumnDsl.json
tableWithTextWidgetDsl.json
tabsDsl.json
tabsWidgetDsl.json
tabsWidgetReset.json
tabsWithWidgetDsl.json
templatePageWithNullbindings.json
Test_csv.csv
test-data-gsheet.ts
test.ppt
testAction.json
testdata.json
TestDataSet1.json
testDoc.docx
testFile.mov
testFile2.mov
testRemoveFile1.json fix: file picker widgets removing files causing abnormal content (#31646) 2024-03-11 18:13:12 +05:30
testRemoveFile2.json fix: file picker widgets removing files causing abnormal content (#31646) 2024-03-11 18:13:12 +05:30
TestSpreadsheet.xlsx
textDsl.json
textLintErrorDsl.json
textNewDsl.json
TextTabledsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
TextTableV2dsl.json test: Remove unused data in DSL fixtures (#34405) 2024-06-24 17:17:43 +05:30
textWidgetDsl.json
textWidgetDynamicdsl.json
ThemeAppdsl.json
TreeSelectDsl.json
uiBindDsl.json feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
US_PopulationTest.xlsx
user.json
variables.ts
videoWidgetApp.json
viewdsl.json
WidgetCopyPaste.json
widgetPopupDsl.json
widgetSelection.json
xmlParser.json