PromucFlow_constructor/app/client/cypress/locators
Hetu Nandu c28bea180c
fix: Selected Widget Visibility (#21317)
## Description

### Part 3 of selected widget refactor

As part of context switching and selected widget refactor, we saw that
widgets that are inside modals or tabs and are hidden cannot be switched
to without updating some meta properties. The meta properties are
actually owned by the end user and the developer user would create some
default values for it as well. This becomes a problem soon when the
platform also tries to update it. So as part of this refactor, we will
use the selected widget ancestry (the chain of widgets from the top to
the currently selected widget) to handle if widgets need to be visible
or not. It will also indicate the widgets in the path of selection to
"make way" for the selected widget to be seen.

Media


https://user-images.githubusercontent.com/12022471/224916943-b10e8694-0c95-4157-bb93-288d7c0bf60a.mov

- This works on any number of levels of hirarchy
- The logic is supposed to handled by each widget that can potentially
hide other widgets inside it
- Improves some platform perf as the handing so widget meta is not done
by the platform anymore

Affected widgets:
- Modal Widget
- Tabs Widget

> tl;dr: Update the platform's way to show widgets that can be hidden.
Makes sure a selected widget is always shown.

Fixes #1282
Resolves #18173


## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual
- Cypress

### Test Plan
> Test case link:-
[#2202](https://github.com/appsmithorg/TestSmith/issues/2202)

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity:-
https://github.com/appsmithorg/appsmith/issues/1282#issuecomment-1472204952


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [x] Test plan has been approved by relevant developers
- [x] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-03-23 11:13:07 +05:30
..
AdminsSettings.js feat: embed settings (#16629) 2022-11-25 09:16:20 +05:30
ApiEditor.js fix: Auto-generated header Refactor (#19873) 2023-02-24 12:18:48 +00:00
apiWidgetslocator.json fix: Auto-generated header Refactor (#19873) 2023-02-24 12:18:48 +00:00
Applications.json fix: fork app button not opening the fork modal for non-signed in users (#12479) 2022-04-11 10:44:50 +05:30
CMSApplocators.js test: Flaky test fix (#21019) 2023-03-02 02:28:48 +05:30
commonlocators.json fix: Selected Widget Visibility (#21317) 2023-03-23 11:13:07 +05:30
DatasourcesEditor.json test: Moving specs to run on FatContainer + Gitea migration (#18920) 2023-01-25 11:09:02 +05:30
DynamicInput.json feat: keyboard accessible multi-select dropdown, action selector and text input (#10622) 2022-02-10 16:42:44 +05:30
EnterpriseAdminSettingsLocators.json fix: Cypress tests for admin settings's watermark setting (#15760) 2022-08-11 17:35:08 +02:00
explorerlocators.json chore: Revert "feat: move the widget creation CTA off the Entity explorer (#… (#20335) 2023-02-03 14:47:01 +06:00
FirstTimeUserOnboarding.json chore: Revert "feat: move the widget creation CTA off the Entity explorer (#… (#20335) 2023-02-03 14:47:01 +06:00
FormControl.json feat: Simplified Google Sheets queries (#14869) 2022-07-04 11:13:27 +05:30
FormWidgets.json feat: Auto height instant update (#19082) 2023-02-03 11:17:40 +05:30
GeneratePage.json feat: fork templates inside an existing app (#17184) 2022-09-30 19:11:04 +05:30
GithubForm.json chore: update a cypress test (#13036) 2022-04-21 11:44:02 +05:30
gitSyncLocators.js test: Fix flaky tests + Add clean up for git repos (#20319) 2023-02-06 13:07:01 +05:30
GlobalSearch.json fix: inconsistency in naming actions from omnibar (#13898) 2022-05-25 15:10:06 +05:30
GoogleForm.json fix: Adding a fix for copy clipboard URL not working on HTTP domain (#21313) 2023-03-14 11:41:52 +05:30
GuidedTour.json test: Flaky test fix (#21120) 2023-03-05 08:52:42 +05:30
HelpLocators.json
HomePage.js feat: in-app embed settings (#19023) 2022-12-26 10:41:33 +05:30
jsActionLocators.json
JSEditor.json feat: js object v1 run and settings redesign (#11456) 2022-04-28 17:51:02 +01:00
jsonFormWidget.json test:JsonForm test for multi source data (#14153) 2022-06-08 16:21:53 +05:30
Layout.json feat: Auto height instant update (#19082) 2023-02-03 11:17:40 +05:30
LoginPage.json fix: fork app button not opening the fork modal for non-signed in users (#12479) 2022-04-11 10:44:50 +05:30
ModalWidget.json feat: Validations for Action Forms (#10457) 2022-01-27 15:20:05 +05:30
Omnibar.json test: Add visual tests for datasource page (#14811) 2022-07-01 09:01:02 +05:30
Onboarding.json
Pages.json feat: Revamp deletion flow (#11774) 2022-03-23 05:33:06 +00:00
PgAdminlocators.json test: Fix flaky tests + Add clean up for git repos (#20319) 2023-02-06 13:07:01 +05:30
publishWidgetspage.json feat: Code Scanner Widget (#15990) 2022-09-16 10:25:32 +05:30
QueryEditor.json fix: Add collapse icon for bottom bar (#16939) 2022-10-20 17:38:48 +05:30
ReconnectLocators.js feat: 12457 - added application import success modal (#12739) 2022-04-27 12:07:04 +05:30
SignupPage.json
TemplatesLocators.json test: Cypress Flaky fixes + Mock api update + PgAdminspec fix (#20032) 2023-02-02 13:29:24 +05:30
ThemeLocators.json chore: Makes use of DS components in ThemeControls (#19000) 2022-12-23 15:37:29 +05:30
ViewWidgets.json test: List testcases (#14009) 2022-05-26 13:25:08 +05:30
welcomePage.json
WidgetLocators.ts test: Cypress - Automated basic tests for MsSQL DS (#21446) 2023-03-16 23:58:32 +05:30
Widgets.json feat: Auto layout appsmith editor and mobile responsiveness (#21151) 2023-03-04 12:55:54 +05:30