b863b39d69
## Description This change adds a linting error for direct mutation of widget property like `Widget.property = "dsf"` and instead suggests to use setter methods. #### PR fixes following issue(s) Fixes #5822 #### Type of change - New feature (non-breaking change which adds functionality) ## Testing - [x] Add jest tests as mentioned in the [comments](https://www.notion.so/appsmith/Widget-Property-Setters-Tech-Spec-2a34730e2e6d4df8ae7637c363b1096c?pvs=4#276554d9875b42d68868aa969e9d7d03) of the tech spec document for this project. - [x] Add test to verify linting error for widget assignment - [x] Add cypress test for autocomplete of more setter methods - [x] Add cypress test for currencyInput setValue #### How Has This Been Tested? - [ ] Manual - [ ] Jest - [x] Cypress #### Test Plan #### Issues raised during DP testing ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [x] Cypress test cases have been added and approved by SDET/manual QA - [x] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: Druthi Polisetty <druthi@appsmith.com> |
||
|---|---|---|
| .. | ||
| Autocomplete_setters_spec.ts | ||
| autocomplete_spec.js | ||
| BracketNotation_AC_spec.ts | ||
| Bug23641_Spec.ts | ||
| Bugs_AC_Spec.ts | ||
| JS_AC1_spec.ts | ||
| JS_AC2_spec.ts | ||
| PropertyPaneSuggestion_spec.ts | ||
| Sql_AC_Spec.ts | ||