a182e7409d
## Description **Problem:** When running Cypress tests multiple times with the cypress-repeat-pro --force option, we only see success messages. This is because the `--force` option may override or mask failures, leading to misleading results. **Solution:** To address this, we have added a step to check for specific failure indicators in the test summary file. If the summary indicates that there were any failed tests (i.e., `Total Failed: 0` is not present), the GitHub Action step will fail. This ensures that failures are properly highlighted and reported in the PR comments. Fixes #`36232` ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10806403675> > Commit: 3a04b01650a4f92967d6b489eead5d61e48cb89a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10806403675&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 11 Sep 2024 07:01:29 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced CI workflow to ensure GitHub Action fails if Cypress tests do not pass, improving reliability. - **Bug Fixes** - Implemented a conditional check for test failures, providing clearer feedback on test outcomes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|---|---|---|
| .. | ||
| ISSUE_TEMPLATE | ||
| workflows | ||
| config-test.json | ||
| config.json | ||
| config.yml | ||
| labeler.yml | ||
| pull_request_template.md | ||
| release-drafter-template.yml | ||
| reviewers.yml | ||
| semantic.yml | ||