Fixes #22537 - [x] check for test failures in CE & EE - [ ] check for merge conflicts in EE (index.js) ## Description cy command : `LoginFromAPI` We were calling the login API as a XHR call and navigated to `/applications` manually in cases where login has actually failed. Login success & errors are now handled properly. - Now it will behave like submitting a form. (https://docs.cypress.io/api/commands/visit#Submit-a-form) - Performs navigation to `/applications` automatically on login success. - Performs navigation to `/login?error=true` automatically on login failure. - Added origin as a header. ## Media Before: (navigates to /application even when login fails) https://www.loom.com/share/086ef8c743ab460194b785a4d22e87cf Now: (stops when login fails) https://www.loom.com/share/cc78be2ee2944d0ab9f094f8fd709539 ## Type of change - Chore (housekeeping or task changes that don't impact user perception) ## How Has This Been Tested? - Cypress ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag |
||
|---|---|---|
| .. | ||
| Objects | ||
| Pages | ||
| AdminSettingsCommands.js | ||
| ApiCommands.js | ||
| commands.js | ||
| Constants.js | ||
| dataSourceCommands.js | ||
| gitSync.js | ||
| index.js | ||
| queryCommands.js | ||
| themeCommands.js | ||
| timeout.js | ||
| widgetCommands.js | ||
| WorkspaceCommands.js | ||