PromucFlow_constructor/app/client/cypress/e2e/Regression/ClientSide
sneha122 881ac75ff7
fix: empty query response on page load issue fixed (#28296)
## Description

When we bind a successfully running query to a widget, the query gets
executed on page load, so in such a case, we were able to see the query
in the widget, but when visiting query editor, response tab is empty.
This PR fixes that issue.

<img width="904" alt="Screenshot 2023-10-23 at 3 35 50 PM"
src="https://github.com/appsmithorg/appsmith/assets/30018882/b0244c87-d18f-4d8c-ad35-35cd1f4abfd6">


**Root Cause:**
In order to see the response in the response tab, we need to have action
config, execute API response and responseDisplayFormat to be present.
responseDisplayFormat denotes whether to show response in Table, Json or
Raw format.
This responseDisplayFormat gets set in `setDefaultActionDisplayFormat`
method. This property is set on action config object itself. This method
is called from execute `executePluginActionSaga` and
`executePluginActionSaga` is called from `executePageLoadAction`, so the
flow of actions looks as below:

- `executePageLoadAction`
      - `executePluginActionSaga`
              - `setDefaultActionDisplayFormat`

Once the responseDisplayFormat was set, `executePageLoadAction` was
again resetting the action config object in the redux store, thus
removing this responseDisplayFormat property and hence empty response
tab.

**Note: This bug is not a regression, it has existed from a long time.**

#### PR fixes following issue(s)
Fixes #28287 
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Bug fix (non-breaking change which fixes an issue)
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2023-10-26 15:09:00 +05:30
..
ActionExecution test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
AdminSettings test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
AppNavigation test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
AssistiveBinding feat: assistive binding (#27070) 2023-09-15 21:23:51 +05:30
AuditLogs chore: Optimising the code for admin settings page (#25404) 2023-07-18 15:18:48 +05:30
Autocomplete fix: improve autocompletion hints discovery (#28222) 2023-10-25 18:18:45 +01:00
Binding chore: remove xml parser v3 as a default library (#28012) 2023-10-20 11:08:47 +05:30
Branding
BugTests fix: empty query response on page load issue fixed (#28296) 2023-10-26 15:09:00 +05:30
CodeComment test: Cypress | Simplifying AddDsl method (#24991) 2023-07-04 22:03:31 +05:30
CommunityTemplate feat: community templates UI (#27302) 2023-09-25 11:57:23 +05:30
Debugger feat: JSON form widget one click binding integration (#25873) 2023-10-03 13:40:51 +05:30
DynamicHeight test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
Editor fix: excluding intercom test cases for airgap (#23974) 2023-06-02 12:10:49 +05:30
EmbedSettings test: Cypess | Oracle DS validations added (Part 4) + CI Stabilize (#27348) 2023-09-19 14:17:30 +05:30
ExplorerTests test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
Fork test: Cypress | CI Stabilize + Other test improvements (#28172) 2023-10-20 07:45:47 +05:30
FormLogin test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
FormNativeToRawTests test: Gsheet Automation (#25255) 2023-07-26 18:56:24 +05:30
Git test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
Github test: Cypress - Flaky Fix (#26272) 2023-08-17 16:00:37 +05:30
Google test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
IDE fix: Removes platform functions from autocomplete list in data fields (#28217) 2023-10-24 12:13:37 +05:30
JSLibrary test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
JSObject fix: Race condition in JS object mutation (#28083) 2023-10-16 13:32:27 +05:30
Linting test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
MobileResponsiveTests test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
Onboarding chore: skip signposting discovery test (#27892) 2023-10-17 17:32:05 +05:30
OneClickBinding feat: JSON form widget one click binding integration (#25873) 2023-10-03 13:40:51 +05:30
OtherUIFeatures test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
PeekOverlay test: Cypress | (DI) Arango added validations + CI Stabilize (#26243) 2023-08-18 10:48:35 +05:30
Performance feat: Improve Linting performance (#23865) 2023-07-05 14:34:03 +01:00
ProductRamps fix: Ramp selector link to redirect on portal (#28179) 2023-10-18 18:07:26 +05:30
PropertyPane test: Cypress | Simplifying AddDsl method (#24991) 2023-07-04 22:03:31 +05:30
PublishedApps test: Cypress | (DI) Arango added validations + CI Stabilize (#26243) 2023-08-18 10:48:35 +05:30
Refactoring feat: enable generate CRUD page for MsSQL plugin (#27195) 2023-09-20 14:12:11 +05:30
SettingsPane test: Cypress | CI Stablize + verifying DS Connection Errors (DI) (#26004) 2023-08-08 14:44:46 +05:30
Templates test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30
ThemingTests test: Cypress - themes cases (#27682) 2023-09-29 11:38:15 +05:30
UserProfile
VisualTests test: Cypress | CI Stabilize + Other test improvements (#28172) 2023-10-20 07:45:47 +05:30
Walkthrough fix: run before walkthrough function to select widget before showing it (#27688) 2023-10-06 15:33:27 +05:30
Widgets test: Cypress | IconButton_2_spec.ts flaky fix (#28379) 2023-10-26 02:35:34 +05:30
Workspace test: Cypress | CI Stablize + Other improvements (#28254) 2023-10-25 19:33:07 +05:30